Re: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetVariableMtrr()

["Laszlo Ersek" <lersek@redhat.com>]

On 07/13/20 10:12, Ni, Ray wrote:
> MtrrSetVariableMtrr() sets all the variable MTRR settings.
> But in fact MtrrSetAllMtrrs() is always used by callers to set all
> MTRR settings including the fixed and variable ones.
> 
> The patch removes the necessary API MtrrSetVariableMtrr() to simplify

(1) necessary -> unnecessary

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo

> the MtrrLib API.
> 
> There is no code in edk2 and edk2-platforms repo that calls
> MtrrGetVariableMtrr().
> 
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
>  UefiCpuPkg/Include/Library/MtrrLib.h | 15 --------------
>  UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 29 ----------------------------
>  2 files changed, 44 deletions(-)
> 
> diff --git a/UefiCpuPkg/Include/Library/MtrrLib.h b/UefiCpuPkg/Include/Library/MtrrLib.h
> index cfe3c0ab59..0bc69e235c 100644
> --- a/UefiCpuPkg/Include/Library/MtrrLib.h
> +++ b/UefiCpuPkg/Include/Library/MtrrLib.h
> @@ -185,21 +185,6 @@ MtrrGetMemoryAttribute (
>    );
>  
>  
> -/**
> -  This function sets variable MTRRs
> -
> -  @param[in]  VariableSettings   A buffer to hold variable MTRRs content.
> -
> -  @return The pointer of VariableSettings
> -
> -**/
> -MTRR_VARIABLE_SETTINGS*
> -EFIAPI
> -MtrrSetVariableMtrr (
> -  IN MTRR_VARIABLE_SETTINGS         *VariableSettings
> -  );
> -
> -
>  /**
>    This function gets the content in fixed MTRRs
>  
> diff --git a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
> index f4a10edc87..8b54f2c03b 100644
> --- a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
> +++ b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
> @@ -2558,35 +2558,6 @@ MtrrSetVariableMtrrWorker (
>    }
>  }
>  
> -
> -/**
> -  This function sets variable MTRRs
> -
> -  @param[in]  VariableSettings   A buffer to hold variable MTRRs content.
> -
> -  @return The pointer of VariableSettings
> -
> -**/
> -MTRR_VARIABLE_SETTINGS*
> -EFIAPI
> -MtrrSetVariableMtrr (
> -  IN MTRR_VARIABLE_SETTINGS         *VariableSettings
> -  )
> -{
> -  MTRR_CONTEXT  MtrrContext;
> -
> -  if (!IsMtrrSupported ()) {
> -    return VariableSettings;
> -  }
> -
> -  MtrrLibPreMtrrChange (&MtrrContext);
> -  MtrrSetVariableMtrrWorker (VariableSettings);
> -  MtrrLibPostMtrrChange (&MtrrContext);
> -  MtrrDebugPrintAllMtrrs ();
> -
> -  return  VariableSettings;
> -}
> -
>  /**
>    Worker function setting fixed MTRRs
>  
>