From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::c42; helo=mail-yw1-xc42.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-yw1-xc42.google.com (mail-yw1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0B998211E7437 for ; Thu, 21 Mar 2019 21:27:33 -0700 (PDT) Received: by mail-yw1-xc42.google.com with SMTP id z191so865380ywa.6 for ; Thu, 21 Mar 2019 21:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FhvGsFTVzgHL21wijRV/MlAhw8hHjYDr8d3GefpZr8Y=; b=zVwj3z9YNybcNv/I4cfxFow2kL1voyREt61a2pxl0D6X77ifbPEj7HcK5Awde2PEmx l9EWah15yYPoqiDTy329wzgiRSMOsPkQrnKbLJyuXG1/XVXMGmSsbbXaLFxV0kdQXMlr ic6cIi6hx/sabT+MQNPMXaMX1n+A3UTbN5b9II7glgbzh0MFAw+V9VqG0+4T256r21ei 3zvwfjq5fvyJcig2YOg1jNBbef044vr4zJ+4QypxajNbeh+kDYBb0ffeSzeGjMmfq3mL NT/mwXcun7I/iAHSjeIMOO3+xiEBAuyj3zdt4NxbeqZvI43d+IroAUXnIhZ+AQWQyqHU uiww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FhvGsFTVzgHL21wijRV/MlAhw8hHjYDr8d3GefpZr8Y=; b=DxVVzn2SaPHeVCvjewYnVo44cUxT2VdzCL5U0hjYs0Q+h7W/IxQ+tggy0IAReNLPeL UMTm+yeeH6I8GBYA//2EFaH9etb1p4iM+GJyTo6MGtbj1Boj4zUWIHhFWmeq47zXlusn SQ3nW0J8szzs67zPJd6/hyz4CUub/pdU0LkXZ67SFzWIhoMmL0YZSDCp7yKgzHj1/7Y/ dn2n4m4rdI9WtIOLg6Qe7B9TPE7QhdIgXZNNOCHPYQ6qnivUTqVbIEUjbvf4YS8U2FJF mvzsHKPHS9HQFCwTtSTW448/RPO39MlZ/24FLXetR7oWd/eHSNPU95gcbIVepC7Kx3p4 Hnbg== X-Gm-Message-State: APjAAAWroS2bLS0uWyhJRQfPdroaYZ6q94bYJHi/vkQXLC5cYtWJ5afi 9H+1ayMoKS6Zr3pbG7ZKpuKP9g== X-Google-Smtp-Source: APXvYqw46IWfYozz77z+dDY1SoEN6LY6exNU0NCj0GzKzqALMnL+nOmjclSTlhAFi3yZQaorzWP8Ig== X-Received: by 2002:a0d:e4c1:: with SMTP id n184mr6290047ywe.100.1553228852753; Thu, 21 Mar 2019 21:27:32 -0700 (PDT) Received: from [10.95.0.10] ([64.64.108.214]) by smtp.gmail.com with ESMTPSA id x8sm3351367ywb.106.2019.03.21.21.27.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Mar 2019 21:27:32 -0700 (PDT) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, zhangfeng56@huawei.com, xiaojun2@hisilicon.com References: <20190320080829.52003-1-ming.huang@linaro.org> <20190320080829.52003-6-ming.huang@linaro.org> <20190321175217.wwkpqdmcanlytyzl@bivouac.eciton.net> <20190321175632.okf7ix3dcnojajhl@bivouac.eciton.net> From: Ming Huang Message-ID: Date: Fri, 22 Mar 2019 12:27:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20190321175632.okf7ix3dcnojajhl@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v3 05/18] Hisilicon/D06: Fix access variable fail issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2019 04:27:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/22/2019 1:56 AM, Leif Lindholm wrote: > Urgh, this was an unfortunate off-by-one post: > I am deferring this patch until after Linaro's 2019.03 firmware > release and cherry-picking it into that. There must be a better way to > solve this. > > My comment referred to "Hisilicon/D06: Drop the leading 0 (0x0 -> > 0x)", which will be pushed with an improved subject. I will change subject to: Add runtime attribution to OemConfig variable Should I change author to me to remove the "From: Jason Zhang"? Thanks > > / > Leif > > On Thu, Mar 21, 2019 at 05:52:18PM +0000, Leif Lindholm wrote: >> I will update the subject line to reflect what is actually being >> changed. >> >> Other than that, >> Reviewed-by: Leif Lindholm >> >> >> On Wed, Mar 20, 2019 at 04:08:16PM +0800, Ming Huang wrote: >>> From: Jason Zhang >>> >>> BmcWdtEnable is a field of OemConfigData structure, need have >>> runtime service attribution if use it during exit boot service >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ming Huang >>> --- >>> Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr | 2 +- >>> Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr >>> index 470e9ace3dcf..08236704fbfe 100644 >>> --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr >>> +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr >>> @@ -23,7 +23,7 @@ formset >>> help = STRING_TOKEN(STR_OEM_CONFIG), >>> classguid = gEfiIfrFrontPageGuid, // for MdeModule Bds. >>> efivarstore OEM_CONFIG_DATA, >>> - attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE, >>> + attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS, >>> name = OemConfig, >>> guid = gOemConfigGuid; >>> >>> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c >>> index 012d45bc0214..6668103af027 100644 >>> --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c >>> +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c >>> @@ -316,7 +316,7 @@ OemConfigUiLibConstructor ( >>> Status = gRT->SetVariable ( >>> OEM_CONFIG_NAME, >>> &gOemConfigGuid, >>> - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS, >>> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, >>> sizeof (OEM_CONFIG_DATA), >>> &Configuration >>> ); >>> -- >>> 2.9.5 >>>