Re: [PATCH 2/4] ArmVirtPkg/FdtClientDxe: report address and size cell count directly

[Laszlo Ersek <lersek@redhat.com>]

On 09/15/16 15:30, Ard Biesheuvel wrote:
> The FDT client protocol methods dealing with "reg" properties return
> the size of a 'reg' element. Currently, we have hardcoded this as '8',
> since #address-cells == #size-cells == 2 in most cases. However, for
> different values, have a single 'reg' element size is not unambiguous,
> since - however unlikely - if #address-cells != #size-cells, we do not
> know which is which.
> 
> So before adding more methods to the protocol, fix up this oversight.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmVirtPkg/FdtClientDxe/FdtClientDxe.c                   |  6 ++++--
>  ArmVirtPkg/Include/Protocol/FdtClient.h                  |  3 ++-
>  ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c |  9 ++++++---
>  ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c           |  9 ++++++---
>  ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.c       |  8 ++++++--
>  ArmVirtPkg/XenioFdtDxe/XenioFdtDxe.c                     | 10 +++++++---
>  6 files changed, 31 insertions(+), 14 deletions(-)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>