From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3C9AF1A1EFA for ; Thu, 15 Sep 2016 06:42:04 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C95E8C01A698; Thu, 15 Sep 2016 13:42:03 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-94.phx2.redhat.com [10.3.116.94]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8FDg2tR013460; Thu, 15 Sep 2016 09:42:02 -0400 To: Ard Biesheuvel , edk2-devel@ml01.01.org References: <1473946233-10547-1-git-send-email-ard.biesheuvel@linaro.org> <1473946233-10547-3-git-send-email-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: Date: Thu, 15 Sep 2016 15:42:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473946233-10547-3-git-send-email-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 15 Sep 2016 13:42:03 +0000 (UTC) Subject: Re: [PATCH 2/4] ArmVirtPkg/FdtClientDxe: report address and size cell count directly X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2016 13:42:04 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 09/15/16 15:30, Ard Biesheuvel wrote: > The FDT client protocol methods dealing with "reg" properties return > the size of a 'reg' element. Currently, we have hardcoded this as '8', > since #address-cells == #size-cells == 2 in most cases. However, for > different values, have a single 'reg' element size is not unambiguous, > since - however unlikely - if #address-cells != #size-cells, we do not > know which is which. > > So before adding more methods to the protocol, fix up this oversight. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 6 ++++-- > ArmVirtPkg/Include/Protocol/FdtClient.h | 3 ++- > ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c | 9 ++++++--- > ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 9 ++++++--- > ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.c | 8 ++++++-- > ArmVirtPkg/XenioFdtDxe/XenioFdtDxe.c | 10 +++++++--- > 6 files changed, 31 insertions(+), 14 deletions(-) Reviewed-by: Laszlo Ersek