Re: [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

["Liming Gao" <liming.gao@intel.com>]

EDKII DEC spec https://github.com/tianocore-docs/edk2-DecSpecification/tree/release/1.27/2_dec_file_overview 

DEC File Overview

An EDK II Package (directory) is a directory that contains an EDK II package declaration (DEC) file. Only one DEC file is permitted per directory. EDK II Packages cannot be nested within other EDK II Packages.

Thanks
Liming
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: 2020年3月31日 13:03
To: Gao, Liming <liming.gao@intel.com>; Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io
Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

Liming,
Where can I find the rule?

Thanks,
Ray

> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Tuesday, March 31, 2020 10:52 AM
> To: Luo, Heng <heng.luo@intel.com>; Ni, Ray <ray.ni@intel.com>; 
> devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of feature 
> domains to package path
> 
> Ray:
>   Package has dec file in its root directory. Package DSC file is optional.
> 
> Thanks
> Liming
> -----Original Message-----
> From: Luo, Heng <heng.luo@intel.com>
> Sent: 2020年3月31日 9:25
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming 
> <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of feature 
> domains to package path
> 
> Hi Liming,
> I will apply the change below if you agree to  we treat a folder that contains ".dec" and "dsc" files as a package directory:
> 
> diff --git a/Platform/Intel/build_bios.py 
> b/Platform/Intel/build_bios.py index b9ad980510..bb25699ed8 100644
> --- a/Platform/Intel/build_bios.py
> +++ b/Platform/Intel/build_bios.py
> @@ -16,6 +16,7 @@ imported functions from board directory  import os  
> import re  import sys
> +import glob
>  import signal
>  import shutil
>  import argparse
> @@ -123,7 +124,10 @@ def pre_build(build_config, build_type="DEBUG", silent=False, toolchain=None):
>      # add all feature domains in WORKSPACE_FEATURES to package path
>      for filename in os.listdir(config["WORKSPACE_FEATURES"]):
>          filepath = os.path.join(config["WORKSPACE_FEATURES"], filename)
> -        if os.path.isdir(filepath):
> +        # feature domains folder does not contain dec or dsc file
> +        if os.path.isdir(filepath) and \
> +          not glob.glob(os.path.join(filepath, "*.dec")) and \
> +          not glob.glob(os.path.join(filepath, "*.dsc")):
>              config["PACKAGES_PATH"] += os.pathsep + filepath
>      config["PACKAGES_PATH"] += os.pathsep + config["WORKSPACE_DRIVERS"]
>      config["PACKAGES_PATH"] += os.pathsep + \
> 
> Best Regards
> Heng
> 
> > -----Original Message-----
> > From: Ni, Ray <ray.ni@intel.com>
> > Sent: Monday, March 30, 2020 5:01 PM
> > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io
> > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming 
> > <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>
> > Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of feature 
> > domains to package path
> >
> > > +    # add all feature domains in WORKSPACE_FEATURES to package path
> > > +    for filename in os.listdir(config["WORKSPACE_FEATURES"]):
> > > +        filepath = os.path.join(config["WORKSPACE_FEATURES"], filename)
> > > +        if os.path.isdir(filepath):
> > > +            config["PACKAGES_PATH"] += os.pathsep + filepath
> >
> > Will this change include "AdvancedFeaturePkg" and "TemplateFeaturePkg"
> > folder as well?
> >
> > Can you please revise the patch to skip adding folders that contains 
> > package contents to the PACKAGES_PATH?
> >
> > Liming,
> > What's the criteria of a package? Can we treat a folder that contains ".dec"
> > and "dsc" files as a package directory?
> >
> > Thanks,
> > Ray