From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Thu, 16 May 2019 08:58:18 -0700
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 1B8FD3DBC2;
	Thu, 16 May 2019 15:58:18 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-88.rdu2.redhat.com [10.10.121.88])
	by smtp.corp.redhat.com (Postfix) with ESMTP id CE24D608A4;
	Thu, 16 May 2019 15:58:16 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v4 5/7] CryptoPkg/OpensslLib: Fix cross-build problem for AARCH64
To: devel@edk2.groups.io, xiaoyux.lu@intel.com,
 Jian J Wang <jian.j.wang@intel.com>
Cc: Ting Ye <ting.ye@intel.com>
References: <1557993298-22205-1-git-send-email-xiaoyux.lu@intel.com>
 <1557993298-22205-6-git-send-email-xiaoyux.lu@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <c98e6f97-289b-8b9b-a6a8-c9ec806d6e65@redhat.com>
Date: Thu, 16 May 2019 17:58:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1557993298-22205-6-git-send-email-xiaoyux.lu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 16 May 2019 15:58:18 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Jian,

On 05/16/19 09:54, Xiaoyu lu wrote:
> From: Laszlo Ersek <lersek@redhat.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1089
> 
> Thanks Laszlo Ersek <lersek@redhat.com>.
> Ref: https://edk2.groups.io/g/devel/message/40375
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ting Ye <ting.ye@intel.com>
> Signed-off-by: Xiaoyu Lu <xiaoyux.lu@intel.com>
> ---
>  CryptoPkg/Library/Include/sys/syscall.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>  create mode 100644 CryptoPkg/Library/Include/sys/syscall.h
> 
> diff --git a/CryptoPkg/Library/Include/sys/syscall.h b/CryptoPkg/Library/Include/sys/syscall.h
> new file mode 100644
> index 000000000000..ca80745e4650
> --- /dev/null
> +++ b/CryptoPkg/Library/Include/sys/syscall.h
> @@ -0,0 +1,11 @@
> +/** @file
> +  Include file to support building the third-party cryptographic library.
> +
> +Copyright (c) 2010 - 2017, Intel Corporation. All rights
> +reserved.<BR> Copyright (c) 2019, Red Hat, Inc.

Before you push this patch, please make sure that the Red Hat copyright
notice starts on a new line. I think the usual format is:

  Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
  Copyright (c) 2019, Red Hat, Inc.

with that:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo

> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <CrtLibSupport.h>
> +
>