From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.102.1606260614209488020 for ; Tue, 24 Nov 2020 15:30:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OgeT2wm1; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606260613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VLckramvHmpoZ48ST5vXNXA9zrWVDNXgyitPZFfCsGc=; b=OgeT2wm10qs9FtjBEL9UlGoRdoQPapFOKVqWZ6x0cCc0LTp3NyIGQlNs2mzhpEVlrgQHg7 LAHcHssyNlChsQIhrUxz1NWaCOcHJAd1Q+F7F6h6HLFMDc1o6GJkD/aT7qGu1n3Y4xyo+L qhlTJrkSinr5v1Juvnr5LnsJkpQm8Uo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-496-D6SwjGnhNRuvjK32N6Zyhw-1; Tue, 24 Nov 2020 18:30:11 -0500 X-MC-Unique: D6SwjGnhNRuvjK32N6Zyhw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76B39423BE; Tue, 24 Nov 2020 23:30:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-25.ams2.redhat.com [10.36.112.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id 17A975D6AB; Tue, 24 Nov 2020 23:30:06 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY To: devel@edk2.groups.io, samer.el-haj-mahmoud@arm.com Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel , Andy Lutomirski References: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com> <20201124191546.17403-4-Samer.El-Haj-Mahmoud@arm.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 25 Nov 2020 00:30:05 +0100 MIME-Version: 1.0 In-Reply-To: <20201124191546.17403-4-Samer.El-Haj-Mahmoud@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/24/20 20:15, Samer El-Haj-Mahmoud wrote: > ConSplitter was using EFI_LIGHTGRAY foreground color for ConOut > and EFI_MAGENTA for StdErr. > > This does not work all the time, and StdErr ends up showing parts in > MAGENTA and other parts in LIGHTGRAY. Changing StdErr to LIGHTGRAY looks > better and is more consistent. > > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Zhichao Gao > Cc: Ray Ni > Cc: Ard Biesheuvel > Signed-off-by: Samer El-Haj-Mahmoud > --- > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > index b090de288517..e8cd4ce120a0 100644 > --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > @@ -1476,7 +1476,7 @@ ConSplitterStdErrDriverBindingStart ( > // their MaxMode and QueryData should be the intersection of both. > // > Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL); > - ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_MAGENTA, EFI_BLACK)); > + ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_LIGHTGRAY, EFI_BLACK)); > > return Status; > } > I am very curious as to how this patch is going to fare, as Andy Lutomirski (CC'd) reported the same symptom in a Fedora bugzilla ticket 4+ years ago: https://bugzilla.redhat.com/show_bug.cgi?id=1355913 As you can see in that BZ, I found the same code location, I just didn't feel up to starting another crusade on edk2-devel -- about colors even!... So I'll be watching this one now. :) Thanks Laszlo