From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0625.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe40::625]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7F61521A13493 for ; Thu, 11 May 2017 11:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/97o6cVQFtiCKG91jURPKTaAYj67GHj0tzstO4EKDfY=; b=AS6oNh3THytYv/NtIQY3iYVRf0M5fecLVSU5DteykJaPohlPKOGyCbw7hZQIVdfwWYBY2EvEFvdJiE+jz8UMeiBQfdZ0YSKFNFJFP7kSZNXDTtrZJTJs7COTHiRXwD0acJJB36aZsa+wCqJIdKIzaikRAvflTTG2qbidbCItXcU= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from [10.236.136.62] (165.204.77.1) by DM2PR12MB0155.namprd12.prod.outlook.com (10.161.145.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11; Thu, 11 May 2017 18:05:08 +0000 To: Laszlo Ersek , References: <1494454162-9940-1-git-send-email-brijesh.singh@amd.com> <1494454162-9940-6-git-send-email-brijesh.singh@amd.com> CC: , , , Jordan Justen From: Brijesh Singh Message-ID: Date: Thu, 11 May 2017 13:04:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR13CA0039.namprd13.prod.outlook.com (10.168.240.153) To DM2PR12MB0155.namprd12.prod.outlook.com (10.161.145.18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28eb9823-729b-4d95-1748-08d4989842e4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:DM2PR12MB0155; X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0155; 3:xGu5rFdcwndl8kOR8sGLiGA1rmUn65T+g/snhckYA63PbnD7GRwLGxxRAtkpBq2Y2qtVQK0ThKJ80ijv5Qdv8LoLHno6xRuw4uOMUCKSK/X7Foe5HVT6wfBYhLALRvSYcgj1TZT2QreXpq0XuY/r+FO+f31wVkaJWvHZr/RuJxKIIxRSYBAJjl3SjGaoVqaKcdNHr5eIcvclgamMq1pWZ/w76pVWuiwvPwhoWP+mbRzAh1YH3v5G28ABqQrsCBkcjNW+ppN1FYg0JNn9q+4w1Z+S8RGbsXm4HaKAsb9KPyQGIB1eyqUjAjXf8G0D5sfHlnU5ATbzzyGQaaLRtSYFDZihIbqTbQO64/JMDk8BNX8=; 25:v8bP/DmE1d/ItzJOQCtQac9XRflILBdXkEu8jlUWtG2smPL+zaACZAA1JinrcVRxA/kzdugMcVvVlHrWFkiBNSRUxP2Qt/lz+jKoo6E7XspAIYGFl4o4IULFmQolK3n3HPQ0gFcpvmsN+8JQ6o8iMZ4ojL6kfWiXbknvoBJXocdkIy6XWYfyAHndLJr5t+qhsTyFY8UDU2x7LSY3l9xLyheLeUX+IiMpqwHVcHo9nanDRwLdnGlFOmjPAZFQ+sI/Ej1UB800gAjPEZ5yVtz9zd0Xef4Y1SyK/KAcd11TfKEDMR0RU/pOA6ma4eGLHxnCl9UtTh3wLrEXfJ8h/CdDSrIn3XvncaGpep+5E3msLxMJ7TpyaHPgDDDtMdV/M2UjHoyvUyeoEV1BZ3UtOTDO0dqq7qOBU0w8LoGq29QOqzDGUoUPqC58dAlkk2y5y+oPsQxiFJa7T+wpzzsH5P/V3KIeMXnBvxjs24El77vohA4= X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0155; 31:+uC6S7Nd4DLiJS9KivQ+mJp/Ur4y98CPCvENNRkactH4ysLiBJkBlZnwQCxUmHclXc8B/OM3YDPtDA78wh6b5d79HbN9F6baoN0/I2QFZ5b9GV02Sv7G+3DRy+nPQW175tcDvo5cV0E9zg1w5oCPmhgDMi4gcdCiOT6uO1XdrtbrRSMavoBBP65bWijD6pjGhi4y86j/dr+/jVhAhYvkI25zVuXPI+HQAfbPjAftWgQ=; 20:VZcXBRieilPtKl8La99zHAwMlJuwHX7hTd4Tg6P7deCwZ3qVx/WOkDzIyLnn4Rbg1NgRtMI1W/1p9qsybmYb4mUkzImp8Jk+2f8Rywci7rS/Y5TQcJnyhhjEUmcbaWTgCzlrImprg2ItHxKOlj+ktB5IZW5WrfvZSbmF601QU2ZeWmKV/RDSowSaj3lmSLQ5GJKgKFWXPtNkzbwUL3jhd/eftBhdTFtet3WS4pbH9/MPHCsKBEmt08ErAVF2VOr4EvkG6vHWGtZ1uqPi4HbjeoFU8GPlBv67Av7lGh7e3VEzbSrbid7EYpYEAJbJanis+EJvdAiyQud5e0EnvB5f1V3g9pE0IxQcXVboduynoh9r30NO9CIW+qWcTJBIG9o+jcbby6KYBvTbodby+mVd7j+8imH1ig2987nYSjy/DcInZ293feB7uSlC/d/vSsYUb15HIYmfxPevXZMLcyYltOJHVwIGlBSIvN2OqTECUs/NpILXT8jT+V1MX/esU3tZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148); SRVR:DM2PR12MB0155; BCL:0; PCL:0; RULEID:; SRVR:DM2PR12MB0155; X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0155; 4:OoMl/gYp2ulkHspZaOaJKN0SowLmpGF7zecjxnyi9hRkKSyaq3/i4aAHfGMHLJ2HqIUNwSoyUv9bKG3fxiVsp1MgJ+V93B0gQH03qEX3nXUZAIgkVN8zU5B5UajcvOElRb1GFUgqL69NuAYf1d0aIO9aKq00bzfWe3/L5SG++3R0Q3Bg3d+86ki27qaRD0WU64mzesJ8/TKpPB8TqUvEzhHj8qfm1tX5DiDkX+fHW7rahzPxggdyx5isP0J98ZJP5mcMKYaDCYwBEDEr4UDB4YG1nBHKm0voFVJNLx83B6LSPFuP3H5B7WZNyKzVitCmHu8Pf8SZTL1UO2FsORNnqA7w/pnd8gJkY6i2gUjqtC0x00ACPmf6jahsX5PsHtwo/smum0TMgTaJ7WkCj6oJWONOGCdOUN8idPkCdB5Zeaw6H3o1DqDs0PuQyWVZbg89WyKFUl9rnIhzF7JhtsDLAAJJmAc5SizryZvoLPrXFRgijDbCq9Ys6WoWbIWnvfwqsu1YN91ahcFK/4ez3Ncxx40v8THVJBj6Jb1ZHmYWdvhSufVcMj/k4lTKRfd7VnTIrf6JCSm4o12dJg0dFUpNaJgn2o1hM4ikx6Cs64DP6r1mZavZpZpF4jt9Ztxu3AK58QVz50+f4GqDwuf1yz7usfHKyp3+LCLIt1Q6zxVhYX+cXL0PXGWMbZlbJ3yHtAag5ThyiKxt1dddLtGp9UEzK4FoswZCPsv0tDyjru73jkuJ1x2C1ZbxjqZZpFuzZ377CmqWson9xaMbqq8rS3TyyaH0OfrASxqIvX/dt+LP73hrdJGtyz/2OOnxT7zFxE79UoLSfowZuGXclzeeLnn9SA== X-Forefront-PRVS: 0304E36CA3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(39450400003)(39840400002)(39400400002)(39410400002)(39860400002)(39850400002)(24454002)(377454003)(51914003)(229853002)(4001350100001)(81166006)(4326008)(2950100002)(5660300001)(50466002)(6666003)(31686004)(42186005)(230700001)(189998001)(33646002)(64126003)(6116002)(3846002)(53936002)(6306002)(54906002)(36756003)(53546009)(65826007)(6246003)(38730400002)(90366009)(6486002)(77096006)(23746002)(8676002)(66066001)(65806001)(65956001)(25786009)(2906002)(7736002)(305945005)(31696002)(47776003)(86362001)(50986999)(76176999)(54356999)(83506001)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR12MB0155; H:[10.236.136.62]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM2PR12MB0155; 23:u/lQDJdpz9naDdV8RZi+Uq+6zIOc2qA9qufG2?= =?Windows-1252?Q?9xT1cktJGt5v+irXHJwBfQspMJlf43xmLaDWPWq2h1hvuB6kZSGQ2sL9?= =?Windows-1252?Q?BpkOhV3bOXbSRK56+piN+ZuNOpC+iAoVozTsaHhMOr93r91IDUjHU/W/?= =?Windows-1252?Q?ynBA6VuhncmZVYXn5s5TckrqeaIfl2vcn9JlGiWTdBWydDCDjIwlOiGM?= =?Windows-1252?Q?EGpbbCEuOPEeFQcGe8NOP8H0qLR5iPTGZhkd/wN/VTVSMEarY+7y3ynj?= =?Windows-1252?Q?WldHbowFAqzJ7cfooon2cucKRgLg4f7Lp4duW9FXk8ZsyPQS0Vm5SOlT?= =?Windows-1252?Q?0MtE2fiXjWeEMLAIUF14axEgpDHjRgBDG/UDmNhnyw2I0FYO79LOiWqv?= =?Windows-1252?Q?L6KzUvYoMOmWg28cZJk64FNsYJ3YK8AWPM77WxRIXelVaSLtOrowen8c?= =?Windows-1252?Q?d8iXdYmj84xQhcluVTJHx6yiPwNBMP0dq09we7MCJn2zXyp1eIZc1H+k?= =?Windows-1252?Q?nboo4kMqWr+xBxb7bWHI0oToFBOFfBnMjTzNlj714vtQqWW3/JKa9jj1?= =?Windows-1252?Q?e+fIwqTsV+SpAaKzSt69axIw7h2+xg7WeH4b0MU4ii9Xg8nRsHLE8i7d?= =?Windows-1252?Q?lERmIVDjUV9/g9FWtE7+Hc7JHDotZUOUYxSMtcda1FGPB+7pdONBSx2x?= =?Windows-1252?Q?OBn8md9qCQjcyEruqLq9/3jUN3+XSwYfk4K0oQtYrZomSkokMuQfh52/?= =?Windows-1252?Q?ALzV6O/eFmQSE2dWOfJ2u51ibVqDHhtuze8ud3txO/KzR7EQkM8ixosh?= =?Windows-1252?Q?RcmqT8Z6tLAyI9qiHGjN1ZuV2B+7Dj/AkmKT5viJ7+UkPTCFp/2i+gIW?= =?Windows-1252?Q?apO/a+iMrOJBpYe/caDbdcHXhWM0+w0C8ht1oTa2QynDcu+ViJeL7NFM?= =?Windows-1252?Q?C7P7kdqz8GJhbR+N07aDiRCjVLlI08Gqqt/r2vAEUZsSZyq3aJnAWaBz?= =?Windows-1252?Q?dNUwKfpphcdqLK/BLbaCeQsEZlaTIX8SCZEWrlLKypIcTA4KoI95LcuH?= =?Windows-1252?Q?hHr7hm4rgbNGmZzmTAc5d8wWqlNgh6TaUQZQCMErpWeUoR/4jSZDLRg5?= =?Windows-1252?Q?KKHSzZEeKEsVP/rELuge+nhWkcGgZPEKjpFgd2kPJLS1oNt6s+ch8Oym?= =?Windows-1252?Q?Rf/zCP6k33m4vALi1MWNimDd/SOqXnjwQeC417yBjRnwVhNpQC1wA0Od?= =?Windows-1252?Q?XLWPIEIB3QuS1jBSe9RYrPNdRQ0TgfSGZGMl5o/SaMk9qyXSK+i4Uo6+?= =?Windows-1252?Q?DTATPAIukgF+Utv3QVrTaxVXaPv/W42AlsVb2PCASYq3Lr4pzQU+oLWV?= =?Windows-1252?Q?29Z6VxadFNs8Gm16EKawjvMlHqFcnl/QL/UrBelCh7z0DQMAMpaT9xO7?= =?Windows-1252?Q?oAJenzWA+zaYbl9hJPKULRicYQ+/nKC8z7bBgaA8TKlfaI2Gn30x81rN?= =?Windows-1252?Q?A6eWHQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0155; 6:PegmbBcOoSr/ayk7lod3TpgMoCALWSBCVzeUMINSX3tjipKDK2TxgYYWFyslCT3hyGw/LMUwYAsRnyW0KDK5eqa79DbB5ykpXZhXNwlmJGGv0Uu32QzJlWUJavu5+PLLSICyC7evbW0rlRlNjUWpADvc4c4oVhLrw2XXHnY01IC3wFUtOZd5CND4yA0ZvyPJ8FvR+wc429dXVEqrew2hqqSUNG4A2h12ZmXEXVDXeIE4m43TfDPG3jv5ZF2cuUTIe1OqG8rAV2kcI5m1TVR6/Z3xcHk6dJBrBuuZguKo3+mFMMaC+T/w+kOw7zzfmX37J47bwoziBze7xMdOC9CAYFZgGu1AgRaPBYmv+uxe0y1DweXRwMEzy91jQS5hOYlkurC3LiXT9cXITB5NE9UttOyKii7YwZKoTegMFkvrXgUnVMjkvZ/bWylj0RXWQdlwwLGQ8vww6tNvNZM6098UAQJnmmqdmgY/v7jM20m4PCTcAS17w84R2N4C43KmeRU0lOFdHu7PKRTrWoO/rzYN73222ydm8UBJ3j5IyDzSg+o=; 5:m8kp2++7oMI1t+h23Bi+FOy6qjjznl29dHYG4aU0t65NyeLBp1/nICmI3fx+Vzaky6KyXtaN2BxJ/yyjpYfs1urEymL6biP7KSWDyzgVfPm0bofxZMELflUSbVwtf9PGN8vTtKxMp4n9sfF8qWviEA==; 24:1uhQnYc/DzhF353G/UO8FoEAAF7mEjacMsBVb2SEg469swdTuimGLa8ThmTZdMoytzhsXVm5xlMLuPTNYUmVIlVYKT6uLmHADDhbc37wkPA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR12MB0155; 7:zP8UNwyxjDDjSrl0ze/dc3UkxPPvQGsuLNCQKUHbO+YzZWFjz5jAcoBCIZJfVAs05MQZLHlK+/BhOXTHK9ivuuKjnZdLPSBN901r7YoERMf9CHv76SZXAqjZPWuieoJ5Umf447ly+xd8JVRUTGk94/tfFfNpjnwJwaMTjVaJ5/S/1JuExO/BBxG43nI5r8VerolLCkh7m2LpyZuFeFtUVN8lobK2xpS/BLbgn6G1rNzXvRtGEZhjLcUTixKukz6Cz+uBWOoe1d+g0v3b9pnL9/zp8O45TBBm5bV3VrMyiu3XsKewGChaIrlmSHNryhDwuBwzwHbQLy3v9JZXLXMfVQ==; 20:mDEu3VqiQsns0F6ljgffwLG1nqPW/GVYZ2oF/Az2xoxaJuTr6U0oZ1/BGw4BryyydXkac6hGNqfWJEmH59ni+q6r7PoQOpMUtYDlsJeKz4/QJoXMHkb5x0jLmw2UfGCZlU7FTamlvogJexMc9F2w9l1mls0M2yn1n6j030O3FAZT6FWM1Vm3CfW0Xf99ZOeLoY1zwQwMsW9L5D6kzc78DjOih5ILAEgr8ZObOD1OwLP4+i5ALp7k2B3iXPM7hrxl X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2017 18:05:08.7635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0155 Subject: Re: [RFC v4 05/13] OvmfPkg/PlatformPei: Set memory encryption PCD when SEV is enabled X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 18:05:10 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit On 05/11/2017 09:37 AM, Laszlo Ersek wrote: > > Please replace the last paragraph in the commit message with the > following (mostly based on > ): > > ---- > The patch sets the memory encryption PCD. The PCD is consumed by the > following edk2 modules, which manipulate page tables: > > - PEI phase modules: CapsulePei, DxeIplPeim, S3Resume2Pei. > > CapsulePei is not used by OVMF. DxeIplPeim consumes the PCD at the > end of the PEI phase, when it builds the initial page tables for the > DXE core / DXE phase. S3Resume2Pei does not consume the PCD in its > entry point function, only when DxeIplPeim branches to the S3 resume > path at the end of the PEI phase, and calls S3Resume2Pei's > EFI_PEI_S3_RESUME2_PPI.S3RestoreConfig2() member function. > > Therefore it is safe to set the PCD for these modules in PlatformPei. > > - DXE phase modules: BootScriptExecutorDxe, CpuDxe, PiSmmCpuDxeSmm. > > They are all dispatched after the PEI phase, so setting the PCD for > them in PlatformPei is safe. (BootScriptExecutorDxe is launched "for > real" in the PEI phase during S3 resume, but it caches the PCD into a > static variable when its entry point is originally invoked in DXE.) > ---- > I will update the patch description, thanks for the write up. -Brijesh