From: "Rebecca Cran" <rebecca@bsdio.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Cc: 'Liming Gao' <liming.gao@intel.com>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add DDR5 SPD defs to IndustryStandard per JESD400-5A.01
Date: Tue, 14 Feb 2023 08:37:26 -0700 [thread overview]
Message-ID: <c9b9c9ea-6e75-5864-84be-b51efc8455a1@bsdio.com> (raw)
In-Reply-To: <CO1PR11MB4929E34C37FBB01A877925ADD2DE9@CO1PR11MB4929.namprd11.prod.outlook.com>
On 2/10/23 11:01, Kinney, Michael D wrote:
> We usually do not include basetype includes from .h files in Protocol/PPI/GUID/IndustryStandard.
>
> This is because we always get base types from AutoGen.h and from C/H files in modules/libs
> That have to include top level include files for their module type. Base.h, PiPei.h, PiDxe,h, Uefi.h.
>
> Also UINT8 is available from Base.h that does not assume UEFI or PI env.
Thanks. I've sent out a v2 patch with the include line removed.
--
Rebecca Cran
next prev parent reply other threads:[~2023-02-14 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 17:47 [PATCH 1/1] MdePkg: Add DDR5 SPD defs to IndustryStandard per JESD400-5A.01 Rebecca Cran
2023-02-10 5:23 ` 回复: [edk2-devel] " gaoliming
2023-02-10 11:04 ` Rebecca Cran
2023-02-10 18:01 ` Michael D Kinney
2023-02-14 15:37 ` Rebecca Cran [this message]
2023-03-10 3:08 ` 回复: " gaoliming
2023-03-10 17:56 ` Rebecca Cran
[not found] <1741EA9C96A244C9.31982@groups.io>
2023-02-08 18:04 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9b9c9ea-6e75-5864-84be-b51efc8455a1@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox