From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web11.10209.1676389050214829801 for ; Tue, 14 Feb 2023 07:37:30 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=lJkLLBvK; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6561C5C00CC; Tue, 14 Feb 2023 10:37:29 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 14 Feb 2023 10:37:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1676389049; x= 1676475449; bh=1EOfiEkQmLo1Wo7QaXKU+IZUvvfxzRpBwveKpCHHesQ=; b=l JkLLBvK93KGzDrMypofki8vQuYrgdPqm+bHW+PF/bDyrcAcOtEzROZX4qx9wQHZJ i/8rB4B/CgzGiZ0fP53X6P9aMGG/Im7AGFXUDWR4ScmZLJ3XmchJ88ArapQuNh7B CX/K8lYo1hB9HV+65Jrl0DGk39wsE/cjvOv2Z/AMSmjFbBRq1mvWUdmij+k4oQbk qJKGGX61mJjhs5ploC4btEqe7kwiUTm+pc5uETujK1NWDa3OVGcNcIdadMV+FaC3 otwPB1MXi5CxANLCBxz3shOd2cDbGssdzGS/DVyGs+Ih5iIStNgZ+dtVeIgdijaD S7aQjajmpKrtF1I1WFadw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676389049; x= 1676475449; bh=1EOfiEkQmLo1Wo7QaXKU+IZUvvfxzRpBwveKpCHHesQ=; b=s hW/ATUMNma8bsnzZrRhfg/LUbguOm4LnhCOTFdm9+MinCOGWjlSwd/tJ7HV39PXt urCpQ+qlXxhmL2Ifr7wP4H4/m5KwGSUwA7xkQQIzwzmm1AAE9Qw5K1SYbtR11XZ8 r7n+TaI+TK4NGOL01GpQ6h88eokRJijs/ttHL7QN0Nim9Ndfig2gctSpVxf1IDJx 7GNvdQjZgRshEKqolz8LTeJ4s/A6/O5vXYNLCP16thKOwl21ZqvwvV+V1rozhElK X7GeQ4z1Fr50iXfmcg9cR9S4Wi0X9zgrWGQKQcYhL8NvsBRSxqCa4/BtRKdtVopV vQfqaqxUKedn09QiDMbdg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeifedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Feb 2023 10:37:28 -0500 (EST) Message-ID: Date: Tue, 14 Feb 2023 08:37:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add DDR5 SPD defs to IndustryStandard per JESD400-5A.01 To: "Kinney, Michael D" , "devel@edk2.groups.io" , "Gao, Liming" Cc: 'Liming Gao' , "Liu, Zhiguang" References: <20230208174759.427273-1-rebecca@quicinc.com> <022301d93d0f$c87e6270$597b2750$@byosoft.com.cn> <9ed61f08-c9fc-43b5-9ff7-3f9444c6151a@app.fastmail.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/10/23 11:01, Kinney, Michael D wrote: > We usually do not include basetype includes from .h files in Protocol/PPI/GUID/IndustryStandard. > > This is because we always get base types from AutoGen.h and from C/H files in modules/libs > That have to include top level include files for their module type. Base.h, PiPei.h, PiDxe,h, Uefi.h. > > Also UINT8 is available from Base.h that does not assume UEFI or PI env. Thanks. I've sent out a v2 patch with the include line removed. -- Rebecca Cran