From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 61C38941B30 for ; Sun, 29 Oct 2023 16:01:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mKFvjRpxehd4PXs6QYhpnlu7VpvUnLbMondJh8yBBJM=; c=relaxed/simple; d=groups.io; h=Message-ID:Subject:From:Reply-To:To:Cc:Date:In-Reply-To:References:User-Agent:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698595313; v=1; b=suMC4P8ND9ABvgpbqz2cnqS5MtCztsp7xHDPndVx253m5I7gzH90AAoFfoRi+CmSqDw739je Rtvff+tNYW48AWRSqrQELY9Q/BhSvTI/pa+dgQXeyb8AP+LH1UX7w/q4xFghjO6glTRXVCKCG3L oZnj0pnezlJfoBlAfqwHl6zI= X-Received: by 127.0.0.2 with SMTP id 3vw1YY7687511xikLgyMtRtO; Sun, 29 Oct 2023 09:01:53 -0700 X-Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web11.75024.1698595311950692389 for ; Sun, 29 Oct 2023 09:01:52 -0700 X-Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39TBItvq015417; Sun, 29 Oct 2023 16:01:45 GMT X-Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u18yxggde-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Oct 2023 16:01:44 +0000 X-Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 39TFxo9n019717; Sun, 29 Oct 2023 16:01:44 GMT X-Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u18yxggcq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Oct 2023 16:01:43 +0000 X-Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 39TEBZJN031391; Sun, 29 Oct 2023 16:01:42 GMT X-Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3u1fb1k223-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Oct 2023 16:01:42 +0000 X-Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 39TG1fPK51446274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 29 Oct 2023 16:01:41 GMT X-Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A75B458063; Sun, 29 Oct 2023 16:01:41 +0000 (GMT) X-Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4A5F95805D; Sun, 29 Oct 2023 16:01:36 +0000 (GMT) X-Received: from lingrow.int.hansenpartnership.com (unknown [9.67.114.252]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Sun, 29 Oct 2023 16:01:36 +0000 (GMT) Message-ID: Subject: Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members From: "James Bottomley" Reply-To: devel@edk2.groups.io,jejb@linux.ibm.com To: "Yao, Jiewen" , Laszlo Ersek , "devel@edk2.groups.io" , "pedro.falcato@gmail.com" , "Kinney, Michael D" Cc: Andrew Fish , Leif Lindholm , "Warkentin, Andrei" , "West, Catharine" , "Bi, Dandan" , Daniel Schaefer , David Woodhouse , "De, Debkumar" , "Dong, Eric" , "Jiang, Guomin" , "Wu, Hao A" , "Wang, Jian J" , "Justen, Jordan L" , Julien Grall , Peter Grehan , "Zhang, Qi1" , "Ng, Ray Han Lim" , Stefan Berger , "Hou, Wenxing" , "Lu, Xiaoyu1" Date: Sun, 29 Oct 2023 12:01:34 -0400 In-Reply-To: References: <20231028192330.1031-1-michael.d.kinney@intel.com> <99615ab9-f669-5ac8-fafd-f154e8af5da8@redhat.com> User-Agent: Evolution 3.42.4 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: zh9_hx1aPk7XVX6oZ8KwMnyG1YdoApNH X-Proofpoint-GUID: 3trocS8BV-XddLK_tQWL_AN47CMHq_gV X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: y7Z5vFPRFzK3taVBOcDVxDiWx7686176AA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=suMC4P8N; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=ibm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Sun, 2023-10-29 at 15:42 +0000, Yao, Jiewen wrote: > > I'd say that's pretty close. A reviewer role is a request for > > keeping > > the reviewer in the loop. >=20 > [Jiewen] I am disappointed on that. > To me, that is NOT a real reviewer. See below description on what is > "code review". > https://google.github.io/eng-practices/review/ > https://about.gitlab.com/topics/version-control/what-is-code-review/ Well, that's what someone's view of what a patch review should consist of, not what a reviewer's role in MAINTAINERS should be. In general, you really don't want to force people to review patches, because you'd like a reviewer to be familiar with the area and comfortable with the patch. So are you saying that anyone listed as a reviewer in a particular area should be capable of reviewing any patch? and further that they should be expected to review every patch?=20 Because that's definitely not what the R role in the Linux Kernel would mean. I know that's not what happened to me in Confidential Computing, because I had a very specific area around SEV and SEV-ES secret injection and really had no familiarity at all with say the memory acceptance patches. > Our definition seems more like *a notification receiver*, instead of > a real code reviewer. I would say, it is a very misleading > definition. Actually, I wouldn't, but then I'm more coming from a Linux Kernel background. To us, the reviewer list is simply a list of people git blame might not find who might have the expertise to review the patch but on whom there would be no expectation that they would review the patch. James -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110270): https://edk2.groups.io/g/devel/message/110270 Mute This Topic: https://groups.io/mt/102245264/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-