Re: [edk2-devel] [PATCH edk2-platforms v7 1/4] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

["Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>]

W dniu 19.03.2024 o 17:53, Ard Biesheuvel pisze:
>> new file mode 100644
>> index 000000000000..e621c422bd40
>> --- /dev/null
>> +++ b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuHardwareInfoLib/SbsaQemuHardwareInfoLib.inf
>> @@ -0,0 +1,31 @@
>> +#/* @file
>> +#
>> +#  Copyright (c) 2024, Linaro Ltd. All rights reserved.
>> +#
>> +#  SPDX-License-Identifier: BSD-2-Clause-Patent
>> +#
>> +#*/
>> +
>> +[Defines]
>> +  INF_VERSION                    = 0x0001001c
>> +  BASE_NAME                      = SbsaQemuHardwareInfoLib
>> +  FILE_GUID                      = 6454006f-6502-46e2-9be4-4bba8d4b29fb
>> +  MODULE_TYPE                    = BASE
>> +  VERSION_STRING                 = 1.0
>> +  LIBRARY_CLASS                  = ArmPlatformLib
>> +

> Please define a suitable library class and add it to the
> Silicon/Qemu/SbsaQemu/SbsaQemu.dec, as I mentioned in the previous
> round of review.

I have to admit that after looking at edk2 wiki [1] I start to wonder is 
there any useful documentation for doing things in EDK2.

1. https://github.com/tianocore/tianocore.github.io/wiki

There are fat specs describing fields in DSC/DEC/DFD/FDF/ETC/INF/WTH 
files, info how to clone and setup code from repo, how to build it.

https://github.com/tianocore/tianocore.github.io/wiki/EDK2-Libraries is 
terrible. Written by someone who knows EDK2 but do not know how to write 
any useful documentation.

There should be examples with complete code. Even if it is 
PrintHelloWorld library class.

After doing some experiments I have a feeling that LIBRARY_CLASS field 
in INF file is only checked for presence. If I use 
HaveNoIdeaWhatToWriteHere as value then code builds and works the same 
as it was with ArmPlatformLib.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116935): https://edk2.groups.io/g/devel/message/116935
Mute This Topic: https://groups.io/mt/105024010/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-