From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8DC2C78003C for ; Wed, 20 Mar 2024 11:10:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5fk7lo4nMR28ndqNUEkPaI5IKKqCojAM6ABmsaVwT/U=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710933040; v=1; b=X+bUxGHc7kLgoCTZUslFsv6ibsmV67+TkDS+r9m/d9fKjq5Fvir3hXMxZdlb6bOg5Dt9u+EK mvxRK3UKxAVM34PHf1VQzZDz4QWsbYcdQTWe83QYvsLw3IH8lUT0J7j/Yz0Hd+ZTCHvR/W3we6Q VT6VsveacTzkH5hdmfH2nx4xv26iRM7e8/HYtXNpQpYgPsJHL44cZ7VJo76AUUZ59vwpmziFvVN QcLUZ1YM7yy3Ltx2K+p38CFDKVaEHmSJwsVjAQ560QF12vsMJzNVuLq8+Y61peV6zY7Uhmfe2ax ZFu5h7/nDnCXx52/xw9/HslGEarUxxLkpw+2ksTaqLkXA== X-Received: by 127.0.0.2 with SMTP id AJpeYY7687511x1YAM7pNV5O; Wed, 20 Mar 2024 04:10:40 -0700 X-Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by mx.groups.io with SMTP id smtpd.web10.40882.1710933039296918201 for ; Wed, 20 Mar 2024 04:10:39 -0700 X-Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a46db55e64fso227340566b.1 for ; Wed, 20 Mar 2024 04:10:39 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUlTIVTD7TJoRKrCj/JnUhgohvfg3/myyz6VbjoDILHWZF5iDc2nYEMHfwxHJ4aGImmM7xztsf68pvm8c2CB6/pwBkrpg== X-Gm-Message-State: PjphYDmws9E56liQStBUh3gKx7686176AA= X-Google-Smtp-Source: AGHT+IGNnI1c+4voMZg1k+UNdhd5k8tWy47V0Fb3HqojxjiLnMxz29Sk2nwLVNgkh36bz1VOL+E/+g== X-Received: by 2002:a17:907:728b:b0:a46:94c7:49a5 with SMTP id dt11-20020a170907728b00b00a4694c749a5mr11178201ejc.40.1710933037474; Wed, 20 Mar 2024 04:10:37 -0700 (PDT) X-Received: from [192.168.200.106] (83.11.22.169.ipv4.supernova.orange.pl. [83.11.22.169]) by smtp.gmail.com with ESMTPSA id ho16-20020a1709070e9000b00a4672fb2a03sm7109954ejc.10.2024.03.20.04.10.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Mar 2024 04:10:37 -0700 (PDT) Message-ID: Date: Wed, 20 Mar 2024 12:10:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms v7 1/4] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib To: Ard Biesheuvel , devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Graeme Gregory , Xiong Yining , Chen Baozi References: <20240319-no-dt-for-cpu-v7-0-ac0a57a23a8f@linaro.org> <20240319-no-dt-for-cpu-v7-1-ac0a57a23a8f@linaro.org> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 20 Mar 2024 04:10:39 -0700 Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=X+bUxGHc; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io W dniu 19.03.2024 o 17:53, Ard Biesheuvel pisze: >> new file mode 100644 >> index 000000000000..e621c422bd40 >> --- /dev/null >> +++ b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuHardwareInfoLib/SbsaQemuHardwareInfoLib.inf >> @@ -0,0 +1,31 @@ >> +#/* @file >> +# >> +# Copyright (c) 2024, Linaro Ltd. All rights reserved. >> +# >> +# SPDX-License-Identifier: BSD-2-Clause-Patent >> +# >> +#*/ >> + >> +[Defines] >> + INF_VERSION = 0x0001001c >> + BASE_NAME = SbsaQemuHardwareInfoLib >> + FILE_GUID = 6454006f-6502-46e2-9be4-4bba8d4b29fb >> + MODULE_TYPE = BASE >> + VERSION_STRING = 1.0 >> + LIBRARY_CLASS = ArmPlatformLib >> + > Please define a suitable library class and add it to the > Silicon/Qemu/SbsaQemu/SbsaQemu.dec, as I mentioned in the previous > round of review. I have to admit that after looking at edk2 wiki [1] I start to wonder is there any useful documentation for doing things in EDK2. 1. https://github.com/tianocore/tianocore.github.io/wiki There are fat specs describing fields in DSC/DEC/DFD/FDF/ETC/INF/WTH files, info how to clone and setup code from repo, how to build it. https://github.com/tianocore/tianocore.github.io/wiki/EDK2-Libraries is terrible. Written by someone who knows EDK2 but do not know how to write any useful documentation. There should be examples with complete code. Even if it is PrintHelloWorld library class. After doing some experiments I have a feeling that LIBRARY_CLASS field in INF file is only checked for presence. If I use HaveNoIdeaWhatToWriteHere as value then code builds and works the same as it was with ArmPlatformLib. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116935): https://edk2.groups.io/g/devel/message/116935 Mute This Topic: https://groups.io/mt/105024010/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-