From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 20 Jun 2019 09:26:12 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9AA262F8BC5; Thu, 20 Jun 2019 16:26:01 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-226.ams2.redhat.com [10.36.117.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id BB9DC601A5; Thu, 20 Jun 2019 16:26:00 +0000 (UTC) Subject: Re: [edk2-devel] [Patch 0/2] Enable new MM MP protocol. To: devel@edk2.groups.io, eric.dong@intel.com Cc: Ray Ni References: <20190619055114.12744-1-eric.dong@intel.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 20 Jun 2019 18:25:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190619055114.12744-1-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 20 Jun 2019 16:26:06 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/19/19 07:51, Dong, Eric wrote: > PI spec added a new protocol named MM MP protocol. This protocol allows > for better remote queuing of execution of procedures on an AP. > This extends the existing procedures to allow: > 1. A function to be called in blocking and non-blocking manner explicitly > 2. Allow broadcasts. > 3. Allow execution of a procedure when a processor powers up. > > This patch serial enable this new protocol. > > Cc: Ray Ni > Cc: Laszlo Ersek > > Eric Dong (2): > MdePkg: Add new MM MP Protocol definition. > UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol. > > MdePkg/Include/Pi/PiMultiPhase.h | 16 + > MdePkg/Include/Protocol/MmMp.h | 334 +++++++++++++ > MdePkg/Include/Protocol/SmmMp.h | 44 ++ > MdePkg/MdePkg.dec | 6 + > UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.c | 375 +++++++++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.h | 283 +++++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 468 ++++++++++++++++++- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 11 + > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 172 ++++++- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 3 + > 10 files changed, 1696 insertions(+), 16 deletions(-) > create mode 100644 MdePkg/Include/Protocol/MmMp.h > create mode 100644 MdePkg/Include/Protocol/SmmMp.h > create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.c > create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.h > I applied this set (for regression testing) on top of commit f17935321a5b ("MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM.", 2019-06-20). First of all, git-am complained like this: > Applying: MdePkg: Add new MM MP Protocol definition. > .git/rebase-apply/patch:374: new blank line at EOF. > + > .git/rebase-apply/patch:424: new blank line at EOF. > + > warning: 2 lines add whitespace errors. > Applying: UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol. > .git/rebase-apply/patch:392: new blank line at EOF. > + > .git/rebase-apply/patch:1276: new blank line at EOF. > + > warning: 2 lines add whitespace errors. Please consider removing those empty lines. Second, the series does not build for me. I'll describe the issue under the affected patch. Thanks, Laszlo