* [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()
@ 2016-10-18 11:07 Laszlo Ersek
2016-10-18 12:43 ` Tim Lewis
0 siblings, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2016-10-18 11:07 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Jaben Carsey, Ruiyu Ni, Tim Lewis
The destination GUID comes first; from
"MdePkg/Include/Library/BaseMemoryLib.h":
> GUID *
> EFIAPI
> CopyGuid (
> OUT GUID *DestinationGuid,
> IN CONST GUID *SourceGuid
> );
Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and
"Guid" is where EfiShellGetGuidFromName() has to propagate that result to.
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Tim Lewis <tim.lewis@insyde.com>
Reported-by: Tim Lewis <tim.lewis@insyde.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
ShellPkg/Application/Shell/ShellProtocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c
index 2bc0646b453d..04b66c5acaae 100644
--- a/ShellPkg/Application/Shell/ShellProtocol.c
+++ b/ShellPkg/Application/Shell/ShellProtocol.c
@@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName(
Status = GetGuidFromStringName(GuidName, NULL, &NewGuid);
if (!EFI_ERROR(Status)) {
- CopyGuid(NewGuid, Guid);
+ CopyGuid(Guid, NewGuid);
}
return (Status);
--
2.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()
2016-10-18 11:07 [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName() Laszlo Ersek
@ 2016-10-18 12:43 ` Tim Lewis
2016-10-18 14:54 ` Carsey, Jaben
0 siblings, 1 reply; 4+ messages in thread
From: Tim Lewis @ 2016-10-18 12:43 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-01; +Cc: Jaben Carsey, Ruiyu Ni
Reviewed-by: Tim Lewis <tim.lewis@insyde.com>
-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com]
Sent: Tuesday, October 18, 2016 4:07 AM
To: edk2-devel-01 <edk2-devel@ml01.01.org>
Cc: Jaben Carsey <jaben.carsey@intel.com>; Ruiyu Ni <ruiyu.ni@intel.com>; Tim Lewis <tim.lewis@insyde.com>
Subject: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()
The destination GUID comes first; from
"MdePkg/Include/Library/BaseMemoryLib.h":
> GUID *
> EFIAPI
> CopyGuid (
> OUT GUID *DestinationGuid,
> IN CONST GUID *SourceGuid
> );
Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and "Guid" is where EfiShellGetGuidFromName() has to propagate that result to.
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Tim Lewis <tim.lewis@insyde.com>
Reported-by: Tim Lewis <tim.lewis@insyde.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
ShellPkg/Application/Shell/ShellProtocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c
index 2bc0646b453d..04b66c5acaae 100644
--- a/ShellPkg/Application/Shell/ShellProtocol.c
+++ b/ShellPkg/Application/Shell/ShellProtocol.c
@@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName(
Status = GetGuidFromStringName(GuidName, NULL, &NewGuid);
if (!EFI_ERROR(Status)) {
- CopyGuid(NewGuid, Guid);
+ CopyGuid(Guid, NewGuid);
}
return (Status);
--
2.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()
2016-10-18 12:43 ` Tim Lewis
@ 2016-10-18 14:54 ` Carsey, Jaben
2016-10-18 17:36 ` Laszlo Ersek
0 siblings, 1 reply; 4+ messages in thread
From: Carsey, Jaben @ 2016-10-18 14:54 UTC (permalink / raw)
To: Tim Lewis, Laszlo Ersek, edk2-devel-01; +Cc: Ni, Ruiyu, Carsey, Jaben
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Tim Lewis [mailto:tim.lewis@insyde.com]
> Sent: Tuesday, October 18, 2016 5:44 AM
> To: Laszlo Ersek <lersek@redhat.com>; edk2-devel-01 <edk2-
> devel@ml01.01.org>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: RE: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in
> EfiShellGetGuidFromName()
> Importance: High
>
> Reviewed-by: Tim Lewis <tim.lewis@insyde.com>
>
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, October 18, 2016 4:07 AM
> To: edk2-devel-01 <edk2-devel@ml01.01.org>
> Cc: Jaben Carsey <jaben.carsey@intel.com>; Ruiyu Ni <ruiyu.ni@intel.com>;
> Tim Lewis <tim.lewis@insyde.com>
> Subject: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in
> EfiShellGetGuidFromName()
>
> The destination GUID comes first; from
> "MdePkg/Include/Library/BaseMemoryLib.h":
>
> > GUID *
> > EFIAPI
> > CopyGuid (
> > OUT GUID *DestinationGuid,
> > IN CONST GUID *SourceGuid
> > );
>
> Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and
> "Guid" is where EfiShellGetGuidFromName() has to propagate that result to.
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Tim Lewis <tim.lewis@insyde.com>
> Reported-by: Tim Lewis <tim.lewis@insyde.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> ShellPkg/Application/Shell/ShellProtocol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ShellPkg/Application/Shell/ShellProtocol.c
> b/ShellPkg/Application/Shell/ShellProtocol.c
> index 2bc0646b453d..04b66c5acaae 100644
> --- a/ShellPkg/Application/Shell/ShellProtocol.c
> +++ b/ShellPkg/Application/Shell/ShellProtocol.c
> @@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName(
> Status = GetGuidFromStringName(GuidName, NULL, &NewGuid);
>
> if (!EFI_ERROR(Status)) {
> - CopyGuid(NewGuid, Guid);
> + CopyGuid(Guid, NewGuid);
> }
>
> return (Status);
> --
> 2.9.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()
2016-10-18 14:54 ` Carsey, Jaben
@ 2016-10-18 17:36 ` Laszlo Ersek
0 siblings, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2016-10-18 17:36 UTC (permalink / raw)
To: Carsey, Jaben, Tim Lewis; +Cc: edk2-devel-01, Ni, Ruiyu
On 10/18/16 16:54, Carsey, Jaben wrote:
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>
>> -----Original Message-----
>> From: Tim Lewis [mailto:tim.lewis@insyde.com]
>> Sent: Tuesday, October 18, 2016 5:44 AM
>> To: Laszlo Ersek <lersek@redhat.com>; edk2-devel-01 <edk2-
>> devel@ml01.01.org>
>> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
>> Subject: RE: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in
>> EfiShellGetGuidFromName()
>> Importance: High
>>
>> Reviewed-by: Tim Lewis <tim.lewis@insyde.com>
Commit 09bd67f09573.
Thanks!
Laszlo
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Tuesday, October 18, 2016 4:07 AM
>> To: edk2-devel-01 <edk2-devel@ml01.01.org>
>> Cc: Jaben Carsey <jaben.carsey@intel.com>; Ruiyu Ni <ruiyu.ni@intel.com>;
>> Tim Lewis <tim.lewis@insyde.com>
>> Subject: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in
>> EfiShellGetGuidFromName()
>>
>> The destination GUID comes first; from
>> "MdePkg/Include/Library/BaseMemoryLib.h":
>>
>>> GUID *
>>> EFIAPI
>>> CopyGuid (
>>> OUT GUID *DestinationGuid,
>>> IN CONST GUID *SourceGuid
>>> );
>>
>> Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and
>> "Guid" is where EfiShellGetGuidFromName() has to propagate that result to.
>>
>> Cc: Jaben Carsey <jaben.carsey@intel.com>
>> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>> Cc: Tim Lewis <tim.lewis@insyde.com>
>> Reported-by: Tim Lewis <tim.lewis@insyde.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> ShellPkg/Application/Shell/ShellProtocol.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ShellPkg/Application/Shell/ShellProtocol.c
>> b/ShellPkg/Application/Shell/ShellProtocol.c
>> index 2bc0646b453d..04b66c5acaae 100644
>> --- a/ShellPkg/Application/Shell/ShellProtocol.c
>> +++ b/ShellPkg/Application/Shell/ShellProtocol.c
>> @@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName(
>> Status = GetGuidFromStringName(GuidName, NULL, &NewGuid);
>>
>> if (!EFI_ERROR(Status)) {
>> - CopyGuid(NewGuid, Guid);
>> + CopyGuid(Guid, NewGuid);
>> }
>>
>> return (Status);
>> --
>> 2.9.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-18 17:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 11:07 [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName() Laszlo Ersek
2016-10-18 12:43 ` Tim Lewis
2016-10-18 14:54 ` Carsey, Jaben
2016-10-18 17:36 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox