From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC2681A1E3E for ; Tue, 18 Oct 2016 10:36:33 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 268E761E73; Tue, 18 Oct 2016 17:36:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-72.phx2.redhat.com [10.3.116.72]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9IHaVV2003783; Tue, 18 Oct 2016 13:36:31 -0400 To: "Carsey, Jaben" , Tim Lewis References: <20161018110725.28585-1-lersek@redhat.com> <7236196A5DF6C040855A6D96F556A53F3F8539@msmail.insydesw.com.tw> Cc: edk2-devel-01 , "Ni, Ruiyu" From: Laszlo Ersek Message-ID: Date: Tue, 18 Oct 2016 19:36:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 18 Oct 2016 17:36:33 +0000 (UTC) Subject: Re: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 17:36:33 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 10/18/16 16:54, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > >> -----Original Message----- >> From: Tim Lewis [mailto:tim.lewis@insyde.com] >> Sent: Tuesday, October 18, 2016 5:44 AM >> To: Laszlo Ersek ; edk2-devel-01 > devel@ml01.01.org> >> Cc: Carsey, Jaben ; Ni, Ruiyu >> Subject: RE: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in >> EfiShellGetGuidFromName() >> Importance: High >> >> Reviewed-by: Tim Lewis Commit 09bd67f09573. Thanks! Laszlo >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Tuesday, October 18, 2016 4:07 AM >> To: edk2-devel-01 >> Cc: Jaben Carsey ; Ruiyu Ni ; >> Tim Lewis >> Subject: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in >> EfiShellGetGuidFromName() >> >> The destination GUID comes first; from >> "MdePkg/Include/Library/BaseMemoryLib.h": >> >>> GUID * >>> EFIAPI >>> CopyGuid ( >>> OUT GUID *DestinationGuid, >>> IN CONST GUID *SourceGuid >>> ); >> >> Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and >> "Guid" is where EfiShellGetGuidFromName() has to propagate that result to. >> >> Cc: Jaben Carsey >> Cc: Ruiyu Ni >> Cc: Tim Lewis >> Reported-by: Tim Lewis >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek >> --- >> ShellPkg/Application/Shell/ShellProtocol.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ShellPkg/Application/Shell/ShellProtocol.c >> b/ShellPkg/Application/Shell/ShellProtocol.c >> index 2bc0646b453d..04b66c5acaae 100644 >> --- a/ShellPkg/Application/Shell/ShellProtocol.c >> +++ b/ShellPkg/Application/Shell/ShellProtocol.c >> @@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName( >> Status = GetGuidFromStringName(GuidName, NULL, &NewGuid); >> >> if (!EFI_ERROR(Status)) { >> - CopyGuid(NewGuid, Guid); >> + CopyGuid(Guid, NewGuid); >> } >> >> return (Status); >> -- >> 2.9.2 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >