From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 54076D8003E for ; Wed, 6 Mar 2024 18:19:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CQiU1SAxo0jsMxShwOqyg7RM8R8GNyVZgY2x2i7EU5w=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709749188; v=1; b=p+w8Bxk16CXNMwM2xTocjpUlNLUfNmxXxdlvJ17/ZkwotuaGMsawSXZFh8B+FQzdF3tV+AOQ /dhP4vmZ3bX5IAWSqVQKg599lG8DfhY42fcp7X0pWK228APK9odZugCz/J2sh9jWMeipEaAF735 1R/nIig4bjlIWyJxm+PN6/F05RbZfS8P6ZJgNXyAT5Ff8wmYaALG2Nl+DfwiAXsh48eyhram6f8 7/jCG8DXN6J+6kaHAmfERhaVGrnZkEPfQtBnJv1oM0JzbIWleV4IZ/G0E+23U/XJu6D0mFfg1z+ S4GONXchbKvs17iwKrlrpmRORhjBemKNe7bwHiokz+BbQ== X-Received: by 127.0.0.2 with SMTP id NrcMYY7687511xZVtZupFGlR; Wed, 06 Mar 2024 10:19:48 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.1256.1709749188208551319 for ; Wed, 06 Mar 2024 10:19:48 -0800 X-Received: from [10.137.194.171] (unknown [131.107.160.171]) by linux.microsoft.com (Postfix) with ESMTPSA id 71B3320B74C0; Wed, 6 Mar 2024 10:19:47 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 71B3320B74C0 Message-ID: Date: Wed, 06 Mar 2024 10:19:48 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel][PATCH v2 1/1] MdeModulePkg: Remove ArmPkg Dependency From: "Oliver Smith-Denny" To: devel@edk2.groups.io, Liming Gao Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Sean Brogan , Ard Biesheuvel Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com References: <17B3DE09466BEB48.21218@groups.io> <17B7778B258D489D.13095@groups.io> In-Reply-To: <17B7778B258D489D.13095@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: x8voWQOpO74Re9bpVEdijsXmx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=p+w8Bxk1; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none) Hi Liming, Friendly ping again, can you please review? Oliver On 2/26/2024 8:47 AM, Oliver Smith-Denny wrote: > Hi Liming, >=20 > Now that the stable tag is completed, can you review this MdeModulePkg > patch? >=20 > Thanks, > Oliver >=20 > On 2/14/2024 3:20 PM, Oliver Smith-Denny wrote: >> With commita21a994f55e53325d3e060c435ca3a87fd7c2c79 >> MdeModulePkg no longer has a hard dependency on ArmMmuLib and therefore >> ArmLib. This is the final dependency on ArmPkg, so remove the >> unused libs and drop the allowed dependency on ArmPkg as >> MdeModulePkg should not depend on it as this is a circular >> dependency. >> >> Github PR: https://github.com/tianocore/edk2/pull/5361 >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3651 >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Sami Mujawar >> Cc: Liming Gao >> >> Signed-off-by: Oliver Smith-Denny >> Reviewed-by: Sean Brogan >> Acked-by: Ard Biesheuvel >> --- >> >> Notes: >> =C2=A0=C2=A0=C2=A0=C2=A0 v2: >> =C2=A0=C2=A0=C2=A0=C2=A0 - Add bugzilla link to commit message >> =C2=A0=C2=A0=C2=A0=C2=A0 - Add Sean's RB and Ard's ack >> >> =C2=A0 MdeModulePkg/MdeModulePkg.dsc=C2=A0=C2=A0=C2=A0=C2=A0 | 2 -- >> =C2=A0 MdeModulePkg/MdeModulePkg.ci.yaml | 3 +-- >> =C2=A0 2 files changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/MdeModulePkg/MdeModulePkg.dsc=20 >> b/MdeModulePkg/MdeModulePkg.dsc >> index 6b3052ff4614..c0f1df3bfbca 100644 >> --- a/MdeModulePkg/MdeModulePkg.dsc >> +++ b/MdeModulePkg/MdeModulePkg.dsc >> @@ -179,8 +179,6 @@ [LibraryClasses.common.MM_STANDALONE] >> =20 >> MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf >> =C2=A0 [LibraryClasses.ARM, LibraryClasses.AARCH64] >> -=C2=A0 ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf >> -=C2=A0 ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf >> =C2=A0=C2=A0=C2=A0 LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBo= xNullLib.inf >> =C2=A0=C2=A0=C2=A0 # >> diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml=20 >> b/MdeModulePkg/MdeModulePkg.ci.yaml >> index 669f54e33c0d..a3de60a12c9e 100644 >> --- a/MdeModulePkg/MdeModulePkg.ci.yaml >> +++ b/MdeModulePkg/MdeModulePkg.ci.yaml >> @@ -53,8 +53,7 @@ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AcceptableDepend= encies": [ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 "MdePkg/MdePkg.dec", >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 "MdeModulePkg/MdeModulePkg.dec", >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Sta= ndaloneMmPkg/StandaloneMmPkg.dec", >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Arm= Pkg/ArmPkg.dec"=C2=A0 # this should be fixed by promoting=20 >> an abstraction >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Sta= ndaloneMmPkg/StandaloneMmPkg.dec" >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ], >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # For host based = unit tests >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AcceptableDepend= encies-HOST_APPLICATION":[ >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116451): https://edk2.groups.io/g/devel/message/116451 Mute This Topic: https://groups.io/mt/104363773/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-