From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.113]) by mx.groups.io with SMTP id smtpd.web10.62505.1683452094530045153 for ; Sun, 07 May 2023 02:34:54 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=TquG3Ozq; spf=pass (domain: os.amperecomputing.com, ip: 40.107.95.113, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KxN2OEldjLeWItOwILzuO4qeCpSHPZy8MizI2RtiHIyL2x+Kqjf8PzxkGV0NxrFQDFi5Xx7J4NKbBNezjM21+xpI5AB7hqQiHP5Sb5kFzR+PPcbcpjBIh5ybukvulpwLT38B9fDf49877M//c29piZOPFk1jbV4UnJJgeguZWDrhtaDYADRlI/91wXlu1QNYEV9WT87ab1G262Y7f9Fj4y+rYBmo79G3FI/JZZiDN3QucYDMw2BkHF+GoAc51rdvRCsSiJqN7t7uXfANpEYSEKV4+4uZRRxOiZxlDBtE8LwV+kY5dOOLrEVko0FV1VG+j83qAbCSf0mOs02ZI2xQ0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z3sIXYLfB9T6Cy3LvdTBtkTLQSxSvTsh+pO8FrgrRgM=; b=cT7M5Kj087EQndfEokz34Znl/HswTbExXClr3hZl4lhf2iW0eCJUkNSl35DrlhCsGO4KzjMnnk1JuKRdVCBva1vYRnUPsUousIa85FdoWXX8JRJ23v+giq22jdCJd7247841M4oyrFS6/6DLOiIBxZHcRqjLfKAawTxE9gCI5/iKR62d2sQnwujf9gV/28aNF6GgXWn53R5HowhevFQ7HNcelfqkYIKrv7bOt4e6PaPeL3fFXvVd4wHGQ3/+9k3tCA2TKbRfvrOw79wuysv5yiKEJLldvz/+Sr6kre4zWl8tRjUyt1H6c8FrCOa4hnW8LRwmgc5XsLZuE6BDbIuNNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z3sIXYLfB9T6Cy3LvdTBtkTLQSxSvTsh+pO8FrgrRgM=; b=TquG3OzqmCRAlCmlRfmTK2075b0B1JWHOdxfdGH+AEg/yxQDxQpyiFwGzLadphMAx2rMDxWzh1Bm2ZRBQcgMbdev+GlDqqukmghTKrLjDafHNpXGIr3p1hAJ3YKBeZrg/TxINkNQAPdMeYUwFGeOeNIkIqfMcWw7/rSz9K1hQJM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) by PH0PR01MB6523.prod.exchangelabs.com (2603:10b6:510:a1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Sun, 7 May 2023 09:34:49 +0000 Received: from DM5PR0102MB3336.prod.exchangelabs.com ([fe80::bb9e:46d1:ae4b:caf2]) by DM5PR0102MB3336.prod.exchangelabs.com ([fe80::bb9e:46d1:ae4b:caf2%7]) with mapi id 15.20.6363.031; Sun, 7 May 2023 09:34:48 +0000 Message-ID: Date: Sun, 7 May 2023 16:34:38 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogWyAqKiBTUEFNTUFJTCAqKiBdW2VkazItZGV2ZWxdIFtQQVRDSCB2MyAzLzNdIE1kZVBrZy9JbmR1c3RyeVN0YW5kYXJkOiBBZGQgSW50ZXJmYWNlIENhcGFiaWxpdGllcyBkZWZpbml0aW9ucw==?= To: gaoliming , devel@edk2.groups.io, tinhnguyen@os.amperecomputing.com CC: patches@amperecomputing.com, michael.d.kinney@intel.com, zhiguang.liu@intel.com, abner.chang@amd.com References: <20230503112415.2073176-1-tinhnguyen@os.amperecomputing.com> <20230503112415.2073176-4-tinhnguyen@os.amperecomputing.com> <034401d97e5f$50e8d790$f2ba86b0$@byosoft.com.cn> From: "Tinh Nguyen" In-Reply-To: <034401d97e5f$50e8d790$f2ba86b0$@byosoft.com.cn> X-ClientProxiedBy: SI1PR02CA0011.apcprd02.prod.outlook.com (2603:1096:4:1f7::19) To DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3336:EE_|PH0PR01MB6523:EE_ X-MS-Office365-Filtering-Correlation-Id: d4fd43ed-dd33-4e12-fbfb-08db4ede4cb4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zMwy2hpLlJCTqTL6RXdz1xWkYR+16NYOQu3evQ0+jAleCE1M0cd0ISmEOwAESt+qos2DM17jUq8txK2r3Aeuix8KvX71ieOIQp+Q2ILSdvyFpZ5hYzeevhCvQmG6PFit55REDLoaygGqD1ZyLpEzNOKNg3uKJWZL3wGiDI9AB7IPdyg8tXHDzy4ZHHc19mpDDOrYBwBkVh2U7CBtoc/mTK4rfAaD9LXGBb4JZ0h4LmHy0xFw3KYUs2R1utyGTdQyNzv7I0qQjgQHLAgIEA8OXMifclqLTOHy8JeAeDw7V7oxPkgzdBEc9bEYP7KpRfVhRmHKwTlVacaX+WGOmCmOuH56DYMSpiYVboeQoBqsbEe93cHDXXg59TK8w+VL3EgbC9bTLm/oNmLra6xee5hQwuNgGusEhorR0o0QI5y+k5fnJ5qbPcnmI4wsID+sGMYXeYMqoVfAMa/iG61uNKnGL+jQVjb/dKfOCfpmaV90zzUJLwx/yYuN+GS1ihW9P+qex/KXtar/vL5biTXZe2DN7LC3/KBkwgYB2fUAnwxZYaFMgbkxL1mECYsynIp9fkdX0VVnReB2J3HiQyVENbnhqBzqW+x6On7MnjuLdX0WE8Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3336.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(376002)(396003)(39850400004)(136003)(451199021)(2906002)(5660300002)(38100700002)(31696002)(224303003)(83170400001)(66946007)(6486002)(4326008)(66556008)(66476007)(6666004)(31686004)(53546011)(6506007)(478600001)(186003)(6512007)(26005)(42882007)(41300700001)(8936002)(66899021)(83380400001)(966005)(316002)(2616005)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VOjLObqJ8vMjpCHK03esHCH+WPf6gYb28NxxwllCLh8nLOT++seEBSmzzfql?= =?us-ascii?Q?damiTfV1G9DGjbBrr8gOyt99fw2vmoHvebmx0kt/LyuhLcraUaNajiz9wLOb?= =?us-ascii?Q?pDQrs6TPqDSes13a2npxQGmUmxa9ASdaxrx/b1v/K3vYCh1lhd1oV/n6Ax6W?= =?us-ascii?Q?msTidNL0dm4xAt5K4sFFBPDP4XcRrFQKYt0Uxtg4J5NqcBi5xYt3sGQjW0Zz?= =?us-ascii?Q?DuMfU6ijr7nFNvDQBn9VDp4XCGYEUfQ/WDpvikROVP9x0+V9LAVStgfBSlAI?= =?us-ascii?Q?GHiFIc6SXFCptpDz9H2AkkigiSOkNelh87afIHkaokIl2BLBDqJ80R+OefFj?= =?us-ascii?Q?dwr8zZ1x37N4zM9Mw/g8OToCFCQV5nCKx2xOA0zr3d2RP98X+aRLFGMZJr3D?= =?us-ascii?Q?AId2IBcSqRIJgC6fI8gFRadQr2OLOhsTaLx1rXWDj80huajII1XDlVKN25E/?= =?us-ascii?Q?fh3s3rK8iwEbW/xJAoiAuzr1wNSdeUi3YfqMcHjhBJmykq39LhSaaUz0tBWs?= =?us-ascii?Q?5Ampx4cXGjcQ2wJm9SyMEkpaUufAk/Dj9dFKLNgoXSzlEB4cFfIHBDsY1vG5?= =?us-ascii?Q?vUKKT5CVHufRXynhQQIpOmXviA6B5xrKqeZz6gs277S9/fRg2Sc8vwmhYpnd?= =?us-ascii?Q?0uXS4uDuAtiM9tm+lRhpg6w8UM0GiRz/M5svySXyYxNeL71Ha3BRa213xQ+7?= =?us-ascii?Q?6a9buEx8mufDlQBZ+8I3FXr8YSy+KHh0xFLI+50QItOdDXQqSBJoXaqW1k7n?= =?us-ascii?Q?YfVyMddNsmSjL5lyyIS8wn/Yuc2/sz6W4KHoNKEeE2pZ/FbUOUtECAlOR2sa?= =?us-ascii?Q?R91N1ZDVZkoPqMF3J7N0kpp1Q1Iu7pmYVeObMhdU6mBSon9s+CODm+LCLIc5?= =?us-ascii?Q?cxNoFrjySLmzhXV5u6VbVh1LkJZf+1c8qQjewCtWMLkc+M0qZo1om/J0fGPv?= =?us-ascii?Q?zi7dgk5jUfJpeFjtp/6Bp7AJYusnbo1IZTwmXYpK2rFpJTN0OJQLSwL/NuWa?= =?us-ascii?Q?da9sPZbMi3+Q2ZaQGhe+9PRAGm6m7LwK1SdFCiC8EVfq9LatRXrYSQw68KRx?= =?us-ascii?Q?G+I+evZYHk6lvxbG6eJeeszHNcyAUXZSOcv6fpSDJOAwLC0urcGOgwmlJAN5?= =?us-ascii?Q?5YVVMIHqVHBtZxJls00PpqZ66T1kPv2I52ikQldhcmL0+YtfVSE6X+1pTGYT?= =?us-ascii?Q?mLHKqQFVZ+d52Nv1O2lOLNJSybcctosCOzZiB/LpertPx3ugW8cHHysSReAq?= =?us-ascii?Q?AbmUBnlY9UDWsJ0FMXfPfTk0Uox7wcUGw1kaaJT/1X4ywVnuGpxj/WDWGbaA?= =?us-ascii?Q?Ai/89ESM18ju5hbTiPcV7LIBBkHcqKJ439mY/MyJPKhmKfQsTGojE7IiMPzK?= =?us-ascii?Q?DvIrV59e0sHcuvhf6sa5Rald6UgO23kULr7BrtRUqXH9dQZSu+Di+/POxIsi?= =?us-ascii?Q?or/6FO2Kl4PBediwdthjREMy9oKW7nbnTrRHwACp8DixJf3TvoVZ4waWODFq?= =?us-ascii?Q?expnIC6k36vKc/MIhdJCSoV8eeAuebAqk2mYE1a1sbBAE77Y7UGDKlKfP8kh?= =?us-ascii?Q?I9V+LTZX8d4EHhYSOH2Q4eUquyK8hM7jI5JIlc8xhSyeONd6FXC0lwnwUZqa?= =?us-ascii?Q?Iv9ovscTAI4FMfg/ti3IIA517gSXxntTvOXssJ4Nz0QI?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4fd43ed-dd33-4e12-fbfb-08db4ede4cb4 X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3336.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2023 09:34:48.3990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fol4pCA3GK9oV6+ClukxLVSM2Rze2K71GpJ4AZG2AFT6vHVXHtejGC0YQT9PITLs/2ySQTf3oQvr+bQrbAeRq+Rbx1lJX6U+TCCEI9myuyl9dUht8qgxdcXhTCpQmwcR X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6523 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Liming, Sorry I missed your comment. I have submitted v4 and here is the pull=20 request https://github.com/tianocore/edk2/pull/4352 Thanks, Tinh On 04/05/2023 15:06, gaoliming wrote: > Tinh: > For the patch subject, I suggest to add IPMI key word to specify this = change is for IPMI, such as MdePkg/IndustryStandard: Add IPMI Interface Cap= abilities definitions > > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Tinh Nguyen >> via groups.io >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B45=E6=9C=883=E6=97=A5 = 19:24 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io >> =E6=8A=84=E9=80=81: patches@amperecomputing.com; michael.d.kinney@intel.= com; >> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; abner.chang@amd.com; >> Tinh Nguyen >> =E4=B8=BB=E9=A2=98: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v3 3/3] >> MdePkg/IndustryStandard: Add Interface Capabilities definitions >> >> This adds more definitions for the IPMI Get System Interface >> Capabilities command. >> >> Signed-off-by: Tinh Nguyen >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Zhiguang Liu >> Cc: Abner Chang >> Reviewed-by: Abner Chang >> --- >> MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 >> ++++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> >> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h >> b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h >> index a5835ba08c00..b6bc91f46c2d 100644 >> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h >> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h >> @@ -13,6 +13,7 @@ >> >> Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved. >> Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.=
>> + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
>> SPDX-License-Identifier: BSD-2-Clause-Patent >> **/ >> >> @@ -1046,6 +1047,51 @@ typedef struct { >> // Constants and Structure definitions for "Get System Interface >> Capabilities" command to follow here >> // >> >> +#define >> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF 0x0 >> +#define >> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS 0x1 >> +#define >> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC 0x2 >> + >> +typedef union { >> + struct { >> + UINT8 InterfaceType : 4; >> + UINT8 Reserved : 4; >> + } Bits; >> + UINT8 Uint8; >> +} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST; >> + >> +typedef union { >> + struct { >> + UINT8 Version : 3; >> + UINT8 PecSupport : 1; >> + UINT8 Reserved : 2; >> + UINT8 TransactionSupport : 2; >> + } Bits; >> + UINT8 Uint8; >> +} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES; >> + >> +typedef union { >> + struct { >> + UINT8 SystemInterfaceVersion : 3; >> + UINT8 Reserved : 5; >> + } Bits; >> + UINT8 Uint8; >> +} IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES; >> + >> +typedef struct { >> + UINT8 CompletionCode; >> + UINT8 Reserved; >> + IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES InterfaceCap; >> + UINT8 InputMsgSize; >> + UINT8 OutputMsgSize; >> +} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE; >> + >> +typedef struct { >> + UINT8 >> CompletionCode; >> + UINT8 Reserved; >> + IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES InterfaceCap; >> + UINT8 >> InputMaxMsgSize; >> +} IPMI_GET_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES_RESPONSE; >> + >> // >> // Definitions for Get System Interface Capabilities command SSIF >> transaction support >> // >> -- >> 2.40.0 >> >> >> >>=20 >> > >