public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Pete Batard <pete@akeo.ie>, devel@edk2.groups.io
Cc: Jared McNeill <jmcneill@invisible.ca>,
	Andrei Warkentin <awarkentin@vmware.com>,
	Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
	Leif Lindholm <leif@nuviainc.com>,
	Jeremy Linton <lintonrjeremy@gmail.com>
Subject: Re: [PATCH edk2-platforms 3/3] Platform/RaspberryPi: don't connect all devices on an ordinary boot
Date: Fri, 5 Jun 2020 10:10:28 +0200	[thread overview]
Message-ID: <ca2de0cc-528e-ba16-e70b-090de6ebb86b@arm.com> (raw)
In-Reply-To: <4d28d975-c978-805f-f5ab-5a12f626209a@akeo.ie>

On 6/4/20 2:27 PM, Pete Batard wrote:
> On 2020.06.04 10:50, Ard Biesheuvel wrote:
>> The BDS will connect device paths that are considered as boot options,
>> so there is really no reason to always connect absolutely everything.
>> So now that all the drivers have been updated to play nice in this
>> case, remove the ConnectAll() call from the RPi BDS code.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> ---
>>   Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c | 5 
>> -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git 
>> a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c 
>> b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
>> index 2bd625ad7e7c..253614a646c1 100644
>> --- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
>> +++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
>> @@ -655,11 +655,6 @@ PlatformBootManagerAfterConsole (
>>       Print (BOOT_PROMPT);
>>
>>     }
>>
>>
>> -  //
>>
>> -  // Connect the rest of the devices.
>>
>> -  //
>>
>> -  EfiBootManagerConnectAll ();
>>
>> -
>>
>>     Status = gBS->LocateProtocol (&gEsrtManagementProtocolGuid, NULL, 
>> (VOID**)&EsrtManagement);
>>
>>     if (!EFI_ERROR (Status)) {
>>
>>       EsrtManagement->SyncEsrtFmp ();
>>
> 
> Reviewed-by: Pete Batard <pete@akeo.ie>
> For the series (after application of the planned edk2 commits to confirm 
> that UEFI Shell is now added as an option in Boot Manager):
> Tested-by: Pete Batard <pete@akeo.ie>

Series pushed as 4a937016142e..c8000ecccc83

Thanks all


      reply	other threads:[~2020-06-05  8:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04  9:50 [PATCH edk2-platforms 0/3] Platform/RaspberryPi: omit ConnectAll() on regular boot Ard Biesheuvel
2020-06-04  9:50 ` [PATCH edk2-platforms 1/3] Silicon/Broadcom/BcmGenetDxe: program MAC also when not connected Ard Biesheuvel
2020-06-04 12:27   ` Pete Batard
2020-06-04 14:53   ` Leif Lindholm
2020-06-04 14:57     ` Ard Biesheuvel
2020-06-04 15:00       ` Leif Lindholm
2020-06-04  9:50 ` [PATCH edk2-platforms 2/3] Platform/RaspberryPi: add UEFI Shell to boot manager menu Ard Biesheuvel
2020-06-04 12:27   ` Pete Batard
2020-06-04  9:50 ` [PATCH edk2-platforms 3/3] Platform/RaspberryPi: don't connect all devices on an ordinary boot Ard Biesheuvel
2020-06-04 12:27   ` Pete Batard
2020-06-05  8:10     ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca2de0cc-528e-ba16-e70b-090de6ebb86b@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox