From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.6431.1591344632855562651 for ; Fri, 05 Jun 2020 01:10:33 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 905E22B; Fri, 5 Jun 2020 01:10:32 -0700 (PDT) Received: from [192.168.1.69] (unknown [10.37.8.209]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B12B3F305; Fri, 5 Jun 2020 01:10:30 -0700 (PDT) Subject: Re: [PATCH edk2-platforms 3/3] Platform/RaspberryPi: don't connect all devices on an ordinary boot To: Pete Batard , devel@edk2.groups.io Cc: Jared McNeill , Andrei Warkentin , Samer El-Haj-Mahmoud , Leif Lindholm , Jeremy Linton References: <20200604095007.45693-1-ard.biesheuvel@arm.com> <20200604095007.45693-4-ard.biesheuvel@arm.com> <4d28d975-c978-805f-f5ab-5a12f626209a@akeo.ie> From: "Ard Biesheuvel" Message-ID: Date: Fri, 5 Jun 2020 10:10:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <4d28d975-c978-805f-f5ab-5a12f626209a@akeo.ie> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/4/20 2:27 PM, Pete Batard wrote: > On 2020.06.04 10:50, Ard Biesheuvel wrote: >> The BDS will connect device paths that are considered as boot options, >> so there is really no reason to always connect absolutely everything. >> So now that all the drivers have been updated to play nice in this >> case, remove the ConnectAll() call from the RPi BDS code. >> >> Signed-off-by: Ard Biesheuvel >> --- >> =C2=A0 Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.= c | 5=20 >> ----- >> =C2=A0 1 file changed, 5 deletions(-) >> >> diff --git=20 >> a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c=20 >> b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c >> index 2bd625ad7e7c..253614a646c1 100644 >> --- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c >> +++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c >> @@ -655,11 +655,6 @@ PlatformBootManagerAfterConsole ( >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Print (BOOT_PROMPT); >> >> =C2=A0=C2=A0=C2=A0 } >> >> >> -=C2=A0 // >> >> -=C2=A0 // Connect the rest of the devices. >> >> -=C2=A0 // >> >> -=C2=A0 EfiBootManagerConnectAll (); >> >> - >> >> =C2=A0=C2=A0=C2=A0 Status =3D gBS->LocateProtocol (&gEsrtManagementPro= tocolGuid, NULL,=20 >> (VOID**)&EsrtManagement); >> >> =C2=A0=C2=A0=C2=A0 if (!EFI_ERROR (Status)) { >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EsrtManagement->SyncEsrtFmp (); >> >=20 > Reviewed-by: Pete Batard > For the series (after application of the planned edk2 commits to confir= m=20 > that UEFI Shell is now added as an option in Boot Manager): > Tested-by: Pete Batard Series pushed as 4a937016142e..c8000ecccc83 Thanks all