Re: [PATCH 04/10] MdeModulePkg/ResetSystemRuntimeDxe: Add platform filter and handler

["Zeng, Star" <star.zeng@intel.com>]

Some minor comments added below except Laszlo's.

With them handled, Reviewed-by: Star Zeng <star.zeng@intel.com>

On 2018/2/2 14:45, Ruiyu Ni wrote:
> From: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Add support for platform specific reset filters and platform
> specific reset handlers to ResetSystem().  A filter may modify
> the reset type and reset data and call ResetSystem() with the
> modified parameters.  A handler performs the reset action.
> 
> The support for platform specific filters and platform specific
> handlers is based on the Reset Notification feature added to the
> UEFI 2.7 Specification.
> 
> Platform specific reset filters are processed first so the final
> reset type and reset data can be determined.  In the DXE Phase
> The UEFI Reset Notifications are processed second so all UEFI
> Drivers that have registered for a Reset Notification can perform
> any required clean up actions.  The platform specific reset
> handlers are processed third.  If there are no registered
> platform specific reset handlers or none of them reset the
> platform, then the default reset action based on the
> ResetSystemLib is performed.
> 
> In the PEI Phase, filters are handlers are registered through

Should be "filters and handlers"?

> the folloiwng 2 PPIs that are based on
> EFI_RESET_NOTIFICATION_PROTOCOL.
> * gEdkiiPlatformSpecificResetFilterPpiGuid
> * gEdkiiPlatformSpecificResetFilterPpiGuid
> 
> In the DXE Phase, filters are handlers are registered through

Should be "filters and handlers"?

> the folloiwng 2 Protocols that are based on
> EFI_RESET_NOTIFICATION_PROTOCOL.
> * gEdkiiPlatformSpecificResetFilterProtocolGuid
> * gEdkiiPlatformSpecificResetFilterProtocolGuid
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---

[...]

> +    //
> +    // call reset notification functions registered through the
> +    // EDKII_PLATFORM_SPECIFIC_RESET_NOTIFICATION_PROTOCOL.

Should be EDKII_PLATFORM_SPECIFIC_RESET_HANDLER_PROTOCOL?

Thanks,
Star

> +    //
> +    for ( Link = GetFirstNode (&mPlatformSpecificResetHandler.ResetNotifies)
> +        ; !IsNull (&mPlatformSpecificResetHandler.ResetNotifies, Link)
> +        ; Link = GetNextNode (&mPlatformSpecificResetHandler.ResetNotifies, Link)
> +        ) {
> +      Entry = RESET_NOTIFY_ENTRY_FROM_LINK (Link);
> +      Entry->ResetNotify (ResetType, ResetStatus, DataSize, ResetData);
> +    }
>     }
>   
>     switch (ResetType) {
> diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h
> index 75cdd88896..ea5660274b 100644
> --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h
> +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h
> @@ -20,6 +20,8 @@
>   
>   #include <Protocol/Reset.h>
>   #include <Protocol/ResetNotification.h>
> +#include <Protocol/PlatformSpecificResetFilter.h>
> +#include <Protocol/PlatformSpecificResetHandler.h>
>   #include <Guid/CapsuleVendor.h>
>   
>   #include <Library/BaseLib.h>
> @@ -34,6 +36,11 @@
>   #include <Library/ReportStatusCodeLib.h>
>   #include <Library/MemoryAllocationLib.h>
>   
> +//
> +// The maximum recurstion depth to ResetSystem() by reset notification handlers
> +//
> +#define MAX_RESET_NOTIFY_DEPTH 10
> +
>   typedef struct {
>     UINT32                   Signature;
>     LIST_ENTRY               Link;
> diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf
> index 11233757c2..da9e8e118b 100644
> --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf
> +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf
> @@ -55,9 +55,10 @@ [Guids]
>   
>   
>   [Protocols]
> -  gEfiResetArchProtocolGuid                     ## PRODUCES
> -  gEfiResetNotificationProtocolGuid             ## PRODUCES
> -
> +  gEfiResetArchProtocolGuid                       ## PRODUCES
> +  gEfiResetNotificationProtocolGuid               ## PRODUCES
> +  gEdkiiPlatformSpecificResetFilterProtocolGuid   ## PRODUCES
> +  gEdkiiPlatformSpecificResetHandlerProtocolGuid  ## PRODUCES
>   
>   [Depex]
>     TRUE
>