From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: solarflare.com, ip: 148.163.129.53, mailfrom: tzhao@solarflare.com) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by groups.io with SMTP; Wed, 18 Sep 2019 01:48:25 -0700 X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 6099B80065; Wed, 18 Sep 2019 08:48:24 +0000 (UTC) Received: from [10.17.20.221] (10.17.20.221) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 18 Sep 2019 09:48:19 +0100 From: "Tom Zhao" Subject: [PATCH v2 1/1] uefi-sct/SctPkg AdapterInfo SetInformation may return unsupported To: CC: Eric Jin , Supreeth Venkatesh Message-ID: Date: Wed, 18 Sep 2019 09:48:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 X-Originating-IP: [10.17.20.221] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24918.003 X-TM-AS-Result: No-4.146600-8.000000-10 X-TMASE-MatchedRID: QvUoAgZEbVzKFqYEr+5FcszSKGx9g8xh0Y5wB8cprq5THhSneq8wp1nb fl9ZhZv9I/VTOL1TmBiObEg1nbxvXghqh+u1IaR7nFVnNmvv47tLXPA26IG0hN9RlPzeVuQQFQL H9fnGRSfqasocX+e5Nmgea7xKC/CgkfRhdidsajM5f9Xw/xqKXZLy/k4uPY3KxEHRux+uk8ifEz J5hPndGYfNneR4cpgZlmVZDcVU2O11qCM9D3AQfnUJA4jN2/WYde9MWT1Y33ma/A8j8pOipXrKg cGIVx6qDQCTbNUs28GyQTNdGAJMRRoQVhcDKUH1JRIzmbBpwaQgJCm6ypGLZ6Ol5oRXyhFEVlxr 1FJij9s= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.146600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24918.003 X-MDID: 1568796505-EpwrluQDgoOP Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit If AdapterInfo.SetInformation() is unsupported, it will return EFI_UNSUPPORTED. Do not fail the test in this case. Cc: Supreeth Venkatesh Cc: Eric Jin Signed-off-by: Tom Zhao --- Notes: v2: - Change commit message to be closer to similar issues. uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c | 4 ++-- uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c index fb42398e4a97..3dc048db5333 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c @@ -556,8 +556,8 @@ BBTestSetInformationConformanceTestCheckpoint2 ( NULL, InformationBlockSize ); - - if ( Status != EFI_INVALID_PARAMETER && Status != EFI_WRITE_PROTECTED) { + + if ( Status != EFI_INVALID_PARAMETER && Status != EFI_WRITE_PROTECTED && Status != EFI_UNSUPPORTED) { AssertionType = EFI_TEST_ASSERTION_FAILED; } else { AssertionType = EFI_TEST_ASSERTION_PASSED; diff --git a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c index 334bb9edc493..4b054b0ef7d8 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c @@ -372,11 +372,11 @@ BBTestSetInformationFunctionTestCheckpoint1 ( InformationBlockSize1 ); - if (Status == EFI_SUCCESS || Status == EFI_WRITE_PROTECTED) - AssertionType = EFI_TEST_ASSERTION_PASSED; + if (Status == EFI_SUCCESS || Status == EFI_WRITE_PROTECTED || Status == EFI_UNSUPPORTED) + AssertionType = EFI_TEST_ASSERTION_PASSED; else - AssertionType = EFI_TEST_ASSERTION_FAILED; - + AssertionType = EFI_TEST_ASSERTION_FAILED; + StandardLib->RecordAssertion ( StandardLib, AssertionType, -- 2.21.0