Re: [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix variable usage in GetArmNameSpaceObject()

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Joey,

Thank you for this patch. This patch looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


On 01/07/2021 01:24 PM, Joey Gouly wrote:
> Building with Clang showed that `RootComplexCount` and
> `DeviceIdMappingArrayCount` were unused. Use the
> variables where they were intended to be used.
>
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> ---
>
> The changes can be seen at https://github.com/jgouly/edk2-platforms/tree/1766_vexpress_count_v1
>
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> index e99fbb654f5109321e32905af3763233dffdbc3e..776dec999eb1ef47910835987fa4dae1b69c52fd 100644
> --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> @@ -924,7 +924,7 @@ GetArmNameSpaceObject (
>                    CmObjectId,
>                    &PlatformRepo->RootComplexInfo,
>                    sizeof (PlatformRepo->RootComplexInfo),
> -                 1,
> +                 RootComplexCount,
>                    CmObject
>                    );
>         break;
> @@ -935,7 +935,7 @@ GetArmNameSpaceObject (
>                    CmObjectId,
>                    PlatformRepo->DeviceIdMapping,
>                    sizeof (PlatformRepo->DeviceIdMapping),
> -                 ARRAY_SIZE (PlatformRepo->DeviceIdMapping),
> +                 DeviceIdMappingArrayCount,
>                    Token,
>                    GetDeviceIdMappingArray,
>                    CmObject