From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.58]) by mx.groups.io with SMTP id smtpd.web09.9094.1658503250440676343 for ; Fri, 22 Jul 2022 08:20:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=OPvKvdAP; spf=pass (domain: arm.com, ip: 40.107.15.58, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cMA4xD+NINt7OgmLDMNAzz/TyM4GgwvSR5napSMgg4sw6OAS/OUscN3fTqcD57C0gshCOcKkMUq0bFtW3aRnHCLIzfD0Y6I4o0Lw6k0D/328Y31eRbaaqjS7a9YJu8rkjLlImOMoBhO5pb2vKBZR7WwZaheAsGV4xGNX9qxUi81jt6C+/yupBjnK6F3pyXyeUq4PVnFB6hUyECV7Oa6i32rLTc+XDLvuzwEMguq3qhA5oZT8I76qMtIrb/8y5BT9VORUoMuR5XTo31YY+1SIFCvGUyv548K3h8cHiBqv8ZyxDT3OT2Fmn4YaBd04RSUox+10d3gtJ1zNvstM8DZaJg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ynd+kidrlHmrnhoDwckH5oCBcfKfEPe6h+9pUnbj2J8=; b=PYdSvlv78UtRI4JjyD01MNfE3o87L+tR/wfYxNP5hG2D92uIncY16yA+5Ejpe44fEkrs9/CrFf07VziW6T+VZZoZAtESsPRDeUVd7uVVOPqi6Vhg9jKk+8LsO6DkcqOhCc9KUSfYRZ5+mC4zOZEtjWZyKCkDNgoehCDCHo1iuL/EWER01nRadZOXPDBlMduX3CCdpAOwXkN/yxIMGULYmMDb4e+3cVMYH9yZW3ERr2zcfauKzi0RtHcJzSf4NdwQjqLRkT/LBm51C0EeP1kMzO2Pso763Dh9P46Jrw4JpxsifYB1rvBfVLbQk9HUSan3tipVPV4LGx0+oKHPozQBJQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ynd+kidrlHmrnhoDwckH5oCBcfKfEPe6h+9pUnbj2J8=; b=OPvKvdAPf+USg1fUAyQm1hmO9QkdKHfmCXnawCjuFZzFEWGAqh7Uz9hReM259Ugf2LFTwaSeZ90aZMYNZ4sX4XoIin+7OqpPe9pTi3hMoAQ9y29CFP9agO344uwosp5rVebd6qtw1lYy9xnbnSPPqTtEVMJQ39wlKVFpMnFfsDQ= Received: from AS9PR06CA0616.eurprd06.prod.outlook.com (2603:10a6:20b:46e::25) by DB9PR08MB7083.eurprd08.prod.outlook.com (2603:10a6:10:2c3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 15:20:46 +0000 Received: from AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46e:cafe::9) by AS9PR06CA0616.outlook.office365.com (2603:10a6:20b:46e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Fri, 22 Jul 2022 15:20:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT008.mail.protection.outlook.com (10.152.16.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Fri, 22 Jul 2022 15:20:45 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Fri, 22 Jul 2022 15:20:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3260ad3c45ce04b4 X-CR-MTA-TID: 64aa7808 Received: from aade8873a85c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 49A9850B-AE0A-43A2-AB74-C19CA36B1E2B.1; Fri, 22 Jul 2022 15:20:38 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aade8873a85c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Jul 2022 15:20:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9bsDPEDUcSmrVzIv1XSLvlFolan9yzwxuxbYsxuMnH025+1bYaD7OAeK9kVJE21f5SUrV73+tJFpCmIYvfD1D9PtkWWEEJRyC0c0wb+I09nvQZ3vA7pVamfamIOp+mJsL8sePAnVI6wWS7CKFlafwoDJdGcijIFNgX3U2DklXOpdleONxoY0aRYno82aj0IqB43QKFVB97cZ2vRHE5r1mBJB10gaVGkJNpsfPNulvFjBrMrrHlkIrTm3DugBicBQp+G6PZSSAv01Y9yJZsFdKm8Nd9Aiks3F3dOViaodB+qSdA/kmug8781kDzRWZx/+01avMT02YzKn6u8ljTj3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ynd+kidrlHmrnhoDwckH5oCBcfKfEPe6h+9pUnbj2J8=; b=ScvqqpiRQceaDhVVda4dEsnykOiGLdJIaoWyxCIFgV7rcWyZVX/ECFmDSylIDZtlPVe2p2aUyK4qvnupKCsWdX0MxsIv6HxN2Zzw1ubKOZevRzXSHOOKOTD47XoaGONUjZ1EjyTVowEZoqxDlpJ8cvnSwf2C4zor5R1IQ4Tyb8sbCeXBBdmxYm8FvNPsJM0V+MyidnhJF0ycaCjkgrv9116d3BAOwELIcBV/f+WjTTCES5UOv0XdSl0LxmcLeuGRWbwoZ3CjsevFFt5lCsliv9o/dcUDhZ4lPkYLlI2rTqUmGkNg9lphIV+u2mi6i9/YKofeJ8XzCjEjCi/vuyXdtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ynd+kidrlHmrnhoDwckH5oCBcfKfEPe6h+9pUnbj2J8=; b=OPvKvdAPf+USg1fUAyQm1hmO9QkdKHfmCXnawCjuFZzFEWGAqh7Uz9hReM259Ugf2LFTwaSeZ90aZMYNZ4sX4XoIin+7OqpPe9pTi3hMoAQ9y29CFP9agO344uwosp5rVebd6qtw1lYy9xnbnSPPqTtEVMJQ39wlKVFpMnFfsDQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB8PR08MB5097.eurprd08.prod.outlook.com (2603:10a6:10:38::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Fri, 22 Jul 2022 15:20:36 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%4]) with mapi id 15.20.5458.018; Fri, 22 Jul 2022 15:20:36 +0000 Message-ID: Date: Fri, 22 Jul 2022 16:20:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/2] ArmPkg/CpuDxe: drop ARM_PROCESSOR_TABLE pseudo-ACPI table To: Ard Biesheuvel , devel@edk2.groups.io, Ard Biesheuvel Cc: Rebecca Cran , Leif Lindholm , Leif Lindholm , nd@arm.com References: <20211217213403.15585-1-ardb@kernel.org> <20211217213403.15585-3-ardb@kernel.org> From: "Sami Mujawar" In-Reply-To: <20211217213403.15585-3-ardb@kernel.org> X-ClientProxiedBy: LO4P123CA0576.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::23) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 065ff06d-6899-4b76-be7b-08da6bf5c014 X-MS-TrafficTypeDiagnostic: DB8PR08MB5097:EE_|AM5EUR03FT008:EE_|DB9PR08MB7083:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kTMVlHgIjHOx1/gVHrgaLDgifaNNUq3zz3Eyr0KPxsxzyAEDWj2Y33+JtjxzPyp4lOIvJWh2kQYNUa2FvCZ/c5Mtul9CG7+iVLzfe3uRcWr845uFailHn1BWCJtjUS9v5JreBH8x/o1S4ynApnXE/4jRCVwpqzCimV+HTJUnT5iurKcNVb6PE96TlveVD9F/HnKpWYkfdw2XGIzsZJtdz/PFXGN5ztUN9Ze9qv/WzhXH84Jp+OHL92Hml/ZPY3g9v3SjSrH4mAJsYVHpwyr6p1fBfexe2S31shnjwq0zI/VypSf+Zcz83kVGkpDSiyiHMEABDxoza9IK4WQWxBPa16E5/Knrns3buXwYA9rVXQyxpkl5l7RLdCJl9MAIMgUnJ8zni/EkRFEiRr/i4BGPHVU+heu2j7L/F8hYJDe4H6RFJwpEFL2FbNB7qwQ85FyUe5UOPF5FCEFA0l94Xpl0etEsfQatfl/RZdcAqvzCUx6nVjp41vS2K1Fs4mFyM+hTQBltJV4v7sEELZNRPbDqWkuPGuVv3SjDvOtM9B6xT+0rENak52a07hk9/BU/bS1oIU6T1A3sbzCYZDMj8GBAyxR6yhLGUpJKsVyBKm1xakAdSu6eqcXEbbknAFwtcAT08vgapG2zCuI368zlKJHsvyUeVEyVqvVe3/5TAWy5xbwNBtF5X9vWnbf2qYcQvr95JbLK3J7b3TmoKWiFNOS/Ue2jrzcdBnMMB0w1YUSe+VUTbv5W1Z6k+1mpMM0qFXkmBGLTnUzFmrZlE7cQAz3NPAKL0+TNrjSBE5LxqNfUJcDKODEs6P/KDME1Uz2Aegqvht3f8lleiKDozml9YZn5UA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(376002)(136003)(396003)(346002)(316002)(110136005)(54906003)(478600001)(6486002)(38100700002)(83380400001)(66946007)(53546011)(2616005)(6506007)(41300700001)(26005)(6512007)(186003)(31686004)(2906002)(5660300002)(44832011)(66556008)(36756003)(4326008)(8676002)(66476007)(31696002)(86362001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5097 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: da88c28f-c3ed-47fe-3c8d-08da6bf5b9f9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AScc4sThvvDcBDy0radjOAxpLJNdPlaCi+NPz2p3OJuqdVXWtsf99MUfPHEqDtx6s84QiUcOZGNTISmm1MwIsxqSczZExn5uhpYrp3jIftWoNbhCZxTqExHy+3m1SZcabuxmgTaNVzUFlDImEAjJpJQK3Cb0wZE5yb0zLnAMtKFdJzMqfFQqCUZgKhMuPARbh/7GyOy/nbZ7Xu1Mcg8Qhax/ku5nKtL7qn6Iy2luMdq+XFpCkB/4lu6gK5aW57Fb1pIQbnsxYXA2FTHgVUCCBYUp8msQxDdKLWBYocB+txcZH5M8bhbHc0TvF0l0YGaCpvXxIvu00yI7PxRibsb16iKGXeRIl8QHue61NszaAoOEWYFeJ7yCu2rqj60+w0wF30TgYI+m/i4067ycN5f06LN8k+BFF2TZ13p8RjeCSeMkxem1uDQIG5ZIbBY1KhoUqsL+ZyqqW/JQk3Eo7WpYQgpnG3be1qGf/DucT+9xnSLhmZf2XJf/3XlgPDpVxpDOcW/5/5FcRa6nD1R6eiu6dYCYlwYT0SJVx046NPVOXIlAj53FTyYcJoOA99n1wARyNz25C2XcW8MBS9KVJZ8okqydrsYstiHjdWxHeQzCT9QBH/c7yo4NzgnSwzD03RDYpLHyZrCKeQrH3IcCwqFAj20Ac52K4g3ptydyo/HcMyTH4hWwK3NXGYvs7bwAzldGv3TuoPrA+tnEPUvuVYKJlNlROiiZ+Y+WeJto3/mEi2Z+aOGY5TcrYnu0RuKSQrYqaemje2ojM2pkQBGwbZFnxZrAfn9NfNR/UaBNGV3wWUDYGnxOYgXnbJzL1PSrNvR+OWZP6qt3j1DRMHB/VAIxPw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(376002)(396003)(39860400002)(40470700004)(46966006)(36840700001)(47076005)(2616005)(83380400001)(26005)(336012)(186003)(82310400005)(2906002)(6506007)(41300700001)(31686004)(36756003)(40480700001)(6486002)(6512007)(478600001)(53546011)(81166007)(82740400003)(4326008)(36860700001)(31696002)(86362001)(110136005)(44832011)(54906003)(5660300002)(70586007)(316002)(70206006)(8676002)(356005)(8936002)(40460700003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 15:20:45.9252 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 065ff06d-6899-4b76-be7b-08da6bf5c014 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7083 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ard, Thank you for this patch. I have just checked and that patch v2 1/2 from this series is no longer required but this patch v2 2/2 is still applicable. I have applied patch v2 2/2 on latest edk2 master and tested with FVP model and can boot Linux. Reviewed-by: Sami Mujawar Tested-by: Sami Mujawar Regards, Sami Mujawar On 17/12/2021 09:34 pm, Ard Biesheuvel wrote: > The ARM_PROCESSOR_TABLE pseudo-ACPI table (which carries a ACPI-table > like header but is published as a EFI config table) is not described in > any relevant spec, and is not known to be relied upon by any OS. Let's > just get rid of it. > > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Drivers/CpuDxe/CpuDxe.inf | 1 - > ArmPkg/Drivers/CpuDxe/CpuDxe.h | 15 --- > ArmPkg/Include/Guid/ArmMpCoreInfo.h | 27 ------ > ArmPkg/Drivers/CpuDxe/CpuDxe.c | 6 -- > ArmPkg/Drivers/CpuDxe/CpuMpCore.c | 98 -------------------- > 5 files changed, 147 deletions(-) > > diff --git a/ArmPkg/Drivers/CpuDxe/CpuDxe.inf b/ArmPkg/Drivers/CpuDxe/CpuDxe.inf > index f4cdb8ab5613..4eda960ede36 100644 > --- a/ArmPkg/Drivers/CpuDxe/CpuDxe.inf > +++ b/ArmPkg/Drivers/CpuDxe/CpuDxe.inf > @@ -21,7 +21,6 @@ [Defines] > [Sources.Common] > > CpuDxe.c > > CpuDxe.h > > - CpuMpCore.c > > CpuMmuCommon.c > > Exception.c > > > > diff --git a/ArmPkg/Drivers/CpuDxe/CpuDxe.h b/ArmPkg/Drivers/CpuDxe/CpuDxe.h > index 3f04b89d7ad0..7858c12aea55 100644 > --- a/ArmPkg/Drivers/CpuDxe/CpuDxe.h > +++ b/ArmPkg/Drivers/CpuDxe/CpuDxe.h > @@ -104,21 +104,6 @@ SyncCacheConfig ( > IN EFI_CPU_ARCH_PROTOCOL *CpuProtocol > > ); > > > > -/** > > - * Publish ARM Processor Data table in UEFI SYSTEM Table. > > - * @param HobStart Pointer to the beginning of the HOB List from PEI. > > - * > > - * Description : This function iterates through HOB list and finds ARM processor Table Entry HOB. > > - * If the ARM processor Table Entry HOB is found, the HOB data is copied to run-time memory > > - * and a pointer is assigned to it in ARM processor table. Then the ARM processor table is > > - * installed in EFI configuration table. > > -**/ > > -VOID > > -EFIAPI > > -PublishArmProcessorTable ( > > - VOID > > - ); > > - > > // The ARM Attributes might be defined on 64-bit (case of the long format description table) > > UINT64 > > EfiAttributeToArmAttribute ( > > diff --git a/ArmPkg/Include/Guid/ArmMpCoreInfo.h b/ArmPkg/Include/Guid/ArmMpCoreInfo.h > index 43f0848e78b8..3a10fffb6fe4 100644 > --- a/ArmPkg/Include/Guid/ArmMpCoreInfo.h > +++ b/ArmPkg/Include/Guid/ArmMpCoreInfo.h > @@ -23,36 +23,9 @@ typedef struct { > UINT64 MailboxClearValue; > > } ARM_CORE_INFO; > > > > -typedef struct { > > - UINT64 Signature; > > - UINT32 Length; > > - UINT32 Revision; > > - UINT64 OemId; > > - UINT64 OemTableId; > > - UINTN OemRevision; > > - UINTN CreatorId; > > - UINTN CreatorRevision; > > - EFI_GUID Identifier; > > - UINTN DataLen; > > -} ARM_PROCESSOR_TABLE_HEADER; > > - > > -typedef struct { > > - ARM_PROCESSOR_TABLE_HEADER Header; > > - UINTN NumberOfEntries; > > - ARM_CORE_INFO *ArmCpus; > > -} ARM_PROCESSOR_TABLE; > > - > > #define ARM_MP_CORE_INFO_GUID \ > > { 0xa4ee0728, 0xe5d7, 0x4ac5, {0xb2, 0x1e, 0x65, 0x8e, 0xd8, 0x57, 0xe8, 0x34} } > > > > -#define EFI_ARM_PROCESSOR_TABLE_SIGNATURE SIGNATURE_64 ('C', 'P', 'U', 'T', 'A', 'B', 'L', 'E') > > -#define EFI_ARM_PROCESSOR_TABLE_REVISION 0x00010000// 1.0 > > -#define EFI_ARM_PROCESSOR_TABLE_OEM_ID SIGNATURE_64('A','R','M',' ', 'L', 't', 'd', ' ') > > -#define EFI_ARM_PROCESSOR_TABLE_OEM_TABLE_ID SIGNATURE_64('V', 'E', 'R', 'S', 'A', 'T', 'I', 'L') > > -#define EFI_ARM_PROCESSOR_TABLE_OEM_REVISION 0x00000001 > > -#define EFI_ARM_PROCESSOR_TABLE_CREATOR_ID 0xA5A5A5A5 > > -#define EFI_ARM_PROCESSOR_TABLE_CREATOR_REVISION 0x01000001 > > - > > extern EFI_GUID gArmMpCoreInfoGuid; > > > > #endif /* ARM_MP_CORE_INFO_GUID_H_ */ > > diff --git a/ArmPkg/Drivers/CpuDxe/CpuDxe.c b/ArmPkg/Drivers/CpuDxe/CpuDxe.c > index 6c076982a1bd..1ee7c9237a3a 100644 > --- a/ArmPkg/Drivers/CpuDxe/CpuDxe.c > +++ b/ArmPkg/Drivers/CpuDxe/CpuDxe.c > @@ -256,12 +256,6 @@ CpuDxeInitialize ( > SyncCacheConfig (&mCpu); > > mIsFlushingGCD = FALSE; > > > > - // If the platform is a MPCore system then install the Configuration Table describing the > > - // secondary core states > > - if (ArmIsMpCore ()) { > > - PublishArmProcessorTable (); > > - } > > - > > // > > // Setup a callback for idle events > > // > > diff --git a/ArmPkg/Drivers/CpuDxe/CpuMpCore.c b/ArmPkg/Drivers/CpuDxe/CpuMpCore.c > deleted file mode 100644 > index 08de46464515..000000000000 > --- a/ArmPkg/Drivers/CpuDxe/CpuMpCore.c > +++ /dev/null > @@ -1,98 +0,0 @@ > -/** @file > > -* > > -* Copyright (c) 2011-2021, Arm Limited. All rights reserved.
> > -* > > -* SPDX-License-Identifier: BSD-2-Clause-Patent > > -* > > -**/ > > - > > -#include > > -#include > > -#include > > -#include > > -#include > > - > > -#include > > - > > -ARM_PROCESSOR_TABLE mArmProcessorTableTemplate = { > > - { > > - EFI_ARM_PROCESSOR_TABLE_SIGNATURE, > > - 0, > > - EFI_ARM_PROCESSOR_TABLE_REVISION, > > - EFI_ARM_PROCESSOR_TABLE_OEM_ID, > > - EFI_ARM_PROCESSOR_TABLE_OEM_TABLE_ID, > > - EFI_ARM_PROCESSOR_TABLE_OEM_REVISION, > > - EFI_ARM_PROCESSOR_TABLE_CREATOR_ID, > > - EFI_ARM_PROCESSOR_TABLE_CREATOR_REVISION, > > - { 0 }, > > - 0 > > - }, // ARM Processor table header > > - 0, // Number of entries in ARM processor Table > > - NULL // ARM Processor Table > > -}; > > - > > -/** Publish ARM Processor Data table in UEFI SYSTEM Table. > > - * @param HobStart Pointer to the beginning of the HOB List from PEI. > > - * > > - * Description : This function iterates through HOB list and finds ARM processor Table Entry HOB. > > - * If the ARM processor Table Entry HOB is found, the HOB data is copied to run-time memory > > - * and a pointer is assigned to it in ARM processor table. Then the ARM processor table is > > - * installed in EFI configuration table. > > -**/ > > -VOID > > -EFIAPI > > -PublishArmProcessorTable ( > > - VOID > > - ) > > -{ > > - EFI_PEI_HOB_POINTERS Hob; > > - > > - Hob.Raw = GetHobList (); > > - > > - // Iterate through the HOBs and find if there is ARM PROCESSOR ENTRY HOB > > - for ( ; !END_OF_HOB_LIST (Hob); Hob.Raw = GET_NEXT_HOB (Hob)) { > > - // Check for Correct HOB type > > - if ((GET_HOB_TYPE (Hob)) == EFI_HOB_TYPE_GUID_EXTENSION) { > > - // Check for correct GUID type > > - if (CompareGuid (&(Hob.Guid->Name), &gArmMpCoreInfoGuid)) { > > - ARM_PROCESSOR_TABLE *ArmProcessorTable; > > - EFI_STATUS Status; > > - > > - // Allocate Runtime memory for ARM processor table > > - ArmProcessorTable = (ARM_PROCESSOR_TABLE *)AllocateRuntimePool (sizeof (ARM_PROCESSOR_TABLE)); > > - > > - // Check if the memory allocation is successful or not > > - ASSERT (NULL != ArmProcessorTable); > > - > > - // Set ARM processor table to default values > > - CopyMem (ArmProcessorTable, &mArmProcessorTableTemplate, sizeof (ARM_PROCESSOR_TABLE)); > > - > > - // Fill in Length fields of ARM processor table > > - ArmProcessorTable->Header.Length = sizeof (ARM_PROCESSOR_TABLE); > > - ArmProcessorTable->Header.DataLen = GET_GUID_HOB_DATA_SIZE (Hob); > > - > > - // Fill in Identifier(ARM processor table GUID) > > - ArmProcessorTable->Header.Identifier = gArmMpCoreInfoGuid; > > - > > - // Set Number of ARM core entries in the Table > > - ArmProcessorTable->NumberOfEntries = GET_GUID_HOB_DATA_SIZE (Hob)/sizeof (ARM_CORE_INFO); > > - > > - // Allocate runtime memory for ARM processor Table entries > > - ArmProcessorTable->ArmCpus = (ARM_CORE_INFO *)AllocateRuntimePool ( > > - ArmProcessorTable->NumberOfEntries * sizeof (ARM_CORE_INFO) > > - ); > > - > > - // Check if the memory allocation is successful or not > > - ASSERT (NULL != ArmProcessorTable->ArmCpus); > > - > > - // Copy ARM Processor Table data from HOB list to newly allocated memory > > - CopyMem (ArmProcessorTable->ArmCpus, GET_GUID_HOB_DATA (Hob), ArmProcessorTable->Header.DataLen); > > - > > - // Install the ARM Processor table into EFI system configuration table > > - Status = gBS->InstallConfigurationTable (&gArmMpCoreInfoGuid, ArmProcessorTable); > > - > > - ASSERT_EFI_ERROR (Status); > > - } > > - } > > - } > > -} >