Re: [edk2-platforms] [PATCH v3] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 10/6/20 2:59 PM, Vijayenthiran Subramaniam wrote:
> Commit e8fe2026dd79 (“Platform/ARM/SgiPkg: Use chip count constant on
> rdn1edgex2 platform”) used the PcdChipCount constant but did not declare
> its use in the ACPI table module. Fix this by listing it in the list of
> PCDs to be looked up.
> 
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>

Could you please collect the acks/r-bs you received and repost?

> ---
> 
> Changes since v2:
>    - Rebased to latest master and repost.
> 
> Changes since v1:
>    - Add commit id in commit message for which this patch fixes the build
>      failure.
> 
>   Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
>     gArmSgiTokenSpaceGuid.PcdDramBlock2Base
>     gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>   
> +  gArmSgiTokenSpaceGuid.PcdChipCount
> +
>     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
>     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
>     gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
>