From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.13833.1601990161201043942 for ; Tue, 06 Oct 2020 06:16:01 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BCAC1143D; Tue, 6 Oct 2020 06:16:00 -0700 (PDT) Received: from [192.168.1.81] (unknown [10.37.8.98]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4A5783F71F; Tue, 6 Oct 2020 06:15:59 -0700 (PDT) Subject: Re: [edk2-platforms] [PATCH v3] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount To: Vijayenthiran Subramaniam , devel@edk2.groups.io, leif@nuviainc.com, thomas.abraham@arm.com Cc: Sami.Mujawar@arm.com, Aditya.Angadi@arm.com References: <1601989155-30186-1-git-send-email-vijayenthiran.subramaniam@arm.com> From: "Ard Biesheuvel" Message-ID: Date: Tue, 6 Oct 2020 15:15:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1601989155-30186-1-git-send-email-vijayenthiran.subramaniam@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/6/20 2:59 PM, Vijayenthiran Subramaniam wrote: > Commit e8fe2026dd79 (=E2=80=9CPlatform/ARM/SgiPkg: Use chip count const= ant on > rdn1edgex2 platform=E2=80=9D) used the PcdChipCount constant but did no= t declare > its use in the ACPI table module. Fix this by listing it in the list of > PCDs to be looked up. >=20 > Signed-off-by: Vijayenthiran Subramaniam Could you please collect the acks/r-bs you received and repost? > --- >=20 > Changes since v2: > - Rebased to latest master and repost. >=20 > Changes since v1: > - Add commit id in commit message for which this patch fixes the bui= ld > failure. >=20 > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/= Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > index 974d9db543..d44f02ab0c 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > @@ -45,6 +45,8 @@ > gArmSgiTokenSpaceGuid.PcdDramBlock2Base > gArmSgiTokenSpaceGuid.PcdDramBlock2Size > =20 > + gArmSgiTokenSpaceGuid.PcdChipCount > + > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum > gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum >=20