From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.43]) by mx.groups.io with SMTP id smtpd.web08.31807.1650902775953316477 for ; Mon, 25 Apr 2022 09:06:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=hUqMlsXI; spf=pass (domain: arm.com, ip: 40.107.8.43, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KIiSYynbddQ1h4bYr22q2CzTvZ3SPuCTiAxtueQXVEw=; b=hUqMlsXIUrmgDIiR3xhZeR/tI/Vg4KKfeelFthNYK4BT8Kk+ybkFD9bfS4dVkEB25gwX4FeJlOWEGgWOpjArw2snrXdeFi4htwDuQB9gWluuJ0oYE1EB9MsSp4ffDke7Y1nVtYyD6NruHGajhK23vk4NGwqjGYEds5y/IAXJ9KQ= Received: from DBBPR09CA0003.eurprd09.prod.outlook.com (2603:10a6:10:c0::15) by DB8PR08MB4156.eurprd08.prod.outlook.com (2603:10a6:10:ae::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Mon, 25 Apr 2022 16:06:11 +0000 Received: from DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::c2) by DBBPR09CA0003.outlook.office365.com (2603:10a6:10:c0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Mon, 25 Apr 2022 16:06:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT019.mail.protection.outlook.com (10.152.20.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Mon, 25 Apr 2022 16:06:11 +0000 Received: ("Tessian outbound ac9bb5dd84f6:v118"); Mon, 25 Apr 2022 16:06:11 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 88a1e7e58ee30676 X-CR-MTA-TID: 64aa7808 Received: from faa0526fa6d9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 728FE447-FF4E-4BC6-B307-D2C677D2E8F2.1; Mon, 25 Apr 2022 16:06:04 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id faa0526fa6d9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 25 Apr 2022 16:06:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oc4htrHaq2g1ghoLSPZuFWbG4FNmkXjbHxkMhCObSP7xHBC/HCvcdBrhFSpnAodt4ePTscRAAsvWUiHuTUERZt6UF8CR65KOm/wdDjex7a8fEiSDuMZZpTXhQ3Gjx2S+HA19UQfwubW/r9xKcz3FolnXqlDi4Fdj8J7lR631NwqXJ4/AjUaNu3P+qmbuAtzCxtYa+GhCdFXiLcvhWG+KPYPXPQFKkWhQIukA9UHCe70J7kBvcr2G6vrA+KBZJlj9yRKiL/yRxsDsBrJcDNrqZeuuhq+c/bedYjrz/UAq7oPkZ2uhtdMQ+irgCy+DABvArdYaprMfkqmW+sPkk0yN2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KIiSYynbddQ1h4bYr22q2CzTvZ3SPuCTiAxtueQXVEw=; b=a3jNe0TeXXK4BPJfyeA8fUWoN5pxmG+1NjM5MaHulM1Gyiqxo3kLN+++FmGDtanFGrYi7ZzBsuUltV+7tDwwms1bMRYPIDG4YZtATNFZhjggu17AFlPM+Y3qw4IKwbxnXeDFA2DiKTwW52WZBx2lBnxH9NsmX3e+AW9hgfExxO5VOn2EFkan7B4AidHUQUcTgyTfEUwZgwhE77iSCCwRBIh/fFiU24RLACJiFZKOLIdKr1sVXD/4cPe855lpZFOffTVqUgOymUqh93pHQnRefggldk6KNVNS7hNlOqfcDeL1Mv4OBixc9wcKnbsBDDuia1ny6tJ0eLN8O2W7XoVo1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KIiSYynbddQ1h4bYr22q2CzTvZ3SPuCTiAxtueQXVEw=; b=hUqMlsXIUrmgDIiR3xhZeR/tI/Vg4KKfeelFthNYK4BT8Kk+ybkFD9bfS4dVkEB25gwX4FeJlOWEGgWOpjArw2snrXdeFi4htwDuQB9gWluuJ0oYE1EB9MsSp4ffDke7Y1nVtYyD6NruHGajhK23vk4NGwqjGYEds5y/IAXJ9KQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6693.eurprd08.prod.outlook.com (2603:10a6:20b:39c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Mon, 25 Apr 2022 16:06:02 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::fd9a:40d3:976a:5a95]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::fd9a:40d3:976a:5a95%4]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022 16:06:02 +0000 Message-ID: Date: Mon, 25 Apr 2022 17:06:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 5/8] ArmVirtPkg/ArmVirt.dsc.inc: Add VariableFlashInfoLib To: mikuback@linux.microsoft.com, devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Gerd Hoffmann , Julien Grall , nd@arm.com References: <20220412162940.4978-1-mikuback@linux.microsoft.com> <20220412162940.4978-6-mikuback@linux.microsoft.com> From: "Sami Mujawar" In-Reply-To: <20220412162940.4978-6-mikuback@linux.microsoft.com> X-ClientProxiedBy: LO2P265CA0244.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::16) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 292845a5-2bd9-453b-e639-08da26d5845a X-MS-TrafficTypeDiagnostic: AS8PR08MB6693:EE_|DB5EUR03FT019:EE_|DB8PR08MB4156:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ateHtHcY8szMNgIAXI0PAyQ5rM3vOSCPbQbuGH7HxE0kb8+G7hKPmarMmTCVksArgsbW+9kP3awVFHDNrLXLZdW37xVACesoRqKneME4AUPrYvk1YheHDK0IY323x4d8P7uoNHc0hs2hbEfxdIcaj46n/f/nFKIstxgJM3/ovl16d/TtpUd/9oQjQCtbExnASQ09Fsj5b67is7rMVfJGgkfMiSVOYuMI8JfiDE75OuURKg/lP2nBSrIzoVuiWZljP4VPjz/V+b0ucDZmqIOAZFEbfrdM594Pxv46g4QOi7wLDuJwgmwdqHJ7GvlVyyWHJC6/QGM405dZDZ/8YBxwbrULLtaA9mw/4oYfLkckPuanCUdDLfEXpkomGurh1Lp1fXQqhjjCoXfKBc/wC0vBMgV9J3tV54gOOXDvTunvrszxbI+LphfSAdraxJkwDcf0v8KAA1gFeO/EtKe3eaZNNBuRvGquT+W159D/KrdGj6nA7x9r8YcKlx62J2LZYpSn3MCLHwM+3QmLWWhnmNHpeBddTPDwYkaPkTjDSUE772JjG2uYfGU0kabJoh/1lbt4aHouSJc6Dh7FFvw6i2ULlQtfKs+MeXByAUbOX4r7nfDMJvd4vQMBrGXulw8ygoitouh6gluQE4ZeM0s6p/w0MNrgXv+bZDd42UYv4g1PsrqeLUlV0nZyYFqkTnPLgTdQ4SfwGsneNR09K3bBoFZUXD9BYzFZAlHl81kmSSAR06/NGFiVIiLsWEvi7dBBo+Eom+o1659osgmt1PaC2T6uvcIrdVVeWr5C2LrB2xQkyUFihKj5NVp3j7CHU23ykr8A X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(45080400002)(36756003)(5660300002)(316002)(53546011)(31686004)(6506007)(26005)(8676002)(2906002)(508600001)(54906003)(6512007)(44832011)(2616005)(4326008)(66946007)(66556008)(66476007)(31696002)(86362001)(38100700002)(8936002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6693 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d84f76a7-6103-4078-0aed-08da26d57e86 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nb7eob+QnerrdZBNchc0Sqe755T8weAOE6bfZbcCEZx11p/iuGsyBu0/M1/UE7Vo4r9PTh4qBh2mIuksONPktU/xSoTqpXFZPYZt95uvRS6IoWY8igKOQhG9PaPG420R02G6MVEsZIsxXtNhSaQGaZ1/8os1OY9vkRt3b48SwCPfX1jh4mnyrPRgtfFKY2dIwVIoU5Z3ofoFVU6PRfN4f2MB/Wf4rMjIqk+tuwL9GWFMPzWWG055wOeq0korSO0MmE8UdxhGvzdHoXY6f00aIwv0rsI1vbO3mg2U+fAeI9348HAaxZGuPGJw6pN0cU2p7dwRz+mMnVybR17W60I+SSfg+TLBVTL03FjZsCRBjTVcd8xwBcA6w1HbGCqR0VlMZzwmggrzH0dyPvDWHIy96q5otHhY1PxeQOE4lOVsnMEVqftFj9hr3wZsVb7EeSn4gUT4/3XlBSbrVhxwGzsltG1MOEogApnlokaru3L2jwG007rF8/BFD4fk8/828F8m2nVkjd3rcAfIn7COKSLBu9EP2YDnguCzX5vi1Qsg2y0zsM5AoKsSxDUr5LMgAazt7tskeCrIpIpmMic1Bm6ojCws+NoYzHihz297i4iYT8t3NDom+12ZPScyNHTFQYk62ED8UTh4qKpq2jKPCME7hLPtdsdTkznN+05kKO7Vzs3yTz4/ANqmRJWffZJq0GpyTWkFD3Wwmt/bco1n4BCJ4AHhv1V1RXqY/oFfUn+yA8VkXnQNMDJ0LlhHqe5gU2uLJLDqqULPQOg2FbxTRfsvA9W7K8Gc0trASiN9lQD1Zcw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(186003)(81166007)(356005)(86362001)(508600001)(47076005)(53546011)(336012)(31686004)(36756003)(5660300002)(8936002)(2906002)(44832011)(6506007)(26005)(54906003)(31696002)(4326008)(2616005)(8676002)(6512007)(70206006)(70586007)(36860700001)(40460700003)(316002)(45080400002)(82310400005)(6486002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 16:06:11.6629 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 292845a5-2bd9-453b-e639-08da26d5845a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4156 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michael, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 12/04/2022 05:29 pm, mikuback@linux.microsoft.com wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 > > Adds an instance of VariableFlashInfoLib to the platform build as > it is a new library class introduced in MdeModulePkg. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Cc: Julien Grall > Signed-off-by: Michael Kubacki > --- > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index ba711deac025..988c1eb75529 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -177,6 +177,7 @@ [LibraryClasses.common] > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > !endif > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf