Re: [PATCH v2 2/2] ArmVirtPkg: allow setting Firmware Version from build command line

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Oliver,

Thank you for the updated patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 14/10/2022 01:34 pm, Oliver Steffen wrote:
> ArmVirtXen.dsc initializes
> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
> with with the value of the variable "FIRMWARE_VER".
>
> Move that functionality to ArmVirt.dsc.inc to make it available
> to all ArmVirt packages, and make it conditional: only set the
> PCD string if FIRMWARE_VER is actually defined.
>
> This allows specifying the firmware version string on the
> build command line with -D FIRMARE_VER=...
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>   ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++
>   ArmVirtPkg/ArmVirtXen.dsc  | 1 -
>   2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index c39e2506a3ea..49e96c9fb91c 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -289,6 +289,10 @@ [PcdsFeatureFlag.AARCH64]
>     gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE
>
>   [PcdsFixedAtBuild.common]
> +!ifdef $(FIRMWARE_VER)
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)"
> +!endif
> +
>     gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000
>     gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000
>     gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0
> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
> index 58088af6ea3a..a280ae203bae 100644
> --- a/ArmVirtPkg/ArmVirtXen.dsc
> +++ b/ArmVirtPkg/ArmVirtXen.dsc
> @@ -69,7 +69,6 @@ [BuildOptions]
>   ################################################################################
>
>   [PcdsFixedAtBuild.common]
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)"
>   !if $(ARCH) == AARCH64
>     gArmTokenSpaceGuid.PcdVFPEnabled|1
>   !endif