From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.85]) by mx.groups.io with SMTP id smtpd.web12.7032.1665753934133629228 for ; Fri, 14 Oct 2022 06:25:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=9gM2IT58; spf=pass (domain: arm.com, ip: 40.107.22.85, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=M+YbB9PdLnIE+ie8kWpWpr5SEMuLWvezaVGcmTasmlTqTaSQBe0tvWumtrPb0GQFjJH97voFoAmE7W4sAQazgyEjcmyHlf+FVZv/gI7zZu87L7k/njpyJjBT+2BHI0ozPicDaNnDBOfH6IB/RZbHWwMPBNEadUkFvudukBT+GHWl2QF49unc5DtqYIGCzKqt2fg3gWWW/sOOiNBYOhpTKkSNkYh0ZnpmfkBlb1Dny/87kjdDT5VGzRC7Yso+uqI4lkFb6leI8mL4ebVkJpa8nHJks/hK0ikJI+HZNJXGOGA8VhpGExrV8yr5e6fcSyHQ2ZW1+pjy4lyIcIcetvomig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YdRMC7gol170EwOzlLsbXd2K63LJy1FECiFdTSd68dU=; b=HoYSjiQBXr/NZ9pnHuAxPZbuFDg3agi/Jh6NaDhxXGJHFC8/mPu+rMkHuwwgbDBBVEhPqUhqGmwvWxPXt4mlfdJgpFSje9bPMk+JZ/Sm1tNMk159g/uQlvnC7vhzBkI+zGrR2czOtk7gDBkgCsSn/y2fTIsEL86MDpvgnpquiXowl1RRtRcyBtymzTtiXJ4JMdpKQ6KU99prx9634j9hggpfMAIziEuO852tSHRZy/Z1r5JhUEH/oe4cT8Q17D60b37tc3MNE6M0N9NNf4T8WPCUuF6FwffViza6MEE2Nos3DL30Hv4qYbhFp9rcTUGWrpU3mAjVpctFTAYTVcfqDg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YdRMC7gol170EwOzlLsbXd2K63LJy1FECiFdTSd68dU=; b=9gM2IT58Dqh4Yn6Z1Rwmwa/xIYQ8ocXh0Ij1Axg3CZh8+Le+XVotBfKjnJ4dYi2zUvK2ilZKTfu7hNgAS879yV46XwFCV6HqDyskXaU2O6ouj72eYMcHZCxglv/rScVQ/lsbL6GLC/7mOR5BiSc4TK+/jCMseht6OcUUbUdwtGo= Received: from AM5PR0601CA0034.eurprd06.prod.outlook.com (2603:10a6:203:68::20) by DB3PR08MB9134.eurprd08.prod.outlook.com (2603:10a6:10:42b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct 2022 13:25:28 +0000 Received: from AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::5) by AM5PR0601CA0034.outlook.office365.com (2603:10a6:203:68::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend Transport; Fri, 14 Oct 2022 13:25:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT040.mail.protection.outlook.com (100.127.140.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 13:25:27 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Fri, 14 Oct 2022 13:25:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 47ebf25affb81a0a X-CR-MTA-TID: 64aa7808 Received: from 23c97f2306a0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 68FDC4F7-EA25-4E65-8B34-BDF17E12C70F.1; Fri, 14 Oct 2022 13:25:19 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 23c97f2306a0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Oct 2022 13:25:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jOMy2FK8WPEVOA2RX/3e7hyBPcmPv0f/DHs+7sMi7Nn3XDx6Jzt5TCW7wrabi/ryZ9KqwWyiDeFv5rgEmYkt52i4dGuZAoNIsomJ4aaUd2hG+D3q4itc4g7994e8o4KCIFnbtgy+qqQdVGQrzVvgLddgTVGABx3didVaoZhTt44aFQccHXTUeAl/wc/eunu0sLc9LQH+dp1cGf1F/DY8oxrK3OAmZo5p0ls42rp8t7LT8k0zNfRKXN5aC2th86Jr6lKOyX6kOaxQhSb8teqPwI1INrIlf3TfGfdQLhIkqAlDoLlnsLZdOwVnJfUNe4PwfVUy/8e++BUaZLudqMAu+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YdRMC7gol170EwOzlLsbXd2K63LJy1FECiFdTSd68dU=; b=Q+HgYAVtUXd42n9PWoWc3WJXVBsqwKPYJee5koBb+W/hkM20r6DC481v6lXIAWYrQ+qK/4bO0+TiB4uv1T88udMKLF+jYTJQ0evZoCMmv3W0GXkzETtPZpaNl0oW3L0dhT/UiGMI79+cub3O49e91LNPBSbiL6CisufXLFLmoep2wivD9Kd0OC+znvrOIll6A8QyYVOs+/wl3pWNvJvouOQx+txZhbTEjfUgJCi549a4O4zmwQXb1JgBQi2bTdE2Afjhdz52ZaADQj1PvCxYT/o8PZVPR+bzqQY2uI3X7DP0zydAu+PLa840OzjtqtSr0D+S+CxcXsiWP+kpEnfGbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YdRMC7gol170EwOzlLsbXd2K63LJy1FECiFdTSd68dU=; b=9gM2IT58Dqh4Yn6Z1Rwmwa/xIYQ8ocXh0Ij1Axg3CZh8+Le+XVotBfKjnJ4dYi2zUvK2ilZKTfu7hNgAS879yV46XwFCV6HqDyskXaU2O6ouj72eYMcHZCxglv/rScVQ/lsbL6GLC/7mOR5BiSc4TK+/jCMseht6OcUUbUdwtGo= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DBAPR08MB5558.eurprd08.prod.outlook.com (2603:10a6:10:1b3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct 2022 13:25:16 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5723.029; Fri, 14 Oct 2022 13:25:16 +0000 Message-ID: Date: Fri, 14 Oct 2022 14:25:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2 2/2] ArmVirtPkg: allow setting Firmware Version from build command line To: Oliver Steffen , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Gerd Hoffmann , Jian J Wang , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Liming Gao , Ray Ni , Zhichao Gao , Pawel Polawski , nd@arm.com References: <20221014123408.302491-1-osteffen@redhat.com> From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO2P265CA0270.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DBAPR08MB5558:EE_|AM7EUR03FT040:EE_|DB3PR08MB9134:EE_ X-MS-Office365-Filtering-Correlation-Id: 63bd90f8-e8bb-4b05-587e-08daade78f2f x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +cAY1NCyU5oLV+3IChpYUnZhB/kFnV34nejWR1rqw8nJtCUg3gg6/1xQInmmrP+ItHyN4ZkzRNKC9qTNDLIpAQv+PVY2yDiaWDera2mQ2SeQmCZn/N/JNxVBgAFlArFSVIdWtFRdfN3AVRHbARRzx8Pw28B1vOPeo3v+TXNzUVhW2H271BvAS7BH7KlimJn124YPE0ZXK/4hhMsuK+idplMZtJXdRVZZfce9cg+CtttMHFI6ti1ETew8vRMQNDPlcVJ1KE4NF77mvl4cHqQoMOPsjnkLAkNe2KRaCWh6J7wQUgUfSL0snXWgH+mzjzE87gHdAVWchrHCzH8UZ1M9EFb1ud+ooH4N4EMZm3EnyEd+4VE+xSnPKgTbmWl2Vcz2eH0hPDB//LLnp5U3KeRc5vRjtVo9k9TiFLQP7jWyFfoE+jY7SMZS5h/As6ANt3KwV+P0zWuli+dG9mK2HZ/AJ3BO67Jz+sBcqCivI7OyToOAAeLygzVVBqACu3AzKJY2J6nSPf/5QKiyTZQChprPJE5AO48bIPGarTNjVEp4GNsFypXr/rXgOoKE1e86DVfJn2peCceMtfpEGaFZPnfTIQ83Y37hjKiG5gHpNesUp31yUJIZvhweG5Gu7gY0Fe2SXOLRBLB6VdZiCX5ELVoRxpC3Cgp7oHfo8EVK7fkNpV4x2ce+ue8A1x1qx2fAZHo5EyQCC+QR3gfy9yq4VAupUCara0la4m+SHGPFmFuY5CCdpDFoe1V7eb8YqE40f9c6tOCi/fSjvjW0Wxx83maG0oYi6wDAmfJEXrGQ8xi/Ai4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(451199015)(31686004)(6486002)(316002)(478600001)(54906003)(66946007)(186003)(44832011)(4326008)(38100700002)(8676002)(6666004)(66476007)(66556008)(5660300002)(53546011)(6506007)(6512007)(26005)(31696002)(41300700001)(36756003)(8936002)(7416002)(2616005)(2906002)(86362001)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5558 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2355869d-99c3-4ada-e716-08daade7881a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P8cbgB10k1PvTex+rTgqRWq68DG5E5NkFSYO1FfcXBuQuBAP/pEslHAXcNw5k6br60bPXLT2O/3GCevOsusXChB2BepWPb20SF+DOK2dggFbcVLx4LTGZH+OLy/S2yOARElVoOXFi1IW38IqUI7bX8fVkhhbpSNdrOXpkCWQ9LqAZdaQPTmvPiDWQLjfe4flfIVvwA+mb8AVPq1fgGPsE4lGPlUr9nBdiGSSvF94nHdFLGqBB3WTYnnodr1V2o9WvEyMxAHVuy0zMpKhj4MI6Vf15lDfiPE8QoJ+j7xw5n2efMRZ7BGHyCDZ4sJSWKYanQTmQkcL6bVM3+iafwMo+prdJrL1hD+ceb8t3oMM8ZyfVrcXYDGDzdZYwoLq3n2cVrSAei/3iq6Mr0kjoWfx4FSQRrC8wNhYhVZ4oysnzYa1i6kvSBRJ5ifXMU446BXUbuujR3pbdwrQDoPGiL+W/NMkfQdeE9cM8+b/PJJKttryoS5VqSc5oe+MGI8nnYr1xUkjBZdghALeGHvWzd51hj7QI9tCRljaGdC3I1YlQbkLAmXE+eUGoSHouJ+7xQg7XUxuRBBytEkw8Ekfb2zLGg4Mh9vWe3azVHy0dMMWzvBrvvOwLpFGl7Z/Kzx7uXcu1/h3yqBhJrvqyX73tk65//MKJJd5FYIh7y7Kok2+ahvh3FYGve292ILm7ZKwmy5HHPNGoReM/azgsSqmhyic+TP7cIH0GjrdnGOwKETrCE1XXZTTvK4P+X6bEaq3NpCQB09gqZIUFW3WVADQ7wYcr2FGjmbfudI8SxvaEHp+VW21R/Ty2+dZRFsTGMUOtoro X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199015)(36840700001)(46966006)(40470700004)(40460700003)(36860700001)(186003)(6506007)(41300700001)(316002)(6666004)(8936002)(53546011)(2906002)(36756003)(336012)(47076005)(6486002)(54906003)(83380400001)(70206006)(8676002)(31686004)(356005)(5660300002)(70586007)(86362001)(31696002)(2616005)(4326008)(6512007)(82740400003)(44832011)(26005)(40480700001)(82310400005)(81166007)(478600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 13:25:27.6860 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63bd90f8-e8bb-4b05-587e-08daade78f2f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB9134 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Oliver, Thank you for the updated patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 14/10/2022 01:34 pm, Oliver Steffen wrote: > ArmVirtXen.dsc initializes > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > with with the value of the variable "FIRMWARE_VER". > > Move that functionality to ArmVirt.dsc.inc to make it available > to all ArmVirt packages, and make it conditional: only set the > PCD string if FIRMWARE_VER is actually defined. > > This allows specifying the firmware version string on the > build command line with -D FIRMARE_VER=... > > Signed-off-by: Oliver Steffen > --- > ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++ > ArmVirtPkg/ArmVirtXen.dsc | 1 - > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index c39e2506a3ea..49e96c9fb91c 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -289,6 +289,10 @@ [PcdsFeatureFlag.AARCH64] > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > > [PcdsFixedAtBuild.common] > +!ifdef $(FIRMWARE_VER) > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > +!endif > + > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0 > diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc > index 58088af6ea3a..a280ae203bae 100644 > --- a/ArmVirtPkg/ArmVirtXen.dsc > +++ b/ArmVirtPkg/ArmVirtXen.dsc > @@ -69,7 +69,6 @@ [BuildOptions] > ################################################################################ > > [PcdsFixedAtBuild.common] > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > !if $(ARCH) == AARCH64 > gArmTokenSpaceGuid.PcdVFPEnabled|1 > !endif