From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 29B2B2098EA77 for ; Thu, 19 Jul 2018 11:32:52 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 21080402B032; Thu, 19 Jul 2018 18:32:51 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-95.rdu2.redhat.com [10.10.120.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id CCA7D2156897; Thu, 19 Jul 2018 18:32:49 +0000 (UTC) To: Anthony PERARD , edk2-devel@lists.01.org Cc: Eric Dong , "Gao, Liming" , Dandan Bi References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2BDD0B@SHSMSX104.ccr.corp.intel.com> <20180719155220.7344-1-anthony.perard@citrix.com> From: Laszlo Ersek Message-ID: Date: Thu, 19 Jul 2018 20:32:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180719155220.7344-1-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 19 Jul 2018 18:32:51 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 19 Jul 2018 18:32:51 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v2] UefiCpuPkg/MpInitLib: Fix build of Microcode X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 18:32:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Anthony, (I'm seeing your v1 and v2 postings at the same time now:) On 07/19/18 17:52, Anthony PERARD wrote: > On Debian Jessie, this fail to build with: > > /build/UefiCpuPkg/Library/MpInitLib/Microcode.c: In function 'MicrocodeDetect': > /build/UefiCpuPkg/Library/MpInitLib/Microcode.c:248:37: error: 'ProcessorFlags' may be used uninitialized in this function [-Werror=maybe-uninitialized] > CpuMpData->ProcessorFlags = ProcessorFlags; > ^ > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Anthony PERARD > --- > > Notes: > v2: > Fix coding style. > > UefiCpuPkg/Library/MpInitLib/Microcode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c b/UefiCpuPkg/Library/MpInitLib/Microcode.c > index efda143e67..cea1d34c0a 100644 > --- a/UefiCpuPkg/Library/MpInitLib/Microcode.c > +++ b/UefiCpuPkg/Library/MpInitLib/Microcode.c > @@ -87,6 +87,7 @@ MicrocodeDetect ( > } > > ExtendedTableLength = 0; > + ProcessorFlags = 0; > // > // Here data of CPUID leafs have not been collected into context buffer, so > // GetProcessorCpuid() cannot be used here to retrieve CPUID data. > a patch for fixing this issue is on its way to being committed (Dandan posted it just ~10 hours before your v1). Please see the thread [edk2] [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure http://mid.mail-archive.com/20180719045059.55868-1-dandan.bi@intel.com I think when Liming commented on your v1, he was unaware of Dandan's patch. And, I'm seeing your v1+v2 just now, at the same time. Sorry about the inconvenience! Thanks Laszlo