From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
edk2-devel@lists.01.org, leif.lindholm@linaro.org
Subject: Re: [PATCH] ArmVirtPkg: switch to generic ResetSystemRuntimeDxe
Date: Mon, 3 Jul 2017 19:44:05 +0200 [thread overview]
Message-ID: <cafbfe1a-73e2-59cd-912d-8a58a2d0914e@redhat.com> (raw)
In-Reply-To: <20170703135345.28703-1-ard.biesheuvel@linaro.org>
On 07/03/17 15:53, Ard Biesheuvel wrote:
> For obscure reasons, ARM platforms use a different implementation of
> the ResetSystem() runtime service call than other platforms. So let's
> switch all ArmVirtPkg platforms to the generic version instead.
>
> Given that all platforms use an implementation of EfiResetSystemLib [as
> consumed by the ResetRuntimeDxe in EmbeddedPkg that we are replacing]
> which is unlikely to be depended upon by out of tree platforms, let's
> simply modify this library into an implementation of ResetSystemLib
> instead [which is what the generic driver in MdeModulePkg consumes]
>
> This does mean we need to update all clients at the same time, which
> is why all changes are part of the same patch.
>
> As before, warm reset and platform specific reset are mapped onto
> cold reset (which is the only thing PSCI implements, at least the
> version we depend on). The new library function EnterS3WithImmediateWake()
> is left unimplemented, as permitted by the ResetSystemLib library class.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> Note: this a no-whitespace diff
>
> ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
> ArmVirtPkg/ArmVirtQemu.dsc | 2 +-
> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 2 +-
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
> ArmVirtPkg/ArmVirtXen.dsc | 2 +-
> ArmVirtPkg/ArmVirtXen.fdf | 2 +-
> ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.c | 125 +++++++++++++-------
> ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.inf | 4 +-
> 8 files changed, 89 insertions(+), 52 deletions(-)
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks, Ard!
Laszlo
next prev parent reply other threads:[~2017-07-03 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 13:53 [PATCH] ArmVirtPkg: switch to generic ResetSystemRuntimeDxe Ard Biesheuvel
2017-07-03 14:15 ` Leif Lindholm
2017-07-03 17:44 ` Laszlo Ersek [this message]
2017-07-03 17:51 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cafbfe1a-73e2-59cd-912d-8a58a2d0914e@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox