From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mx.groups.io with SMTP id smtpd.web11.31711.1660758139493876160 for ; Wed, 17 Aug 2022 10:42:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RFSkV7aE; spf=pass (domain: gmail.com, ip: 209.85.216.43, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f43.google.com with SMTP id pm17so13100367pjb.3 for ; Wed, 17 Aug 2022 10:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=126f8KPvTT+qerQ3Uio8FrfpnDv+ZnF0X4edxv4sk3s=; b=RFSkV7aEs94M3zAXNsj/kZZFFpmMAbaNw48i8qdtaOFIogLIqQ2gktlqkNg9AbEjdv n15MYr8zMRnBRKgU6dyserMFulojGCe5XtsBtxvB40HLmcZac/MDlH1dsQC/Ze3AcRfc PBHc+OCvpj9PyZFkZoSYVD1Tf8digw30W+NPrADk7n0HZ8GUlaeaVO0AK1re8vs5Hh6m CCKSLoRmphX00uCQibhuGOMSpwuYiBuhWIJk64yST4dkYQ7Qmgrkyz1WDnk+vj20GXb8 pk1CZvacZzCR3c/bhjHNTSdP1j1/qsDMAD8K1BzeMURMKw7ANkxfO875ZP+bH60UJj7d H4Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=126f8KPvTT+qerQ3Uio8FrfpnDv+ZnF0X4edxv4sk3s=; b=4w0BeSW9VQvFllKXCM/y2SWrS+pehdf1If4vJ3RMzuahjIh83wsPOQfJYM9j6wrsJd H76HRj3jFD/evGzkof4NINczwUS+nPjtbZSV/HXNv2zHFSKdZ94V5bVn2WgW0IQ4jN14 rsrUOazBmlxKOiLmMEdAu5WZnNJFls021l2/+nzm8fuy/cvmlWbLwSlwa9yMo5tCGcGV q+dqdqNjrByV1rHZI1vqILJQZPMpFP6J+svKTaqDoAY5qydR+e8CIkLrHdPer8LWvlDu Xiya3/u6zZJJI2AoB+Ox+S0lKM6uX/OkJ4XHUcQ+4Len66OqbENId95Zgn5Sxd4OuYK9 0VyQ== X-Gm-Message-State: ACgBeo2Y+m0mLIoxfXy3E9rej6ETlnuHkrm71dGS9BVH/5z1yPHWW315 fVCxKMAbgooJ9szgtXWKUfn7PGs/G8U= X-Google-Smtp-Source: AA6agR6ssqW+hNOn6Dz3khsIp0rzDSQAlQWgGHPjU/LSvbpn47//MokAO3Cjc9v7uLiXIUOo6YAOtg== X-Received: by 2002:a17:90b:180b:b0:1f5:50fd:15ac with SMTP id lw11-20020a17090b180b00b001f550fd15acmr4880385pjb.25.1660758138719; Wed, 17 Aug 2022 10:42:18 -0700 (PDT) Return-Path: Received: from ?IPV6:2001:4898:d8:33:10ab:f038:3d5c:1e26? ([2001:4898:80e8:36:9097:f038:3d5c:1e26]) by smtp.gmail.com with ESMTPSA id u6-20020a170902714600b0016d295888e3sm174441plm.241.2022.08.17.10.42.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Aug 2022 10:42:18 -0700 (PDT) Message-ID: Date: Wed, 17 Aug 2022 10:42:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [edk2-devel] [PATCH v4 6/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI config To: devel@edk2.groups.io, sami.mujawar@arm.com, Pierre Gondois Cc: Alexei Fedorov , Joe Lopez , "nd@arm.com" References: <20220810222853.1916-1-kuqin12@gmail.com> <20220810222853.1916-7-kuqin12@gmail.com> <46f86936-9ec3-58a4-a0f6-47e5bedbf630@arm.com> <9f3071b7-c200-1bfb-af1a-7abbb2f72f6a@arm.com> From: "Kun Qin" In-Reply-To: <9f3071b7-c200-1bfb-af1a-7abbb2f72f6a@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Sami, Thank you for the help! I agree that we can drop this patch and merge the rest when the window is open. Pierre, Thanks for your input on the usage as well! Regards, Kun On 8/17/2022 5:06 AM, Sami Mujawar wrote: > Hi Kun, > > I plan to get this series merged when the merge window opens. > > If you agree, I will drop this patch before merging. Please let me > know if that is ok. > > Regards, > > Sami Mujawar > > On 17/08/2022 09:53 am, Pierre Gondois wrote: >> >> >> On 8/17/22 02:17, Kun Qin wrote: >>> Hi Pierre, >>> >>> You are correct that if CM_ARM_PCI_ADDRESS_MAP_INFO.PCI_SS_CONFIG >>> is no longer being used, this patch is not needed. Thanks for >>> catching this. >>> >>> On the other hand, just for my learning purpose, could you please >>> let me know >>> what the use case for "PCI_SS_CONFIG" is? It does not seem to be >>> used at all. >> >> I haven't seen any usecase neither so far, but it is to be used to >> reference a >> PCI bus/device/function/register location to identify/configure a device >> from what I understood. >> >>> >>> Thanks again for testing these patches! >>> >>> Regards, >>> Kun >>> >>> On 8/16/2022 8:33 AM, Pierre Gondois wrote: >>>> Hello Kun, >>>> >>>> Is this patch still required ? >>>> Cf: https://edk2.groups.io/g/devel/message/92204 >>>> >>>> The CM_ARM_PCI_CONFIG_SPACE_INFO struct should be enough to describe >>>> the PCI ECAM, so CM_ARM_PCI_ADDRESS_MAP_INFO.SpaceCode being set to >>>> PCI_SS_CONFIG should be an invalid case. >>>> If not I don't think a v5 should be necessary. >>>> >>>> Also I ran the patchset on KvmTool and everything was working. >>>> >>>> Regards, >>>> Pierre >>>> >>>> On 8/11/22 00:28, Kun Qin wrote: >>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998 >>>>> >>>>> This change added a switch case handling for PCI_SS_CONFIG during >>>>> SSDT >>>>> generation. This will allow PCI config case return EFI_SUCCESS >>>>> instead of >>>>> EFI_INVALID_PARAMETER. >>>>> >>>>> Cc: Sami Mujawar >>>>> Cc: Alexei Fedorov >>>>> >>>>> Co-authored-by: Joe Lopez >>>>> Signed-off-by: Kun Qin >>>>> Reviewed-by: Pierre Gondois >>>>> Reviewed-by: Sami Mujawar >>>>> --- >>>>> >>>>> Notes: >>>>>      v2: >>>>>      - Added Reviewed-by tag [Pierre] >>>>>           v3: >>>>>      - No change >>>>>           v4: >>>>>      - Added Reviewed-by tag [Sami] >>>>> >>>>> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c >>>>> | 5 +++++ >>>>>   1 file changed, 5 insertions(+) >>>>> >>>>> diff --git >>>>> a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c >>>>> b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c >>>>> >>>>> index dd75fc27e60e..c6fbd09c43f8 100644 >>>>> --- >>>>> a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c >>>>> +++ >>>>> b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c >>>>> @@ -606,6 +606,11 @@ GeneratePciCrs ( >>>>>                      ); >>>>>           break; >>>>>   +      case PCI_SS_CONFIG: >>>>> +        // Do nothing >>>>> +        Status = EFI_SUCCESS; >>>>> +        break; >>>>> + >>>>>         default: >>>>>           Status = EFI_INVALID_PARAMETER; >>>>>       } // switch > > > > >