From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.2008.1575406101351644532 for ; Tue, 03 Dec 2019 12:48:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H7lcF65Q; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575406100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OCK8ipBCdKzqP+En+W7HTwiPZ33MuKMiKIZR9AXa52s=; b=H7lcF65Q1WsRPS71IQYUluuUNNBnF2VYGpBKGRoQhQ7qo+FVuC5l58Lq85imWUwWeoAY78 86aTcHhre2yg7iTaC66il6w0Agc+PXCWpukmRwE/1xkjhnVp6J9JlXcUnvMbmmbjIMrf7r 8jJCN8Kn5HaERaP18gYiqrXTR0qc/DA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-365-UHQb8bs9OlaFIBLE21xsYQ-1; Tue, 03 Dec 2019 15:48:19 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8F7BF107ACC4; Tue, 3 Dec 2019 20:48:17 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-183.ams2.redhat.com [10.36.117.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 973425C3FD; Tue, 3 Dec 2019 20:48:13 +0000 (UTC) Subject: Re: [PATCH 56/79] OvmfPkg/Acpi: Fix few typos To: Philippe Mathieu-Daude , devel@edk2.groups.io Cc: Antoine Coeur , Jordan Justen , Ard Biesheuvel References: <20191203161602.15969-1-philmd@redhat.com> <20191203161602.15969-57-philmd@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 3 Dec 2019 21:48:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191203161602.15969-57-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: UHQb8bs9OlaFIBLE21xsYQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 12/03/19 17:15, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix few typos in comments and documentation. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/Csm/Include/Protocol/IsaAcpi.h | 2 +- > OvmfPkg/AcpiPlatformDxe/BootScript.c | 2 +- > OvmfPkg/AcpiTables/Facp.aslc | 8 ++++---- > OvmfPkg/AcpiTables/Facs.aslc | 4 ++-- > OvmfPkg/AcpiTables/Madt.aslc | 2 +- > 5 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h b/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h > index 12aeb1227c54..0ff57aa118ca 100644 > --- a/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h > +++ b/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h > @@ -131,7 +131,7 @@ EFI_STATUS > > This services sets the power state of the ISA controller specified by Device to > the power state specified by OnOff. TRUE denotes on, FALSE denotes off. > - If the power state is sucessfully set on the ISA Controller, then > + If the power state is successfully set on the ISA Controller, then > EFI_SUCCESS is returned. > > @param[in] This The pointer to the EFI_ISA_ACPI_PROTOCOL instance. > diff --git a/OvmfPkg/AcpiPlatformDxe/BootScript.c b/OvmfPkg/AcpiPlatformDxe/BootScript.c > index 7137994471bd..7b1b9586da41 100644 > --- a/OvmfPkg/AcpiPlatformDxe/BootScript.c > +++ b/OvmfPkg/AcpiPlatformDxe/BootScript.c > @@ -240,7 +240,7 @@ FatalError: > Script opcodes. If the function returns successfully, > the caller must set the S3Context pointer -- originally > returned by AllocateS3Context() -- immediately to NULL, > - because the ownership of S3Context has been transfered. > + because the ownership of S3Context has been transferred. > > @retval EFI_SUCCESS The translation of S3Context to ACPI S3 Boot Script > opcodes has been successfully executed or queued. (This > diff --git a/OvmfPkg/AcpiTables/Facp.aslc b/OvmfPkg/AcpiTables/Facp.aslc > index 8829c1808a70..657a8c645821 100644 > --- a/OvmfPkg/AcpiTables/Facp.aslc > +++ b/OvmfPkg/AcpiTables/Facp.aslc > @@ -21,7 +21,7 @@ EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE FACP = { > EFI_ACPI_CREATOR_ID, // ASL compiler vendor ID > EFI_ACPI_CREATOR_REVISION // ASL compiler revision number > }, > - 0, // Physical addesss of FACS > + 0, // Physical address of FACS > 0, // Physical address of DSDT > RESERVED, // System Interrupt Model in ACPI 1.0, eliminated in 2.0 > EFI_ACPI_2_0_PM_PROFILE_UNSPECIFIED, // Preferred PM profile > @@ -62,8 +62,8 @@ EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE FACP = { > GAS2_IO(RESET_REG, 1), // Extended address of the Reset Register > RESET_VALUE, // Value for the Reset Register to reset the system > { RESERVED }, // reserved[3] > - 0, // 64-bit physical addesss of FACS, set at installation > - 0, // 64-bit physical addesss of DSDT, set at installation > + 0, // 64-bit physical address of FACS, set at installation > + 0, // 64-bit physical address of DSDT, set at installation > > GAS2_IO(PM1a_EVT_BLK, PM1_EVT_LEN), // Ext. addr. of PM 1a Event Reg Blk > { 0 }, // PM 1b Event Reg Blk unsupported > @@ -83,7 +83,7 @@ ReferenceAcpiTable ( > { > // > // Reference the table being generated to prevent the optimizer from removing the > - // data structure from the exeutable > + // data structure from the executable > // > return (VOID*)&FACP; > } > diff --git a/OvmfPkg/AcpiTables/Facs.aslc b/OvmfPkg/AcpiTables/Facs.aslc > index 56f86c1ca4fd..8257c4bc6416 100644 > --- a/OvmfPkg/AcpiTables/Facs.aslc > +++ b/OvmfPkg/AcpiTables/Facs.aslc > @@ -70,8 +70,8 @@ ReferenceAcpiTable ( > ) > { > // > - // Reference the table being generated to prevent the optimizer from removing the > - // data structure from the exeutable > + // Reference the table being generated to prevent the optimizer from removing the The line above introduces a stray space character before the CRLF. Please remove it. (I.e., the line starting with "Reference..." should not be changed.) With that: Reviewed-by: Laszlo Ersek Thanks Laszlo > + // data structure from the executable > // > return (VOID*)&FACS; > } > diff --git a/OvmfPkg/AcpiTables/Madt.aslc b/OvmfPkg/AcpiTables/Madt.aslc > index 44ffd3726500..02fc3649a0d0 100644 > --- a/OvmfPkg/AcpiTables/Madt.aslc > +++ b/OvmfPkg/AcpiTables/Madt.aslc > @@ -147,7 +147,7 @@ ReferenceAcpiTable ( > { > // > // Reference the table being generated to prevent the optimizer from removing the > - // data structure from the exeutable > + // data structure from the executable > // > return (VOID*)&Madt; > } >