From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.46]) by mx.groups.io with SMTP id smtpd.web12.16462.1636728313683731451 for ; Fri, 12 Nov 2021 06:45:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=dYGied7W; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.46, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d6TwJekHSFN44Euh3zqxId6niKL3xxnyMAsCit587pGX6nHw2q7sbW7q/qGmifUGt9hCnxgnQzozXP9nJqPMjCcGEpitVwz4apFdmdlvRsVdQ1+NRsC8gd5CAYvbHEJPAOmdtNG2eeqJBnxHbswdJ0ZUb8XtGVhhPfuHfKug2WKnYQ0ntUhwic4iqrgm0xiHwvnbxsYKEiaoM1ksInlRCDBKnokNQxGj+gqWMC5TK4J58Zv9/qqlOh28e98JCrEg/FyFiYi7mlEGXDyvW85FCGXoDxt192qXeUd/W/X68AixSlaouI4V8kSwVPz3WoLwoYqDiV84KZ1UD0qMwHKAXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U3/fW5T64zg/8Xzbl5h6XmimXGwiIIIdY7WvYzWvxx4=; b=HHk0iefGX0rEaicWxl/pAdAYkFHkGfDHyzK9pqEPMWjJVwfuxq93VzeU190ivd40WatMPGIQBfPTybnYFOWB/ksctoYNrUuqs1/QmlcbYLfghM3cAgWOSQF+QxwyBdlVDbVplbqwJGVxCUeuDKQvv6UgYH8rz6FRZeThRElCLKWUe+V+IWG4Y6ZmCMsJZV+9bT5/M35asKYgyrCVDn1YR3V1EwqMU/YeZF/GjqotvWFXnlU/YDiOZfC4RSgjCExt1omrSxshNW4w1OkXPP8KYQ6kPqu29o+gdFuV97AdL8oEj5DJ38qfdssbNRFDyBdAzRLu7TRZ7E9ZPL2E1X+vdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U3/fW5T64zg/8Xzbl5h6XmimXGwiIIIdY7WvYzWvxx4=; b=dYGied7WT6xQtUpyBH5cIUs9RXAKSTDkzyjfnwe+u3i6NtdxZbSeLW11wV/kyYAZmOH0Ux1tMFoytIRh5/UgvN+sB1Io75jEho2bkBgLXYQQiiMDPyJrYV/6aP8n0q6vE6i7HbhsKMCY0dc5yaWB4XaJ5BB0rVYABr+TIfjmglc= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2509.namprd12.prod.outlook.com (2603:10b6:802:29::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.16; Fri, 12 Nov 2021 14:45:11 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::e4da:b3ea:a3ec:761c]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::e4da:b3ea:a3ec:761c%7]) with mapi id 15.20.4669.020; Fri, 12 Nov 2021 14:45:11 +0000 Cc: brijesh.singh@amd.com, James Bottomley , "Xu, Min M" , "Yao, Jiewen" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , Erdem Aktas , Michael Roth , Gerd Hoffmann , "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , "Kumar, Rahul1" , "Dong, Eric" Subject: Re: [PATCH v12 27/32] UefiCpuPkg/MpInitLib: use BSP to do extended topology check To: "Ni, Ray" , "devel@edk2.groups.io" References: <20211110221457.2397234-1-brijesh.singh@amd.com> <20211110221457.2397234-28-brijesh.singh@amd.com> From: "Brijesh Singh" Message-ID: Date: Fri, 12 Nov 2021 08:45:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: X-ClientProxiedBy: MN2PR01CA0066.prod.exchangelabs.com (2603:10b6:208:23f::35) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from [10.236.30.107] (165.204.77.1) by MN2PR01CA0066.prod.exchangelabs.com (2603:10b6:208:23f::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13 via Frontend Transport; Fri, 12 Nov 2021 14:45:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2ba9cbb-a872-44d2-15a6-08d9a5eb0754 X-MS-TrafficTypeDiagnostic: SN1PR12MB2509: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IAacHy1pasprNb1hLKskMhgJ6oDVnebg5T3hwEwBZ9H14KgvZQ9C3RNo6s7jINF0OfqjFj1WrURHXrGsGOpdwmuKF8I2lEJ01bEVpgi5U45ijb4Lb4sZBT23Y1I11BikpSdDTv56zFYZber6QmNzgh7UQ2kb1DFvY4IPFyt+rjqyNVJpM00sYvPnWO3UIX5Ra+xlXxVYbrzDFow0NzrO+nL2vRev5dy578VEbdafMOFDiyiqHOggPfP/CfvGY7OGpIFJLQwAfVgA4RhK49IhcXr7iKl6NRa/D3DRHo1fyS+GnqNTtrGkZhLoK++8g2xZFayu3+Ikmx5dIkzeE0RRYiRWNnHDkuEz9P8HJ0X0ur+BBO9XRrYw2iFrAuST3vCmLQ2LQwmgcT0qDd7qc3nS7I8CtByNRyN/Ti1x5SeHJ7RzZRsL1sa/MLiJiyYfvmsis8uMvVCb2bbnkuDpWi+7tyKhHd5gpzmG1+zrc+ZCZIGOaZopCtBH4v3OEDi5VYiXHrbFAcaCXThW1/iTcvYLqaU+15Ed9a3g/1wk6/6NxtIIlYA2cjluD3exNuZsPAUf59I9tDpRTnB9svbK34u8PsFbMt2+yCYXNy07ubAV4uxmsuGwNilHZp2nLwQyGyz6E+9vRFBvD9tz4jSYKpmT/TuB/z+oNJvch+3K1ozQns+umWyI3ZglmUFUPdiPnyqGtcwJ+94W4QREJk0obfFjSbfAo1DdGoHOjBLU375keig= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(26005)(31696002)(16576012)(2906002)(5660300002)(53546011)(316002)(4326008)(8676002)(83380400001)(66556008)(508600001)(7416002)(2616005)(86362001)(31686004)(8936002)(6486002)(38100700002)(186003)(110136005)(36756003)(54906003)(66476007)(66946007)(956004)(44832011)(43740500002)(309714004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDdPMFNzWHZzVWVUd2FUQlNiTUZLaVZqUlVMRThQdmUrTVFnNjZCc0g4Vkox?= =?utf-8?B?UGVkdXF4RW1seGVtdFBRVEc0RGJBQWh0KzdiZEtnM0dNRkdXWG81UUMyYmlC?= =?utf-8?B?Y2RPNEM1RDA4cllwdGg2L2RTM1lqTG5idFJtMjQ0OTM3Q0pTK0tKK3I4ekc2?= =?utf-8?B?Y21zRGhBcUZrQTUwZjhVcUxQSlhKSkUxUXgweDZVZDhvRExlRy9WY2EyYjhJ?= =?utf-8?B?aGhEWjA3eXJlb1RGMGdJS3l1aWFLSW4rUkUwaExPZFhPZEhnWEtDWTdXbmhM?= =?utf-8?B?MVBiMXRJSmdCbVhPT01YR3NsSFo3d0Q5QXVkczNHMEIzaDRMNGV2U29VZ09w?= =?utf-8?B?WExMWlpVUWcxU2lBR01QcE9wbHpKeWFiM0llY3lTVzBKUFBDTkQzSnpkdXUz?= =?utf-8?B?M0t1MkhqbWV2N3NtQ0FaZHNkZHR4dHQ5aFkvUVdrbjN0elNVY2xnZ3pWdXNo?= =?utf-8?B?QnFKNEs5UXBUc3lDYVVxcEo0TE5raDFCbUJzaU80d28rZXFRRFlucmd4VGhT?= =?utf-8?B?YVIwL2dqYTFtYnplcVpVa2NublFHa0M1UFZpSnMrOHYvaGpqK2tIYStCZEtW?= =?utf-8?B?VWN1M3FwSDF6U1l5dmRtbXhmWnAzbElLaENSTjVJUHgyOTMwbzJ6REVIVkJ6?= =?utf-8?B?R1BhQVdhTEZBcGh2L25zVnFySDVYMGIzVjdtRkMxZ3RyTEZKLzhzQXpKZzFz?= =?utf-8?B?aTRtMkJFWk05clRFdFpCZjRQVWJIdk9idEp2VUlIcHkwenppY3dubWlYcCs0?= =?utf-8?B?Ui9PVCtNYVNjWnk3WU01a1JqRnNnVHlMYVFrbmdudlhwTzJ6OHA5NVpPVVN3?= =?utf-8?B?WjU2ak16QTUrSk1YME5GaGl0UUQ0R1FrbVVGa2FObGs0RTJnU3ZydkExeFQr?= =?utf-8?B?WmRZWVhnQ1BmdzA5MTd1WkVRWXNkTTR5TldITGtvZ0VKa3lRRHRvUW9QYTZs?= =?utf-8?B?bW1VZ21wd3l5Ym5BSkVnQlhKRWpKeVJPUG9jRVUvNUtCWFEzend2OHYwYmRs?= =?utf-8?B?am12QUFJZGdKQXh3RGF0bHNoaHRzVm1pV1lDdVdZdnNFa0pzYmdEcVlRaUVD?= =?utf-8?B?cll2WDJiampmTVZ1QlRncGwxNEdhaFNzQ1hOQXZoZUpBR1U1dnVGS1J1V0lD?= =?utf-8?B?enJEVU02bXJYTWhqOW1DSTBEWjBldy9LNXdZNDhXZVZwbGZyY1p2K2tJLzNl?= =?utf-8?B?R1R4S0g2c3dVNjNYREJnanlSWVRVZGFLYTNzSm1xRVRFVnhlUGdCNXdUcktZ?= =?utf-8?B?eVUxUlV6Qkc4QWRFclQyYldDUTZCL3BMK1lYK0dGaEoxQjR1TXQwNnJEVUJK?= =?utf-8?B?a1lQQ1V4WFVBUUJXcVJqQ0tVd1B4OWllYVVrRUhVcUp3YWxvTzNObHVhRXMy?= =?utf-8?B?QW41a0RyWDlITkx6OVBTMnJ2OHgzV0JRczRpbUNNYzVkTmpTenF3K0JxaGlv?= =?utf-8?B?RTRZSjJHSzVlT1ZnVmFKNFdDdVhId0Q3ZGdoeU5MdmI2aEcxNzhEMllIckZk?= =?utf-8?B?V251UGI4V0l5U0toa2dJaVN5Sk1GTUx1b2NLZWdWTjB5eUxlSlN5UEFBekxH?= =?utf-8?B?ZkNybjhTQnphTmJTcWR2MDJ4VUlkSkUrZnJtZk9jLyttVWdJMGlST3ZUNm9n?= =?utf-8?B?Q1lMbCtlSGh3Qk9BNEdXQnFrTmkwT3JQMnhEd3VuWGZSWVAyM0FCeldTanZy?= =?utf-8?B?Q2tRS2U2cWZMSU1sUjY0VEFBYnJSQVFLWm1pN3pkNFdqenBtZTd6VEtML1hs?= =?utf-8?B?VjRkME1LblZWK2hOc1RHVlB0d0JYMmJzWUNkYWduRVVucnYvc21nTkFIWmFS?= =?utf-8?B?N0ExdDcxelFqOHI4YWpWZVhTTllvSGdTbkd1dE0wb3Vqb2p6S2pHTnhaWWRz?= =?utf-8?B?dXhQaVBZVEFrSUJqSldUem1TZENPNG9KMGNpci9kZ2NhTGNVRkpmR2hYcXRx?= =?utf-8?B?dlAwQmQvRnFxbW9lTXl2czVkaFAyRE45UTY5WHYxNUpIK2ZQUHlsbFhmN3Ux?= =?utf-8?B?dEtOMFM0WExWaGd6VzNPOFhPYTJLQmc5cE5YUjdMOU1ta0pKZ1psWUxoME5X?= =?utf-8?B?U0ljejFJd2xRSjhqZmlkR3FaeXBHc3hFYXo2blRDOXQzS3RKc3lDMzFlQW1F?= =?utf-8?B?MkRsa2ozOE02ckd0dVg0K214ak42RGdGYkE0RkJ3aE9xczAya29hb1lwZmJK?= =?utf-8?Q?QMdgMGPcaQVqt54rtXCpaDM=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2ba9cbb-a872-44d2-15a6-08d9a5eb0754 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2021 14:45:11.0823 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xG0/DXYXnGtcJfPiEIABG7pfica0g4J1JQLwTXtJ3G5YlOpvXYjSQQQLAdyUAXgnpa2psPHnBBVnDq7fychpwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2509 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/11/21 7:53 PM, Ni, Ray wrote: > 3 comments: > >> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h >> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h >> @@ -224,6 +224,7 @@ typedef struct { >> BOOLEAN SevEsIsEnabled; >> BOOLEAN SevSnpIsEnabled; >> UINTN GhcbBase; >> + BOOLEAN ExtTopoAvail; >> } MP_CPU_EXCHANGE_INFO; > > 1. Can you please group all SEV-ES fields together? Please see my request about doing the grouping as a follow up patch. I have some other cleanup bit for SEV which will simplify code a bit and I am thinking to do all of those together. > Those might include followings: > BOOLEAN SevEsIsEnabled; > BOOLEAN SevSnpIsEnabled; > UINTN GhcbBase; > BOOLEAN ExtTopoAvail; > > >> >> + if (ExchangeInfo->SevSnpIsEnabled) { >> + AsmCpuid (CPUID_SIGNATURE, &StdRangeMax, NULL, NULL, NULL); >> + if (StdRangeMax >= CPUID_EXTENDED_TOPOLOGY) { >> + CPUID_EXTENDED_TOPOLOGY_EBX ExtTopoEbx; >> + >> + AsmCpuid (CPUID_EXTENDED_TOPOLOGY, NULL, &ExtTopoEbx.Uint32, NULL, NULL); >> + ExchangeInfo->ExtTopoAvail = !!ExtTopoEbx.Bits.LogicalProcessors; >> + } >> + } >> + > > 2. With the grouping, can you please create a routine such as FillExchangeInfoDataSevEs (...) in AmdSev.c? > Yep, I will do in v13. > >> // >> // Get the BSP's data of GDT and IDT >> // >> diff --git a/UefiCpuPkg/Library/MpInitLib/MpEqu.inc b/UefiCpuPkg/Library/MpInitLib/MpEqu.inc >> index 01668638f245..aba53f57201c 100644 >> --- a/UefiCpuPkg/Library/MpInitLib/MpEqu.inc >> +++ b/UefiCpuPkg/Library/MpInitLib/MpEqu.inc >> @@ -94,6 +94,7 @@ struc MP_CPU_EXCHANGE_INFO >> .SevEsIsEnabled: CTYPE_BOOLEAN 1 >> .SevSnpIsEnabled CTYPE_BOOLEAN 1 >> .GhcbBase: CTYPE_UINTN 1 >> + .ExtTopoAvail: CTYPE_BOOLEAN 1 >> endstruc > > 3. can you please do same group in NASM struct? > Same as above, I will do the needful in the follow up patch. > >