From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by mx.groups.io with SMTP id smtpd.web12.7649.1579506150300695265
 for <devel@edk2.groups.io>;
 Sun, 19 Jan 2020 23:42:30 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: zhichao.gao@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
  by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2020 23:42:29 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.70,341,1574150400"; 
   d="scan'208";a="220607396"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by fmsmga007.fm.intel.com with ESMTP; 19 Jan 2020 23:42:29 -0800
Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sun, 19 Jan 2020 23:42:28 -0800
Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by
 SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.1713.5; Mon, 20 Jan 2020 15:42:27 +0800
Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by
 SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004;
 Mon, 20 Jan 2020 15:42:27 +0800
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "ashishsingha@nvidia.com"
	<ashishsingha@nvidia.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser
Thread-Topic: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix
 FADT Parser
Thread-Index: AQHVz1S5ttTJJxpElEylwh7oCb4WnKfzKyOg
Date: Mon, 20 Jan 2020 07:42:26 +0000
Message-ID: <cb76e55da2444289aeed779bea43eb69@intel.com>
References: <c43c948b564e614b99217d3b14bb6635f81b2766.1579498924.git.ashishsingha@nvidia.com>
In-Reply-To: <c43c948b564e614b99217d3b14bb6635f81b2766.1579498924.git.ashishsingha@nvidia.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.36]
MIME-Version: 1.0
Return-Path: zhichao.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ashish Singhal
> Sent: Monday, January 20, 2020 1:45 PM
> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Cc: Ashish Singhal <ashishsingha@nvidia.com>
> Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix
> FADT Parser
>=20
> FADT parser was checking for reduced ACPI flag incorrectly leading to
> incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL are
> both 0.
>=20
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
> ---
>  .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> c
> index 5b8cc174f1..8acfbac3b1 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars
> +++ er.c
> @@ -253,7 +253,7 @@ ParseAcpiFadt (
>      // present.
>      if ((Trace) &&
>          (Flags !=3D NULL) &&
> -        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D 0)) {
> +        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D
> + EFI_ACPI_6_3_HW_REDUCED_ACPI)) {
>        IncrementErrorCount ();
>        Print (L"ERROR: No FACS table found, "
>                 L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are zero.\n");
> --
> 2.17.1
>=20
>=20
>=20