From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9BCC82035D6A6 for ; Thu, 26 Apr 2018 04:00:08 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FC00406E97E; Thu, 26 Apr 2018 11:00:07 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-36.rdu2.redhat.com [10.10.120.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2F2510B2B22; Thu, 26 Apr 2018 11:00:04 +0000 (UTC) To: Gerd Hoffmann , edk2-devel@lists.01.org Cc: Phil Dennis-Jordan References: <20180426070207.11362-1-kraxel@redhat.com> From: Laszlo Ersek Message-ID: Date: Thu, 26 Apr 2018 13:00:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180426070207.11362-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 26 Apr 2018 11:00:07 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 26 Apr 2018 11:00:07 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v2] OvmfPkg/QemuVideoDxe: round up FrameBufferSize to full page X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 11:00:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/26/18 09:02, Gerd Hoffmann wrote: > Guests do the same, because the framebuffer is mapped somewhere, which > obviously works with page granularity only. > > When not rounding up to full page size we get messages like this one > (linux kernel): > > efifb: framebuffer at 0x80000000, using 1876k, total 1875k > ^^^^^ ^^^^^ > Also sysfb is confused and throws an error: > > sysfb: VRAM smaller than advertised > > Cc: Phil Dennis-Jordan > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/QemuVideoDxe/Gop.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/OvmfPkg/QemuVideoDxe/Gop.c b/OvmfPkg/QemuVideoDxe/Gop.c > index d51efc2a83..88142bf376 100644 > --- a/OvmfPkg/QemuVideoDxe/Gop.c > +++ b/OvmfPkg/QemuVideoDxe/Gop.c > @@ -69,6 +69,7 @@ QemuVideoCompleteModeData ( > Mode->FrameBufferBase = FrameBufDesc->AddrRangeMin; > Mode->FrameBufferSize = Info->HorizontalResolution * Info->VerticalResolution; > Mode->FrameBufferSize = Mode->FrameBufferSize * ((ModeData->ColorDepth + 7) / 8); > + Mode->FrameBufferSize = EFI_PAGES_TO_SIZE(EFI_SIZE_TO_PAGES(Mode->FrameBufferSize)); > DEBUG ((EFI_D_INFO, "FrameBufferBase: 0x%Lx, FrameBufferSize: 0x%Lx\n", > Mode->FrameBufferBase, (UINT64)Mode->FrameBufferSize)); > > @@ -107,6 +108,7 @@ QemuVideoVmwareSvgaCompleteModeData ( > > Mode->FrameBufferBase = FrameBufDesc->AddrRangeMin + FbOffset; > Mode->FrameBufferSize = BytesPerLine * Info->VerticalResolution; > + Mode->FrameBufferSize = EFI_PAGES_TO_SIZE(EFI_SIZE_TO_PAGES(Mode->FrameBufferSize)); > > FreePool (FrameBufDesc); > return Status; > Reviewed-by: Laszlo Ersek [lersek@redhat.com: fix coding style] Commit dd7760470fce. Thanks! Laszlo