From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 87EA3D81113 for ; Thu, 18 Jan 2024 18:46:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Obd4Q5TuKr9cskvkRQpvoI8vhA9hiIC/jPjlfiPaEQo=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705603562; v=1; b=ZCQK+nvkuxWyCqbUd79zRR/Cfjylf0F9Rtwaf369JOPtFJFK//xe+jfYKmYikGUC1ZqYVdL9 JmuxvLFTtSPFcgnFiXEPfPUqeR3eDsDihwrHdp9sfy9MwgzXGCb3pTCFTzGUJ4zp0saGYx9R2lF MQ2zcH+sXB3c/yT+g72/TXKY= X-Received: by 127.0.0.2 with SMTP id UzRqYY7687511xqygIIjkbCz; Thu, 18 Jan 2024 10:46:02 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.1173.1705603561425797106 for ; Thu, 18 Jan 2024 10:46:01 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-4fMppjPBMW2Q6HkELhEkYw-1; Thu, 18 Jan 2024 13:45:57 -0500 X-MC-Unique: 4fMppjPBMW2Q6HkELhEkYw-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6DCF528116BA for ; Thu, 18 Jan 2024 18:45:57 +0000 (UTC) X-Received: from [10.39.194.70] (unknown [10.39.194.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D864E492BE4; Thu, 18 Jan 2024 18:45:56 +0000 (UTC) Message-ID: Date: Thu, 18 Jan 2024 19:45:55 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 2/2] OvmfPkg/Tcg2Config: remove unused TPM 1.2 support To: devel@edk2.groups.io, kraxel@redhat.com Cc: Oliver Steffen References: <20240116154229.554679-1-kraxel@redhat.com> <20240116154229.554679-3-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: U4MboGXGVQMwSP7TAnxmdfctx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZCQK+nvk; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 1/17/24 15:12, Gerd Hoffmann wrote: >> This patch is good: >> >> Reviewed-by: Laszlo Ersek >> >> but the series shouldn't stop here. In "OvmfPkg/Tcg/Tcg2Config", we're >> left with an INF file (Tcg2ConfigPei.inf) that still references >> "Tpm12Support.h", and the common C source file "Tcg2ConfigPeim.c" still >> calls the one API -- InternalTpm12Detect() -- declared in that header >> file. The only remaining implementation of InternalTpm12Detect() is now >> in "Tpm12SupportNull.c", and all it does is "return EFI_UNSUPPORTED". >> >> Therefore, in a subsequent patch, "Tpm12SupportNull.c" and >> "Tpm12Support.h" should be removed, both from the tree, and from the >> remaining INF file. Furthermore, the InternalTpm12Detect() call in >> "Tcg2ConfigPeim.c", and everything that depends on the success of that >> call, now counts as dead code, and should be removed. >> >> And *that* in turn means that we should also remove >> "gEfiTpmDeviceInstanceTpm12Guid" from the [Guids] section of the >> remaining INF file. >=20 > Yes, I noticed there is more to cleanup, but I wanted have something > quick and proven (=3D=3D identical to setting TPM1_ENABLE=3DFALSE) out of > the door to fix the build / CI problems. Right, I now see that this would eliminate the symbol conflict. Either way, Jiewen has now reviewed Doug's patches for the symbol conflict, so I'm going to merge those (and your v3 VirtNorFlashDxe series, too). Laszlo >=20 > Touching the code for additional cleanups requires a bit more attention > and testing, I'll keep that on my radar though. >=20 > thanks & take care, > Gerd >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114005): https://edk2.groups.io/g/devel/message/114005 Mute This Topic: https://groups.io/mt/103764205/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-