From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.21224.1686842263710792080 for ; Thu, 15 Jun 2023 08:17:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@quicinc.com header.s=qcppdkim1 header.b=ObvXuO/F; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35FExPlg016941; Thu, 15 Jun 2023 15:17:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=ZJJB8N17j1Q4wRN0ZyF3zZTdZnonXwOqyUAnwrFrDYs=; b=ObvXuO/FjI2GqJv39aCp41TS//BPN7CpA1C3MK/V1+5tHBP49lACp6xpwa5q+3/jRQ4H IrfPnnzJXVyfKKBiMd9lM7IxAmi18q/5Siu6JdnKp9Kl0UJtX53dCKx7GISPYNF9qV4l 1cV8Y5UmnJ/RCLN6eeM1Kj8hqpwdIwlunFfodURJ21zQZrAwJdnHESgo1F2587fnKgEb RXxTK/2JqpWzmML6LRxFmengDDaRI4WN2BUXF7/itY9UArgYk3YW6U/a127tmivNznfG pj8QgDIkjiICmP79vhgvFMmD4XaQgmzWX4LzJaJEdrE2Kd3zblhzNu5nU3CkiCoWiNnH IA== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3r7auy3m27-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jun 2023 15:17:41 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 35FFHdTj020947 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jun 2023 15:17:39 GMT Received: from [10.111.140.135] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 15 Jun 2023 08:17:36 -0700 Message-ID: Date: Thu, 15 Jun 2023 16:17:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add Readme under Platform\AMD To: "Chang, Abner" , "devel@edk2.groups.io" CC: Michael D Kinney , "Attar, AbdulLateef (Abdul Lateef)" , "Xing, Eric" , "He, Jiangang" , Ard Biesheuvel References: <20230614042231.339-1-abner.chang@amd.com> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 3KcA2aiOvdLRym9T4uUHP3FmXvdFGF9G X-Proofpoint-GUID: 3KcA2aiOvdLRym9T4uUHP3FmXvdFGF9G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-15_11,2023-06-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 spamscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306150133 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 35FExPlg016941 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable On 2023-06-14 18:57, Chang, Abner wrote: > [AMD Official Use Only - General] >=20 >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Leif >> Lindholm via groups.io >> Sent: Thursday, June 15, 2023 12:13 AM >> To: devel@edk2.groups.io; Chang, Abner >> Cc: Michael D Kinney ; Attar, AbdulLateef >> (Abdul Lateef) ; Xing, Eric >> ; He, Jiangang >> Subject: Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add >> Readme under Platform\AMD >> >> Caution: This message originated from an External Source. Use proper cau= tion >> when opening attachments, clicking links, or responding. >> >> >> On 2023-06-14 05:22, Chang, Abner via groups.io wrote: >>> From: Abner Chang >>> >>> For AMD edk2 opensource project and the needs >>> of opensource AMD platform common modules those can >>> be leverage across AMD business units, AMD server, >>> client and S3 (silicon strategic solution) BUs >>> have the consensus to propose AMD as the maintainer >>> of Platform/AMD folder. The folder and edk2 package >>> structure under Platform/AMD is defined in the >>> Readme for the further upstream works. >>> >>> We still leave the existing maintainers for >>> AMD OverdriveBoard which is no conflicts with this >>> change. >>> >>> Signed-off-by: Abner Chang >>> Cc: Leif Lindholm >>> Cc: Michael D Kinney >>> Cc: Abdul Lateef Attar >>> Cc: Eric Xing >>> Cc: Jiangang He >>> --- >>> Platform/AMD/Readme.md | 85 >> ++++++++++++++++++++++++++++++++++++++++++ >>> Maintainers.txt | 10 ++--- >>> 2 files changed, 90 insertions(+), 5 deletions(-) >>> create mode 100644 Platform/AMD/Readme.md >>> >>> diff --git a/Platform/AMD/Readme.md b/Platform/AMD/Readme.md >>> new file mode 100644 >>> index 0000000000..f39b8140f5 >>> --- /dev/null >>> +++ b/Platform/AMD/Readme.md >>> @@ -0,0 +1,85 @@ >>> +# AMD EDK2 Platform >>> + >>> +This is AMD folder that provides the edk2 modules to support AMD edk2 >> firmware >>> +solution for the server, client (e.g., Notebook) and S3 (Strategic Sil= icon >> Solutions) >>> +platforms. The board packages under this folder are the firmware refer= ence >> code for >>> +booting certain AMD platforms. The definition of sub-folders is descri= bed in >> below sections. >>> + >>> +## Term and Definitions >>> + >>> +* **AMD Platform** (platform in short) >>> + >>> + AMD platform refers to a platform that supports the particular AMD S= oC >> (processor), such as AMD EPYC Milan and Genoa processors. >>> + >>> +* **AMD Board** (board in short) >>> + >>> + AMD board is a generic terminology refers to a board that is designe= d >> based on a >>> + specific AMD SoC architecture (also referred as AMD platform). More = than >> one boards >>> + are possibly designed to support an AMD platform with different >> configuration, such as 1-processor socket or 2-processor sockets board. >>> + >>> +* **AMD edk2 Platform Package** (platform package in short) >>> + >>> + The folder has the AMD edk2 platform common modules. >>> + >>> +* **AMD edk2 Board Package** (board package in short) >>> + >>> + The folder has the edk2 meta files to build the necessary edk2 firmw= are >> modules >>> + and generate the binary to run on a board. >>> + >>> +## Package Definition >>> + >>> +* **AmdPlatformPkg** >>> + >>> + AMD platform edk2 package under this folder provides the common edk2 >> modules those >>> + are leverage by platforms. Usually those modules have no dependencie= s >> with >>> + particular platforms. The module under this scope can provides a com= mon >> implementation >>> + for all platforms, or it may just provide a framework but the differ= ences of >> implementation could be configured through the PCDs declared in >> AmdPlatformPkg.dec, or >>> + the board level library provided in the \Pkg. >>> + >>> +* **AmdMinBoardPkg** >>> + >>> + This package provides the common edk2 modules those can be leverage >> across AMD boards those use MinPlatformPkg framework. >>> + >>> +* **\Board** >>> + >>> + This is the folder named by SoC and accommodate one or multiple boar= d >> packages those >>> + are designed base on the same SoC platform. Board folder >> may contain edk2 >>> + package meta files directly or the sub-folders named by \> name\>Pkg for a >>> + variety configurations of a platform. >>> + >>> +* **Pkg** >>> + >>> + This is the folder that contains edk2 package meta files for a board= which is >> designed base on a platform. Besides the edk2 meta files, P= kg >> may also provides >>> + edk2 modules which are specifically to a board. >>> + >>> + ``` >>> + e.g. OverdriveBoard >>> + e.g. GenoaBoard >>> + |------Board1Pkg >>> + |------Board2Pkg >>> + ``` >>> + >>> + Below is the outline of folder structure under Platform/AMD >>> + >>> + ``` >>> + Platform/AMD >>> + |----AmdPlatformPkg >>> + |----AmdMinBoardPkg >>> + |----OverdriveBoard >>> + |----GenoaBoard >>> + | |------Common Modules for Genoa boards >>> + | |------Board1Pkg >>> + | | |-------Board specific modules >>> + | |------Board2Pkg >>> + | >>> + |----NextGenBoard >>> + |------Common Modules for the next generation >>> + platform boards >>> + |------Board1Pkg >>> + |------Board2Pkg >>> + |-------Board specific modules >>> + ``` >>> + >>> + >>> +## Board Support >>> +Under progress >>> \ No newline at end of file >> >> *cough* ^ > Lol, come on Leif, You always play fun on me =F0=9F=98=8A. Please give us= some time to work on this. >=20 >> >>> diff --git a/Maintainers.txt b/Maintainers.txt >>> index 020c72677a..d1d7613ef4 100644 >>> --- a/Maintainers.txt >>> +++ b/Maintainers.txt >>> @@ -83,6 +83,11 @@ F: Platform/96Boards/ >>> M: Ard Biesheuvel >>> M: Leif Lindholm >>> >>> +AMD >>> +F: Platform/AMD >>> +M: Abner Chang >>> +M: Abdul Lateef Attar >>> + >>> AMD Seattle >>> F: Platform/AMD/OverdriveBoard/ >>> F: Platform/LeMaker/CelloBoard/ >>> @@ -91,11 +96,6 @@ F: Silicon/AMD/Styx/ >>> M: Ard Biesheuvel >>> M: Leif Lindholm >>> >>> -AMD MinBoard package for MinPlatformPkg >>> -F: Platform/AMD/AmdMinBoardPkg >>> -M: Abner Chang >>> -M: Abdul Lateef Attar >>> - >> >> I think this change is ideal, but can I just confirm that it is your >> intention to take on overall maintainership of Platform/AMD while >> leaving myself and Ard as additional maintainers for the OverDriveBoard? >> (If not, you could add an X: tag. But I'd be happier if you didn't :) > Hmm..., actually this is the respect for you guys. But yes, my intention = is AMD take over the maintainership over Platform\AMD, but still leave the = maintainership to you and Ard for OverdirveBoard =F0=9F=98=8A. But we can h= elp on it if you encounter some problems. > Or you would like AMD to take over everything? We are not familiar with O= verdriveBaord though. I like the change as present in this patch. So if you add that missing newline at end of file: Reviewed-by: Leif Lindholm / Leif > Regards, > Abner >=20 >> >> / >> Leif >> >>> Ampere Computing >>> F: Platform/Ampere >>> F: Silicon/Ampere >> >> >> >>=20 >> >=20