From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=sudeep.holla@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id DDDE4202E61AA for ; Tue, 17 Oct 2017 06:52:03 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25C8A1529; Tue, 17 Oct 2017 06:55:39 -0700 (PDT) Received: from [10.1.210.28] (e107155-lin.cambridge.arm.com [10.1.210.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E71D83F590; Tue, 17 Oct 2017 06:55:37 -0700 (PDT) Cc: Sudeep Holla To: Ard Biesheuvel , edk2-devel@lists.01.org, leif.lindholm@linaro.org References: <20171017134205.3907-1-ard.biesheuvel@linaro.org> From: Sudeep Holla Organization: ARM Message-ID: Date: Tue, 17 Oct 2017 14:55:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171017134205.3907-1-ard.biesheuvel@linaro.org> Subject: Re: [PATCH edk2-platforms v2] Platform/ARM: use appropriate ReportStatusCodeLib resolution for RT drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 13:52:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 17/10/17 14:42, Ard Biesheuvel wrote: > ResetSystemRuntimeDxe may be invoked by the OS at runtime, at which time > it will attempt to call into ReportStatusCodeLib. If we use the default > version for DXE drivers, this will access data structures that are no > longer there so switch to the special runtime version instead. > Tested-by: Sudeep Holla > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index 8bcb84869c84..1605eedbdd8c 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -240,6 +240,7 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > ArmPlatformSysConfigLib|ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > !if $(SECURE_BOOT_ENABLE) == TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > !endif > -- Regards, Sudeep