Re: [PATCH 1/1] ArmPkg: Add SMC helper functions

["Rebecca Cran" <rebecca@nuviainc.com>]

On 10/22/21 9:08 AM, Ard Biesheuvel wrote:
> On Tue, 19 Oct 2021 at 22:35, Rebecca Cran <rebecca@nuviainc.com> wrote:
>> Add functions ArmCallSmc0/1/2/3 to do SMC calls with 0, 1, 2 or 3
>> arguments.
>> The functions return up to 3 values.
>>
> This is a lot of code to do something we already do in our code.
>
> Care to elaborate what the use case is here? In any case, we generally
> try to avoid submitting helper libraries like this without the user,
> to avoid merging code that is already dead.


Sure! With the current interface, there's lots of template code to set 
up the structure and extract results from it. By passing pointers to the 
arguments and results into the functions, this patch removes that 
template code.

I can send out a v2 patch set which includes changes to existing SMC 
calls so the new functions are used.


-- 
Rebecca Cran