From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web09.9247.1639388534449968408 for ; Mon, 13 Dec 2021 01:42:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jUP9kyrQ; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639388533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Zvm/Hxw7VV8XHlTMC4dbZK2Gs//gKuf3FqFlwDCpOk=; b=jUP9kyrQXJdP76nmzKL4M7k/PWWwWXoTRFdv/gpIhrh4ZLDykUqlv2CYonCtEdzGdcZMIT bEWi7slMhC6ASbc/7tU9nzw9Z9GB7QbIw8FOvuCbscOtbozGLj8g25w+apoknQtHMH8GMD jzwmKPTTjUIBSGYBbwkyOYsj0I2Z79U= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-419-PUJE0vyXN8iIQPrP-yzDlQ-1; Mon, 13 Dec 2021 04:42:12 -0500 X-MC-Unique: PUJE0vyXN8iIQPrP-yzDlQ-1 Received: by mail-wm1-f70.google.com with SMTP id j193-20020a1c23ca000000b003306ae8bfb7so9358367wmj.7 for ; Mon, 13 Dec 2021 01:42:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7Zvm/Hxw7VV8XHlTMC4dbZK2Gs//gKuf3FqFlwDCpOk=; b=5e2KkOxSPyCDLS76Z6wsgesQRPI9sxqKttIzxJZFiOTp5LyJ44+Q41mKGEP1fvfm5E yaWJLSMWg3ju6qqDBDrX2N7SRKgyxXIk1XhOri8e92SkSPwbP6HNojC8yZHgBRS5ljG1 aa2lodPMm+vlp3hTOX1+oJX64W9erTtiFDjD45AVj96j0WahrICrvHG29o5ZXlNWFAXy fbcip52ICNlDv+xPt2DwbHZAOQpd4KQfPq5jk3o/mZ9IYtNOlNacJ7H5lV3VkUI+W5se 0KTR2YO3QZ45cNvd5QmI4yNm5e/INMCH93J3u/22mVY6NveNQyTPtYpC5pAlLgrzysNQ +q/Q== X-Gm-Message-State: AOAM530DbKdvNStTgwy0fTDylfd2ulgaJ7xKZaD+yRXZjuS/EbXzmJl4 2b5WC1JThNUr9+0MTwNIpvUpIIkXjLjmXMhacvt9+cpKQKEUCz22vQR1/rNeCy7hKlEIjgNl0jn 0tGhLjiNFEP2nZw== X-Received: by 2002:a05:600c:3489:: with SMTP id a9mr36297100wmq.120.1639388531318; Mon, 13 Dec 2021 01:42:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzxLVZG9RCuuLiF6gxBFL4tUS4EYb83Kpq5nxU/jSSq8k7wLb94u5xx8EmQEokcLIDg83Ij3Q== X-Received: by 2002:a05:600c:3489:: with SMTP id a9mr36297061wmq.120.1639388531057; Mon, 13 Dec 2021 01:42:11 -0800 (PST) Return-Path: Received: from [192.168.1.36] (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id l4sm10214827wrv.94.2021.12.13.01.42.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Dec 2021 01:42:10 -0800 (PST) Message-ID: Date: Mon, 13 Dec 2021 10:42:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v4 6/7] OvmfPkg/PlatformCI: dummy grub.efi for AmdSev To: Gerd Hoffmann , devel@edk2.groups.io Cc: Michael D Kinney , dovmurik@linux.ibm.com, Jiewen Yao , Liming Gao , Ard Biesheuvel , Sean Brogan , Jordan Justen , Pawel Polawski , Bret Barkelew , Ard Biesheuvel References: <20211213081443.3534714-1-kraxel@redhat.com> <20211213081443.3534714-7-kraxel@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20211213081443.3534714-7-kraxel@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/13/21 09:14, Gerd Hoffmann wrote: > Building grub.efi for AmdSev is difficult because it depends on patches > not yet merged to upstream grub. So shortcut the grub build by simply > creating an empty grub.efi file. That allows to at least build-test the > AmdSev variant. > > Signed-off-by: Gerd Hoffmann > Acked-by: Jiewen Yao > Acked-by: Ard Biesheuvel > Reviewed-by: Dov Murik > --- > OvmfPkg/PlatformCI/AmdSevBuild.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/OvmfPkg/PlatformCI/AmdSevBuild.py b/OvmfPkg/PlatformCI/AmdSevBuild.py > index 2dd72cfe80d9..816caafb0084 100644 > --- a/OvmfPkg/PlatformCI/AmdSevBuild.py > +++ b/OvmfPkg/PlatformCI/AmdSevBuild.py > @@ -6,6 +6,7 @@ > ## > import os > import sys > +import subprocess > > sys.path.append(os.path.dirname(os.path.abspath(__file__))) > from PlatformBuildLib import SettingsManager > @@ -35,3 +36,7 @@ class CommonPlatform(): > > import PlatformBuildLib > PlatformBuildLib.CommonPlatform = CommonPlatform > + > +# hack alert -- create dummy grub.efi > +subprocess.run(['touch', 'OvmfPkg/AmdSev/Grub/grub.efi']) > +subprocess.run(['ls', '-l', '--sort=time', 'OvmfPkg/AmdSev/Grub']) Why run 'ls'? What about replacing subprocess by open? open('OvmfPkg/AmdSev/Grub/grub.efi', 'a').close()