From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A4AA4211BFCB5 for ; Wed, 30 Jan 2019 05:37:35 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 05:37:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="118663004" Received: from linux.intel.com ([10.54.29.200]) by fmsmga007.fm.intel.com with ESMTP; 30 Jan 2019 05:37:34 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 1B36858042B; Wed, 30 Jan 2019 05:37:32 -0800 (PST) Message-ID: From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 14:37:30 +0100 In-Reply-To: <20181106175833.26964-13-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-13-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:37:35 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > E1000MemCopy () takes UINT8 pointers not INT8 pointers, so cast the > arguments to the correct type. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c > b/IntelUndiPkg/GigUndiDxe/e1000.c > index 1f08a5d67b2d..4c9a06b8cf73 100644 > --- a/IntelUndiPkg/GigUndiDxe/e1000.c > +++ b/IntelUndiPkg/GigUndiDxe/e1000.c > @@ -674,8 +674,8 @@ E1000Receive ( > > // Copy the packet from our list to the EFI buffer. > E1000MemCopy ( > - (INT8 *) (UINTN) CpbReceive->BufferAddr, > - (INT8 *) (UINTN) ReceiveDescriptor->buffer_addr, > + (UINT8 *) (UINTN) CpbReceive->BufferAddr, > + (UINT8 *) (UINTN) ReceiveDescriptor->buffer_addr, > TempLen > ); >