From: Laszlo Ersek <lersek@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH V2] Change EDK II to BSD+Patent License
Date: Mon, 25 Mar 2019 13:11:44 +0100 [thread overview]
Message-ID: <cbd2775a-0125-5261-46fc-e4f25a993076@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9C705F9@ORSMSX112.amr.corp.intel.com>
Hi Mike,
On 03/23/19 03:25, Kinney, Michael D wrote:
> Hello,
>
> New in V2
> =========
> * Remove Cc lines from commit messages
> * Remove branch reference from commit messages
> * Change license in 2 files missed in OvmfPkg
> * Update OvmfPkg/License.txt to BSD+Patent as the default license
> * Move the portions of Contributions.txt in the root of edk2 to
> Readme.md in the root of edk2 that describe how to contribute
> along with the commit message format.
> * Add to Readme.md in the root of edk2 that Signed-off-by means that
> the contributor certifies compliance to the Developer's Certificate
> of Origin 1.1. https://developercertificate.org
> =========
[...]
> The patch series has one patch per package along with a few patches
> to update the license information in the root of the edk2 repository
> as described in the RFC V3.
[...]
> f9d59ccdc5 OvmfPkg: Change License.txt from 2-Clause BSD to BSD+Patent
[...]
> e39d07266d OvmfPkg: Replace BSD License with BSD+Patent License
The series now has two patches for OvmfPkg. Did you intend to squash
these into one (to match the original intent quoted above, i.e. one
patch per pkg), or did you intend to keep both patches separate?
If you meant to squash them, can you please do that and push a v3?
If the patches should be separate, I'll review both patches as they are
(plus recheck ArmVirtPkg).
Thanks!
Laszlo
next prev parent reply other threads:[~2019-03-25 12:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 2:25 [PATCH V2] Change EDK II to BSD+Patent License Kinney, Michael D
2019-03-25 12:11 ` Laszlo Ersek [this message]
2019-03-25 17:24 ` Kinney, Michael D
2019-03-26 18:08 ` Leif Lindholm
2019-03-26 18:21 ` Kinney, Michael D
2019-03-26 18:54 ` Leif Lindholm
2019-04-02 20:42 ` Kinney, Michael D
2019-04-03 11:43 ` Laszlo Ersek
[not found] ` <74D8A39837DF1E4DA445A8C0B3885C503F5C2D92@shsmsx102.ccr.corp.intel.com>
[not found] ` <74D8A39837DF1E4DA445A8C0B3885C503F5C2DFA@shsmsx102.ccr.corp.intel.com>
2019-04-04 2:00 ` [edk2] " Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbd2775a-0125-5261-46fc-e4f25a993076@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox