Re: [edk2-devel] [edk2-platforms][PATCH v5 1/9] Platform/Sgi: Correct typo in defining CPPC performance limited register

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Prabin,

Thank you for this patch.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 11/03/2024 01:14 pm, Prabin CA wrote:
> The reference design platform currently lacks the CPPC (Collaborative
> Processor Performance Control) performance limited register as defined
> by the ACPI 6.x specification. There is a typo in the macro definition
> where the 'fastchannel address of the performance limited register' is
> mentioned instead of the 'performance limited register address'.
> Correcting this typo. However, it's important to retain the reference to
> the performance limited register in the macro for future use, as it will
> prove useful once functionalities such as power metering devices are
> enabled.
>
> Signed-off-by: Prabin CA <prabin.ca@arm.com>
> ---
>   Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h b/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h
> index 033d398fdb63..3e24f569c95a 100644
> --- a/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h
> +++ b/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h
> @@ -469,8 +469,7 @@ typedef struct {
>   
>       @param [in] DesiredPerfReg      Fastchannel address for desired performance
>                                       register.
> -    @param [in] PerfLimitedReg      Fastchannel address for performance limited
> -                                    register.
> +    @param [in] PerfLimitedReg      Address for performance limited register.
>       @param [in] GranularityMHz      Granularity of the performance scale.
>       @param [in] HighestPerf         Highest performance in linear scale.
>       @param [in] NominalPerf         Nominal performance in linear scale.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117260): https://edk2.groups.io/g/devel/message/117260
Mute This Topic: https://groups.io/mt/104862626/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-