From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 12A9F740032 for ; Sun, 31 Mar 2024 11:58:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dALA0p99lM21w1uefjfpITtcqYR+51B4o+cZYDjsGVA=; c=relaxed/simple; d=groups.io; h=Received-SPF:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711886326; v=1; b=VeKE3/EDO5DFKYS05FrKGBmtk7h0ryWIaZ9Y039VPLV8kIKoSohwdi7I9zT/Z5jzgMbLYV0+ RQy0l9GnCmM3ny3lu9x2WdB3qCM9KOtyTpv8KuWVZElMRciefvgfvjw2bzlUIKP/sE8oJs4sPze vkBzQ9JF0yMlmbcMfE028HzxEr+wugYw+z9yvkmhY+PoW0CYE45jvMwxcetJrBfbS/QJyTGLkpL 4IdKWKN8C5z+2p1rmlDRrA5927NHgWbX8GZXR+I6A2lYlo0d4uhbOImw3DyvlZ7e7LojlH+jxYX /XepvWL54JVIIegW4M0h8FiF0KRQVJnpvvPAJlBnZ3QaQ== X-Received: by 127.0.0.2 with SMTP id vkhMYY7687511xHYNY2kNtsI; Sun, 31 Mar 2024 04:58:46 -0700 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.42]) by mx.groups.io with SMTP id smtpd.web11.15634.1711886325757451679 for ; Sun, 31 Mar 2024 04:58:46 -0700 X-Received: from DUZPR01CA0059.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::13) by AM7PR08MB5302.eurprd08.prod.outlook.com (2603:10a6:20b:103::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.45; Sun, 31 Mar 2024 11:58:41 +0000 X-Received: from DB1PEPF00039233.eurprd03.prod.outlook.com (2603:10a6:10:469:cafe::2d) by DUZPR01CA0059.outlook.office365.com (2603:10a6:10:469::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.45 via Frontend Transport; Sun, 31 Mar 2024 11:58:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF00039233.mail.protection.outlook.com (10.167.8.106) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sun, 31 Mar 2024 11:58:40 +0000 X-Received: ("Tessian outbound dc0a9029eb2c:v300"); Sun, 31 Mar 2024 11:58:40 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ba12a9508aadaceb X-CR-MTA-TID: 64aa7808 X-Received: from 3aeadb049afb.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 727BD2F5-E80F-4F29-9D1D-3947367F2211.1; Sun, 31 Mar 2024 11:58:33 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3aeadb049afb.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 31 Mar 2024 11:58:33 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB4PR08MB9189.eurprd08.prod.outlook.com (2603:10a6:10:3fe::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.43; Sun, 31 Mar 2024 11:58:32 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c%5]) with mapi id 15.20.7409.042; Sun, 31 Mar 2024 11:58:32 +0000 Message-ID: Date: Sun, 31 Mar 2024 12:58:30 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 1/9] Platform/Sgi: Correct typo in defining CPPC performance limited register To: Prabin CA , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Thomas Abraham , "nd@arm.com" References: <20240311131416.823580-1-prabin.ca@arm.com> <20240311131416.823580-2-prabin.ca@arm.com> From: "Sami Mujawar" In-Reply-To: <20240311131416.823580-2-prabin.ca@arm.com> X-ClientProxiedBy: LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DB4PR08MB9189:EE_|DB1PEPF00039233:EE_|AM7PR08MB5302:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: EPiAyQfHf6lmQnHvYx6jatNBLzvbw4EEIyi0kKzWltJuWzwCxPtxBoo957gxMneD/FvzToWG2u5vVC/yqCW/mW6FfO42VfMEKCQAKAkNBxMR4ihgtQPUhlW8yX+IP2xs2wUlmu2hdEq6hwH1Q/Jub3AMVkfaieIunsdSFby4HHl38jgHXJ+f1M+aBmeBRx/U1uMCz/lSjJ2F8ShrwFNlnnbvi7ETN459DZ5aIhqHrkS0T0Y/v1M1AHfo567X8ctg3kOgBmZSaO01vV9jB+yGphVyj/3GyQuZw8d5cr0RVRptMs5W52u6C7JwGO0cS0LOadIiu/98f2WHFX0H0QS8GMz40OfueMY1A0mSU7fmD+ELOOAyHFo0iu4yscXmig6yMU0pdc1xIpsF5RP/teGOAo2D5fYRlsEyahk5jYT/qOMoJkAudQmJLBDtsbdn1FN5T1p3TN2XV5929rb9gEGEo1MDJkIPOre0SNIiElgFa5pHLWHY0QPU+wEviQuQl0zE0OX+cwLkdYtRsBlW0HOJQ8dBse3xouFuqzUcREH56o5FgK5ykEZk/KT+MTpqXjs8L/idOM8qv+1s5RcqvnA0x5jaHQOvun4bCAW1T0Zj9rxQFOaLdr5WaDmeVgEAV0I5CRM85jkSF19/AsInb8iynriY7C/w95KUrBeL6qFoDf8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9189 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF00039233.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd3861af-dcb2-418d-ead3-08dc5179e818 X-Microsoft-Antispam-Message-Info: 2eR6EE5iXJjCM3Y6dp7adfImOz0RWoKm1TBGJwAOZyBR9tvXYcCOd6CIpteTUu4hKIrch+0zBEbgs9Eu2pPJnkqDvL4PHxNQo6zmCoW2c3/mZXi6/K+6ntxRVMqU+yfTr7c62KuSNYTpwqc1FkTD41/g6QMSdX+CYL1gHtSf5UmUxzePF5ZDD2Jl8a3aWe5yqakZKghX+kxR1IZyikcKHuDEY4S6kIhD6fv1h0H9I1ETABVRyleXOxtjiqFxYX/WLqF6D1imzPjD/Mu0Sdn/3QshjYPzYiKbVZ11XJSRo2MUsyQd6FKLp4M0jfBD5n+KmjNYFqTOFUR7Uy+VVp5kOgqKMlGxXNEUHL9kKJnf4ESfAY4vrrRT0zuWl7EWDemmjpvWFzlTvT6Nr/zKclh+pv+H7cT9+uAv5qmvUKLLVcF4nj6Z7vX1qlcmdJGJEoqpgs+4/LpZmuvekWJvLIcvgkKLiP8cQodQnNCdZ1N/1AyjVtiDhwi/86Tr5q+NKcrgLfqM5iSjLKfUWXCNkypXrrfdWMWbcf9xeTeAZUmUZ/XwyWixEOpYxtEYQBniaNIrER1MrW46AKAjSy3L4ntD/1gcwpkjtTHsqSXDtZhBHJ3B7I7bFnfmPemFxbDSzx69mn+m6l7hGGYxV1TWttJ49sRAdpCpXquuKv16rD5oC1pWN6EPfXbThvfUqd0lGNRqCJ5Tp34z9aTjXeFqs/tLKN934ApRSOdc3TdC4NpfU1fFmtkWkwS1kz6u4Z9TN55v X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2024 11:58:40.6607 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd3861af-dcb2-418d-ead3-08dc5179e818 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF00039233.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5302 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 31 Mar 2024 04:58:46 -0700 Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KFRZBsjFWNpxjalV9rqGVoeMx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="VeKE3/ED"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Prabin, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: > The reference design platform currently lacks the CPPC (Collaborative > Processor Performance Control) performance limited register as defined > by the ACPI 6.x specification. There is a typo in the macro definition > where the 'fastchannel address of the performance limited register' is > mentioned instead of the 'performance limited register address'. > Correcting this typo. However, it's important to retain the reference to > the performance limited register in the macro for future use, as it will > prove useful once functionalities such as power metering devices are > enabled. > > Signed-off-by: Prabin CA > --- > Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h b/Platform/ARM/S= giPkg/Include/SgiAcpiHeader.h > index 033d398fdb63..3e24f569c95a 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h > +++ b/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h > @@ -469,8 +469,7 @@ typedef struct { > =20 > @param [in] DesiredPerfReg Fastchannel address for desired per= formance > register. > - @param [in] PerfLimitedReg Fastchannel address for performance = limited > - register. > + @param [in] PerfLimitedReg Address for performance limited regi= ster. > @param [in] GranularityMHz Granularity of the performance scal= e. > @param [in] HighestPerf Highest performance in linear scale= . > @param [in] NominalPerf Nominal performance in linear scale= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117260): https://edk2.groups.io/g/devel/message/117260 Mute This Topic: https://groups.io/mt/104862626/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-