From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bounce+27952+111415+7686176+12367111@groups.io>
Received: from mail02.groups.io (mail02.groups.io [66.175.222.108])
by spool.mail.gandi.net (Postfix) with ESMTPS id AB828941B71
for <rebecca@openfw.io>; Fri, 17 Nov 2023 21:39:26 +0000 (UTC)
DKIM-Signature: a=rsa-sha256; bh=n3DeaP6HP14H00TX8TFoZgOpcIbNE1egMJSOCq520+Q=;
c=relaxed/simple; d=groups.io;
h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding;
s=20140610; t=1700257165; v=1;
b=HTeOnkp8DiT2N/IEn2EAG6PIF7Z80Iv+EFpDB0Tnh1xU+hnlkZ6dpBlAJlgJn5KMgREJt1UG
px5GoUZAkObDRP+NyoUfwlYaBbxUDcIKyjhKZz/5BUcqiA/MFcxNpXOBb9ZK5HywEM5imBFjQxb
38DjxJ5eLVS6xQW7yKPY3UJg=
X-Received: by 127.0.0.2 with SMTP id YZU9YY7687511xE1h5JIWI7w; Fri, 17 Nov 2023 13:39:25 -0800
X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mx.groups.io with SMTP id smtpd.web11.8433.1700257164635713280
for <devel@edk2.groups.io>;
Fri, 17 Nov 2023 13:39:24 -0800
X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-68-CXvvJ_kYOrmWtc5nSiEjqw-1; Fri, 17 Nov 2023 16:39:18 -0500
X-MC-Unique: CXvvJ_kYOrmWtc5nSiEjqw-1
X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7B3D58007B3;
Fri, 17 Nov 2023 21:39:17 +0000 (UTC)
X-Received: from [10.39.192.39] (unknown [10.39.192.39])
by smtp.corp.redhat.com (Postfix) with ESMTPS id BB4A51121307;
Fri, 17 Nov 2023 21:39:14 +0000 (UTC)
Message-ID: <cbdbb15b-c733-054e-b1b8-da13913302f5@redhat.com>
Date: Fri, 17 Nov 2023 22:39:13 +0100
MIME-Version: 1.0
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/MemEncryptSevLib: Fix address overflow during PVALIDATE
To: devel@edk2.groups.io, kraxel@redhat.com
Cc: Michael Roth <michael.roth@amd.com>, Ray Ni <ray.ni@intel.com>,
Erdem Aktas <erdemaktas@google.com>, Jiewen Yao <jiewen.yao@intel.com>,
Min Xu <min.m.xu@intel.com>, Tom Lendacky <thomas.lendacky@amd.com>,
"Liming Gao (Byosoft address)" <gaoliming@byosoft.com.cn>,
Michael Kinney <michael.d.kinney@intel.com>
References: <20231115175153.813213-1-michael.roth@amd.com>
<iftmx2xxkbyd76oxco2cwnozzqw5nkjqsnc2ieg22ygpem2hwr@pjaxqhffffxl>
<6f62e3d2-cf82-a23b-174a-fa24dd94fbe1@redhat.com>
<57te454l357zkcgohbee4afjsyyllvvhh4dcc3rfde54se6pvh@q2rcfktmjvc6>
From: "Laszlo Ersek" <lersek@redhat.com>
In-Reply-To: <57te454l357zkcgohbee4afjsyyllvvhh4dcc3rfde54se6pvh@q2rcfktmjvc6>
X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Precedence: Bulk
List-Subscribe: <mailto:devel+subscribe@edk2.groups.io>
List-Help: <mailto:devel+help@edk2.groups.io>
Sender: devel@edk2.groups.io
List-Id: <devel.edk2.groups.io>
Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io
Reply-To: devel@edk2.groups.io,lersek@redhat.com
List-Unsubscribe-Post: List-Unsubscribe=One-Click
List-Unsubscribe: <https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/plugh>
X-Gm-Message-State: bEaXpKIQc1yGvWr46wgES2sBx7686176AA=
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-GND-Status: LEGIT
Authentication-Results: spool.mail.gandi.net;
dkim=pass header.d=groups.io header.s=20140610 header.b=HTeOnkp8;
dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none);
spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io
On 11/17/23 12:42, Gerd Hoffmann wrote:
> On Fri, Nov 17, 2023 at 10:16:10AM +0100, Laszlo Ersek wrote:
>> (+Liming +Mike)
>>
>> On 11/16/23 10:01, Gerd Hoffmann wrote:
>>> On Wed, Nov 15, 2023 at 11:51:53AM -0600, Michael Roth wrote:
>>>> The struct used for GHCB-based page-state change requests uses a 40-bi=
t
>>>> bit-field for the GFN, which is shifted by PAGE_SHIFT to generate a
>>>> 64-bit address. However, anything beyond 40-bits simply gets shifted o=
ff
>>>> when doing this, which will cause issues when dealing with 1TB+
>>>> addresses. Fix this by casting the 40-bit GFN values to 64-bit ones
>>>> prior to shifting it by PAGE_SHIFT.
>>>>
>>>> Fixes: ade62c18f474 ("OvmfPkg/MemEncryptSevLib: add support to validat=
e system RAM")
>>>> Signed-off-by: Michael Roth <michael.roth@amd.com>
>>>
>>> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>>>
>>> take care,
>>> Gerd
>>
>> Is this hard feature freeze material?
>=20
> It is a clear bugfix, so IMHO it qualifies.
>=20
>> Also, the patch looks garbled to me on-list (superfluous line breaks).
>=20
> Patch applies fine here. I see mutt breaking the long line, but
> that is just the local display rendering, the mail good.
Can you check the raw message? I did that and it seems broken.
Superfluous newlines. I see *double* CRLFs.
Laszlo
-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111415): https://edk2.groups.io/g/devel/message/111415
Mute This Topic: https://groups.io/mt/102610323/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562=
12/xyzzy [rebecca@openfw.io]
-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-