From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.43]) by mx.groups.io with SMTP id smtpd.web11.61304.1673543371773343576 for ; Thu, 12 Jan 2023 09:09:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=os7JRnSh; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.43, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WTvQPkoUUg0kRyHqoaSp/Y5trEMlwIEDjpUdzr70qVQHlt3o5wAA8WmOlMxnZtVY4uUR9x/dPxN/UW0MJc8rj0J9zZSBL02UOmpFEboYGba5KJ+nMVTyyCJTYZndZ487GhCedfbKL7T/at63D6R3gX6mBzu8DPNqUrtlEX4LksztOQ6uYiJdsy0X0JmWlTSRt65OOJCS2dhPh2X9YpSWrDXjDz5x0yida/GXUQWAKTTWvNG8tUDtZ5DtDAjK0YixMfFNZ1OjwlH3BYDD8FYmWbaVwA/AO/68+MObwbSZ5wYIg1vo/ibY0XznLenqVMeRxdUffQaS6nx2uHE3f9UBfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P64XJQRTWFD+DKpFKPEkJkBTpogIyUiyqQ9bXnhFCl0=; b=jRoixiFBTW63zqMQwIVGz136E+/B5wH1752w9H1DhymKLJRI8v8WvVdKKvV7+TKSBH/s5BaDjAMc3ii5v2eJemtJ0POB2KzOi5d1W8hwa2bT2UdbH2tJwgDA8F3tnw844y4Lsv0HehC/K+rERuUKgrtYoKVSvLDYwJhL7Y3/kpSQWKyHf6lNj17QsHTNZUUIjDrUK/TkERctj9fpRakfOENpmHNFSlNss7FqUgsLZAeYDQS2tF1c2nCrmXisfynItGtnJXTd2GsqwjXR9P9lmv80ZkS9mncIqQlRdrcawdAiKCb78L3Sby+gBt/Xg28sQZkfb3N4pm1cDoV7k3gF+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P64XJQRTWFD+DKpFKPEkJkBTpogIyUiyqQ9bXnhFCl0=; b=os7JRnShobt3ZRSIZmjnAmTrVLcqmPCxc0m0BMTV6MUHF1aVxUxIAIERWFzcF0je2KdSIrg16jul0C8+h4AgQqP6GxzmJlyTOOYNEc3X3ryfqAdbYIW5wP6Jgqs8+M3q3ao/T3gpR8kJu6WP2TWPVk19BPp8lnfz7Lz2rRXFhoc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by SN7PR12MB7156.namprd12.prod.outlook.com (2603:10b6:806:2a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 17:09:29 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::8200:4042:8db4:63d7]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::8200:4042:8db4:63d7%3]) with mapi id 15.20.6002.013; Thu, 12 Jan 2023 17:09:29 +0000 Message-ID: Date: Thu, 12 Jan 2023 11:09:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformInitLib: pass through reservations from qemu To: devel@edk2.groups.io, kraxel@redhat.com, Laszlo Ersek Cc: Oliver Steffen , Ard Biesheuvel , Jordan Justen , Jiewen Yao , Pawel Polawski References: <20221207053215.2527430-1-kraxel@redhat.com> From: "Lendacky, Thomas" In-Reply-To: <20221207053215.2527430-1-kraxel@redhat.com> X-ClientProxiedBy: BLAPR05CA0018.namprd05.prod.outlook.com (2603:10b6:208:36e::13) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|SN7PR12MB7156:EE_ X-MS-Office365-Filtering-Correlation-Id: a71a92e3-e2ea-4d79-0374-08daf4bfc42c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rpd8UB96Ft6abVS7NOiV3TekPxi17hveZd4wrCYNnQ1pBM0twKZ9qYHvGakHNjAKp2B2lIbYa/6Z/osYyHZqYcRkpVhnE6/bnyCyqWK0P2fw/OqxknoM9KJNQF3nQpSR33I5HRJ3KCHs841Acew+yG2eoHcPuY0Wt79pHJV9fboGb8Xqu1CUonpeadJCe+V4jSWva0/YZ4G5EyhoPyUTTmGm9qeTzIrEeqnV57T+cgn6rPjsDFFzm3gpvkRa9aWYkjKlk93vrLoRi2U6S5piMi/yhU7+D8RrH0pTKYkTnnzgl2EMVOzDYgtfwUE4kePzEzo1O4AJe3UddZvjFmZippePWDTkt1WAIyCAv4rFQ5PVywil4nvdwzYoT80dna+JrxmxeIUQPoeaik5XMOxPTptu5Qx0Qs39NHAW6cFfHwNQg4U4FD4yqNlGpomDoYKnDN1WEHyxWPaj9UCuCfWExkeYWNFSS47tkBHFIh51kqToKLZnwwG2D+M4eSi+Vquf0ZZLUSXyfh6J+OfXvpN2+O80dkxOSgD8QAHAMDtEsTAG18a3Kxx41zM6EC0/q6/IulTFjlUPCGnrO0pBEw67BW27sXWQczih0s9r+v8qeo/VnYYIyCbbabK6FClDdw1DUWVT9d9nrbdx7EhYR8zEPmCwZQ4qFBkoKgdPnxQHqZdQ58cLtPfe3faVg2S1vSqQox4hTLxwksZjXRV9a9miTPuZrX2kj3z1ALUU6zJZnIs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(396003)(376002)(366004)(451199015)(66556008)(66946007)(8676002)(2616005)(66476007)(4326008)(316002)(19627235002)(54906003)(6916009)(2906002)(5660300002)(8936002)(41300700001)(36756003)(83380400001)(38100700002)(53546011)(31686004)(478600001)(186003)(26005)(6512007)(6486002)(6506007)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3p1QjM3MUkvTVFaWlYyc1YydE01LzRjNDZQcEV0OWtsd3RkTE5YcjNUdGti?= =?utf-8?B?a05KcDJLZmQ0Mk56TFIxYmlmT1ZiV3NTZGRHcG12N01rOER5NW9YY0Z3Vyti?= =?utf-8?B?SWZ4amxZZWY1ZDEwcDZiUFlFM2YzS2JWT2I0bkYxYjM4Ny9LQXlPbW9lNW40?= =?utf-8?B?UmNsQzlFZXVXcnVIWThYMW93UXd3dVRUdk4rcW40N2ZBNjNQckUyN2Ixd1la?= =?utf-8?B?SUl3Z2dxcGdXdEwvc2dFV29lengzK1cyOEZsb0ZqNFdYeUVDVGIwNHpnWUVW?= =?utf-8?B?Z0Nydnlzb093S29mT3JiUTZPNitTb0wxQ0xCZGxCbDV5eUxTUVI1U2FEMlps?= =?utf-8?B?cFJCRTgzRGI1elVnVVJUb01tMUh3d0tYMHZpZDBMYlhiSW4zR1FxYTJEY1lu?= =?utf-8?B?V292a2ZHRFJDQU44Vm94cm15S0t0WWViaXhDMmZVTFgyQnJJSU9MN2x5bFNS?= =?utf-8?B?QmtmeVNrZGRlejN4Nyt2WCtoMXBPdHZ6SWpRZldLS2E2MXZ4SlZwVTU4aXN0?= =?utf-8?B?cVBHdXZDSXhxUytiVUMydk1UZWhkMHhVYVNYcUYwK1FCOXlNTHVRQ09BNWl4?= =?utf-8?B?MW1MNUk4K0YyZlhnbE04Q28yWHdsUW1ta0V5RmxTWkxTMzlaSGgvVmZFUjRx?= =?utf-8?B?YkdrNU4zN3JOM3ZSbXNvQUVzREtveHRaNUxVak1rd3ZaU3lMdExTZXRpL0da?= =?utf-8?B?RHczdHg4NlFpZTdNNVZuZFFkQ1lxRjhScWpwcVJhVkJQN1pyOG1reUZEdEZm?= =?utf-8?B?MEpDamRhWElCNG5UNXZNMWRXVjgzbFFtaTRxMFhBVkwvQzBTK3dCSlhSblRn?= =?utf-8?B?ZlpDRlIwQmNpUi9tVm9mWTBScGk0YXRERkFzWnNDTFRFWUFnVkt3WVR1QXJO?= =?utf-8?B?TVpZYXJDQmhWbGxDZWpLY0Z1aDB4emJ1Ujl4L3Z3cWRLaHlUN214aW9MMWMv?= =?utf-8?B?eDBHUkJnUlJTVUZGZGd0QmU4YnlmTHcvVFBnSm9CR2Jjc1Fnc3ZLQnU2MzR0?= =?utf-8?B?ZEIrV2hadlJTYUZrOTYvZklBZkpieEJLdVJvcFpweUhNaDdyRThzN3A4SDQv?= =?utf-8?B?eFFnb09IMGZEeHRHRzZWazhxSDNNL01JVFBPcHBOL2hNaS82MDRVVEdFZEI2?= =?utf-8?B?MnZ3MWphU3Q1WGU1bFNmalBDMVhYRXJyclNFT0RCOXdWUTR4TzJTSENGbDJQ?= =?utf-8?B?UXBUY1kwdEgvc2ZRTDc2dzV5Z09qOUJxbC8vUzV4SjUrTnRwbUk3YUIwRHdW?= =?utf-8?B?S3ZNa1FKd1VicVQ1OEdTMUNJNzhpZDlvUjlXWGJTVlBKRjB6VS94K1Rvd3da?= =?utf-8?B?a2VVZXhCbDA1ZVlrMUE1dlp4OXU1Z1ludjJuLzBEZGxCM2pjYWdvY2FOclRO?= =?utf-8?B?V3JEMFpGSys5OHMxcDZpeFg4cGp3TmtYL0N2TlNQUzB2dTBvT1FBWCtBNytp?= =?utf-8?B?YnYxVGVNRE50RlA0NHhHVUFsQy9GOFp3R1k5NkVJSlpEMzJaTFhVbFBUSkpi?= =?utf-8?B?cVJhNnptVjF6dGJCaEhMeTFadU5jNTQrRlN4SlhQY1NYYk1JMk5WVGg1WXE0?= =?utf-8?B?Nm4yU0dxREh6TFN6cGpNSjVtSnJSS1JqWWUwZkgyVlRFbTJsaTlDRnMxUGdL?= =?utf-8?B?ZWJuZ1ZrYlNFZGtxSG9BM0FBTE1XQjJIaCtiZDBQc1RNSmVsQUZlQjIrM2RX?= =?utf-8?B?aUwxWWowQlV6ankwZGU5cTFyWWE0R0ZrM1VseHNvZzJnRmE5ZkV1cjNBYytN?= =?utf-8?B?MTZOakhBdHFFbmpLRUNEbVM1UXFDd0d3OFR0ZU1xdHhqcjdvR29FbjVxVGxG?= =?utf-8?B?cHJyamlMWHpuc2hOQVpsRVFwTG1haVQycFVTNFZ6aUI3QmgwV0VRZXliV3A1?= =?utf-8?B?WU5QZE9oTWZCL3M5L0NLMTVnRmsxcC8xdjFvckREb0ZwK1ZxUUVZdXdEd1po?= =?utf-8?B?dHp3eHZHS3IvaWNSWWlMM2ZxV3UxbDlDaXM4RjRwckNQYll4b2J5OFNYM2J6?= =?utf-8?B?Um5XSnlENVFNRU55cXBRZXVWMW55TlFLZFUxQ2xBTzluTW5zaTRzejB3Z0Rh?= =?utf-8?B?R1IyV0JVbkhEWDN3TGl0bEI3VklPVmxGVThYS2FxbXMyQkVVcXFNTzUvRTlG?= =?utf-8?Q?xNtvG9bsqQCP1JqtQcxnuOC8Q?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a71a92e3-e2ea-4d79-0374-08daf4bfc42c X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 17:09:29.5371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D3bfJPjvhcKGWYbG6Z6q0eUHJDf2UL6kJ4a6r/NFFk/1yT9WdVrtdZr/0KC7qtHYWyK5hQ49DLb+qWqZ/l0ANQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7156 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/6/22 23:32, Gerd Hoffmann via groups.io wrote: > qemu uses the etc/e820 fw_cfg file not only for memory, but > also for reservations. Handle reservations by adding resource > descriptor hobs for them. > > A typical qemu configuration has a small reservation between > lapic and flash: > > # sudo cat /proc/iomem > [ ... ] > fee00000-fee00fff : Local APIC > feffc000-feffffff : Reserved <= HERE > ffc00000-ffffffff : Reserved > [ ... ] > > Signed-off-by: Gerd Hoffmann On newer versions of Qemu, this patch causes a boot failure on my AMD system with the following output: ... PciHostBridgeUtilityInitRootBridge: populated root bus 0, with room for 255 subordinate bus(es) RootBridge: PciRoot(0x0) Support/Attr: 70069 / 70069 DmaAbove4G: No NoExtConfSpace: No AllocAttr: 3 (CombineMemPMem Mem64Decode) Bus: 0 - FF Translation=0 Io: 6000 - FFFF Translation=0 Mem: C0000000 - FBFFFFFF Translation=0 MemAbove4G: E000000000 - FFFFFFFFFF Translation=0 PMem: FFFFFFFFFFFFFFFF - 0 Translation=0 PMemAbove4G: FFFFFFFFFFFFFFFF - 0 Translation=0 PciHostBridgeDxe: IntersectMemoryDescriptor: desc [FD00000000, 10000000000) type 1 cap 8000000000026000 conflicts with aperture [E000000000, 10000000000) cap 1 ASSERT_EFI_ERROR (Status = Invalid Parameter) ASSERT [PciHostBridgeDxe] /root/kernels/ovmf-build-X64/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c(550): !(((INTN)(RETURN_STATUS)(Status)) < 0) Doing some bisecting, before Qemu patch 8504f129450b ("i386/pc: relocate 4g start to 1T where applicable") this issue wasn't observed. And before this OVMF patch, the newer version of Qemu doesn't have an issue. Also, if I add host-phys-bits=true to the Qemu -cpu parameter, then the issue isn't observed regardless of Qemu/OVMF level. I'm hoping someone has an understanding of what is going on and what can be done to fix it. Thanks, Tom > --- > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c b/OvmfPkg/Library/PlatformInitLib/MemDetect.c > index b8feae4309de..a7a4e028ad50 100644 > --- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c > +++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c > @@ -228,6 +228,22 @@ PlatformScanOrAdd64BitE820Ram ( > )); > } > } > + } else if (E820Entry.Type == EfiAcpiAddressRangeReserved) { > + if (AddHighHob) { > + DEBUG (( > + DEBUG_INFO, > + "%a: Reserved: Base=0x%Lx Length=0x%Lx\n", > + __FUNCTION__, > + E820Entry.BaseAddr, > + E820Entry.Length > + )); > + BuildResourceDescriptorHob ( > + EFI_RESOURCE_MEMORY_RESERVED, > + 0, > + E820Entry.BaseAddr, > + E820Entry.Length > + ); > + } > } > } >