From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.47]) by mx.groups.io with SMTP id smtpd.web08.6887.1666787715164543039 for ; Wed, 26 Oct 2022 05:35:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=uVcCNsUp; spf=pass (domain: arm.com, ip: 40.107.7.47, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QZZX8jkJpKZo72jhnsnvRlXOMAv8TO5KjeGbPZD8W7pbkZuuJIcbtWrddiZ+ikO48hAW1T3SJiAJLqmeTiG80vi7+UlX6OVK+4zBv6/ujjVJoP/MsghG7/ucDhbAGVEyRkdpW3YQ0yTrj0M5n/fbRjtIvzQocolOO9yCnwWKnBkWvH0L5AmfIFyn+jEyfASlPOh5ig8R7RHRO5XP+aT4g+rtGnGrmUwr1thQog1/4svSb3XdsOnHoQv/4kdt1pJlHweRUpyJfTX5muYLBq2g/TAP4picP7Ec2IMQLHL7vHGVxFAe/eYTJ76p7Guh2n5IuzR9n0OMrm2WIq40jm0/pg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w2vcmfDkK9QGd9nWkIUkBYNgb99s2KxRn69S75Xnq6Y=; b=Xpq5vxgjVRu+W+QF6fl/P4z6Jc8H5WjghOn0k8NO0ahUYvOsESH+CpeDCJClC/LAHPpAI+sC7hnCJHL4a+K4kdsDeG925S98TUvyv/5GloSYeywpbLf6FNpL2HVmQcfKRtBhXrLUMOBgDe5V+2FLLwcW1KmatbJmXlkSpS8KCvbix5qszIhTIrybuSwf1KcN1V6nzcWvLWXKit+HMaMOde5Ztm3gfEfIaq+GIk5V9xGVVpHlvG1M21hK34yRziOd7n1XUIJrzCF81YSGGpF2+Yf/rSexiBL3Ohh3UPe5RT/3I8Znf69M/Q5O/2lDVmf/9Aa0gHWlINnUkij7Q+w2qQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2vcmfDkK9QGd9nWkIUkBYNgb99s2KxRn69S75Xnq6Y=; b=uVcCNsUpRTybUZzf0wRBZBeo3jbQxSNHN87+PR/QykqkTVz9rQQv66/NmwtoIQBVWeH+8DBiScG7nE+4Tl+F3UXW8IreP9t1P0SbLn4vvNeWdpj77gcDXr7mywYwGbLylFOjKqYGXRBeEkX4a4Px0Se9fC69mR7dLoSpoCWovic= Received: from FR3P281CA0125.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::7) by AS2PR08MB9103.eurprd08.prod.outlook.com (2603:10a6:20b:5ff::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct 2022 12:35:11 +0000 Received: from VI1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:94:cafe::63) by FR3P281CA0125.outlook.office365.com (2603:10a6:d10:94::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.13 via Frontend Transport; Wed, 26 Oct 2022 12:35:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT064.mail.protection.outlook.com (100.127.144.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend Transport; Wed, 26 Oct 2022 12:35:10 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Wed, 26 Oct 2022 12:35:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 21fe92f04b5bdcdd X-CR-MTA-TID: 64aa7808 Received: from cf465745fdc5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C77EA82E-82C6-4A55-B18B-3E4C685751DC.1; Wed, 26 Oct 2022 12:34:59 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cf465745fdc5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Oct 2022 12:34:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AcNiDv1yVVDmFCr34lyDOCODG/pp8AMG3bH73WlgFxmvp83GULtwLCQi/O7AX7ZTf3sQiP560uHBxuUzmmGR7Pu1SHC5xwb1TLmxqdUnrZI3X7nBYLLQ6P9no/LbMBfQCllhQaAegaf9Ki6zUybLjZoDPHYZoWsG0mcvq6+Wb29qk/PG65TSCPCRMsf0Fs010eXVkgCNTjVy59wfy24UyW4VLo2gB0fr9lInumKig9ie6vWX22a45F8T3F5HFEYETh89ep8Jdheurs8eXhmGTNxYe+4YPi67dBTRdWbxUF9ycDHi+lL084CoOTEoW0ujR4IwTBg09gyHQHnt2/fmIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w2vcmfDkK9QGd9nWkIUkBYNgb99s2KxRn69S75Xnq6Y=; b=YVYY54Ph6+zR11Cib0dRRbZF5Uwx9ilrL3zn/0JD4lq3FnrRFrHKNQxgyLGK6dv3jAoP1xZSit1gsBjKqenWwzyZDEDVlQE6izpZB3uykJNK1MQYWoPuU+duSPQNHI9Pjb8x28rkdOjqIjbKCPcZhhDSPIw0Q9CHsxxCCRoEa8EmioF9lJUPZZkqyK3W3LoW73NZBRuV4L042KpSXRd6WFhEaUBZjgiN0LSVUGCfAMXIMSUJgnQ/+E5seU4U5/R9fQylU2dmMQvbuTDbOkBn82uccd0oe61sEOnScgmk7TtQmV4qFU/u9V4xX8/O6p0QPEvRD4Ul96lrfD5h/hw13w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2vcmfDkK9QGd9nWkIUkBYNgb99s2KxRn69S75Xnq6Y=; b=uVcCNsUpRTybUZzf0wRBZBeo3jbQxSNHN87+PR/QykqkTVz9rQQv66/NmwtoIQBVWeH+8DBiScG7nE+4Tl+F3UXW8IreP9t1P0SbLn4vvNeWdpj77gcDXr7mywYwGbLylFOjKqYGXRBeEkX4a4Px0Se9fC69mR7dLoSpoCWovic= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DBAPR08MB5813.eurprd08.prod.outlook.com (2603:10a6:10:1a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct 2022 12:34:56 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5746.027; Wed, 26 Oct 2022 12:34:56 +0000 Message-ID: Date: Wed, 26 Oct 2022 13:34:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 12/14] DynamicTablesPkg/AmlLib: Allow larger AccessSize for Pcc address space To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov , "nd@arm.com" References: <20221010092058.118714-1-Pierre.Gondois@arm.com> <20221010092058.118714-13-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20221010092058.118714-13-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0298.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::15) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DBAPR08MB5813:EE_|VI1EUR03FT064:EE_|AS2PR08MB9103:EE_ X-MS-Office365-Filtering-Correlation-Id: d2cab10f-3952-4c85-37a7-08dab74e8610 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: y1w6MjDl7Qcje9VitDo0xOA9cM+h4c0YgRuBv2iqUyI/TPuJXE/HLD0ffvK0jm3ND/jrMnpWJh2hCfKbHDVK7bL6qkINpztmhR0oOsoUsISHO1e767YFMtWOAiM3UDD6g3biw4dWUtrkFjf2AXt6Hj79GOp3PMz3W8/8ReJmQhH3DKOoCeS2pAcmFF5TIvDW/6N02fbNaN9zsscYCtnLXpPiWoWeO+iVOzQynEcNGFP8vWM+zhOwCx6O4MfpDKMNwlX4O0MoZGYUDHwupbPhoVNAusLoK16+yIz4nJvBZx8kGCclumw8OEjU5I+EfOiu/Gz1Xx1uJTALo6+YPQjq/ahQEi6eZhMgf9P1A/6OH0wmIJ4G1El5LGYJYwG7Ckju60JlSMJwfPMJVlCDIwE5JPqLddAqcZOcC0ZYpMBo+jvwOMreRzoj97qeemu9hpuxTEMWUQn1MSbLFDfVHT7d6GsIqQqQjYqRzzOHpyQ56JS7RgaxQ9SKxgUwn6O7GJP1jMKR79PAhFmAp/CAg7qxzoVG4RGB18N0L9IyWoUZa2/vHaf3S7dLb72xF/vn0ajZQaiBhDFijCpZMF3vxG3aoZCbBl8oXF0KtyIZpr6YB5PpfXEudcYg/0A+vB4fBH/9TZeaVhedr3sUIkaUqIU/LSNjC4VhUZGrr/MUmh12nWI9gmg/PoVmtiafaAjFOgv9Q7hr4Txc99LzwSOWeKSWFRnGrtWuV4Ps3rDaW45p9EIyzZT92Es4NDNq0SC5WCdkbIoUQL6qtM5R4U7J1NGpwNXjBL7ztV3S52buC+cVhbbMESxZ0oFtqJZFQjWf17Lv X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199015)(38100700002)(6512007)(36756003)(186003)(2906002)(31686004)(83380400001)(41300700001)(2616005)(26005)(8936002)(5660300002)(44832011)(6486002)(478600001)(86362001)(31696002)(6506007)(8676002)(66556008)(66946007)(66476007)(4326008)(53546011)(316002)(54906003)(49343001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5813 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6727ad55-2763-4438-d4aa-08dab74e7d16 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ng2vyICNsoO17ZgSyrdDwiP3/nE4QRtoKt9wZ2uR3SgToqa2YXXTDMP5hMyicXBQC736iBf0LkKk2uj6RGKIWUZWMtz+Y53br9pigpL8ZEhd6m6b4/N3NIDVHOTp9aXAZK97PCT5Aaa3vYPFZFOlKDzZcZsQMLhEXHPmnhx5NRDkJiRGUPcCFF8MgrVMMnMTk1Mz3+KUGNny3YjZIh+MLVMPupVAvy5pj9g2+cIGYC9k/mcvsBfjCwKX933CkLnsxX0i9cMhbf0LaRdSmzY/TWiEiyzZJbAEpL5Wdb+a61ii4vCOw4gwBZc7GZl3wLtEuMVUYjcx7SHLDH/pt+1OuWImQo0FCB5fU/e8oEqkoOu22nqsepfWpiuT2CHnbqvMvBve/V04oBoc3Pav++kMPNyZgmUejIzd4bA7fanfmjcnwtFT2bM6hK4qlLk/XKLfVpHilM8qcO9BEy+lgsCdcsrUdI5+4oZtzr/NXfppYtGj+0rF+XqWazMh3z2YZ0xPj1yR1vSkh9q84T4XBoi627Wpv3mr/GeXGaIaw/01JHBRWOjFzETQGEd+bV/CWQBv1WZ8fM/7Vfx3aUn7Tj/MaFeJp1/L6ceDIBGtuyc59EPpSQl8CvIWV+sM/JwrWjGpnK82wVEsc08gx8mQUjPyXglekuSPsSolYB2/evGR/5DX2BgVsVwrIEbFKLBzVhb48/7F0YDqNaASCUtOoV/TFwvsVKImR4S5uRHy6Vozcu6/FxkzlX35BKcaK/Tg3ac2ioELbFeTBaLHJYKU2aPGUT97pa+t7t1GKJXK4b5Twa4HALD5v/xw1th80qIBgEDQ+Fz8Q4jzHj2/X2VK103HXg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(31696002)(83380400001)(31686004)(41300700001)(478600001)(6486002)(86362001)(4326008)(6506007)(8676002)(36756003)(53546011)(6512007)(47076005)(5660300002)(70586007)(44832011)(8936002)(186003)(336012)(82310400005)(2616005)(40480700001)(2906002)(356005)(40460700003)(36860700001)(70206006)(54906003)(26005)(316002)(81166007)(82740400003)(49343001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:35:10.9794 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2cab10f-3952-4c85-37a7-08dab74e8610 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9103 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, There are some minor changes required marked inline as [SAMI]. If you agree, I will make the changes before merging. Regards, Sami Mujawar On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > For Pcc address space, the AccessSize field of a Register is > used to delcare the Pcc Subspace Id. This Id can be up to 256. > > Cf. ACPI 6.4, s14.7 Referencing the PCC address space > > Signed-off-by: Pierre Gondois > --- > .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > index 332962bed441..3901b6e47333 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > @@ -1257,7 +1257,12 @@ AmlCodeGenRdRegister ( > AML_DATA_NODE *RdNode; > EFI_ACPI_GENERIC_REGISTER_DESCRIPTOR RdRegister; > > - if ((AccessSize > EFI_ACPI_6_4_QWORD) || > + // Cf Cf. ACPI 6.4, s14.7 Referencing the PCC address space [SAMI] Cf appears twice. > + // The AccessSize represents the Subspace Id for the PCC address space. > + if (((AddressSpace == EFI_ACPI_6_3_PLATFORM_COMMUNICATION_CHANNEL) && > + (AccessSize > 256)) || > + ((AddressSpace != EFI_ACPI_6_3_PLATFORM_COMMUNICATION_CHANNEL) && [SAMI] Change EFI_ACPI_6_3_PLATFORM_COMMUNICATION_CHANNEL to EFI_ACPI_6_4_PLATFORM_COMMUNICATION_CHANNEL. > + (AccessSize > EFI_ACPI_6_4_QWORD)) || > ((NameOpNode == NULL) && (NewRdNode == NULL))) > { > ASSERT (0);