From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 23 Sep 2019 08:03:24 -0700 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EA1306412E for ; Mon, 23 Sep 2019 15:03:23 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id z17so4981755wru.13 for ; Mon, 23 Sep 2019 08:03:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A+Np/yfu9gYoM57YEV8mA0FW3gMfwzQ8v3IPse3KLV8=; b=KnWV4VuiP8eTzy4JTLNZ124knchvaF73/0k+qz7lrPVeKJHmBH3Z1V0SCQ2Phqot3n 3LAZIk6xPQd+gTwBLOTTMXiTPIx0J5WBDDM0QDESB4cb6HMgHBPyQzQEeYkIkK/JvKrQ mxOq6CCgLiqfdvp9R9bov+pbsGdjoM+o3xHLio/MULabgdNL3QNUEUP6+T4RuhDzFUMQ 049ZsA0bGonI4+tKevc+TidiVOXhxW1MvTsXjp0d0T2AeN52i4JNQ+PtbNwKprZjaRSi 3bQ7tZ9e3V81YaPQdm5rj/WeUUIO+cp5W3dMelBqIYscGjHuXlwUAx368FjfsSinGTrB Kigw== X-Gm-Message-State: APjAAAW5yDsTOcWZNUe0gM71AnZU6Y/ZSMdVKuEmmzb0HEF83lfRSOv5 aqhd9rvJyFYvEMEqUAaiwRhOF3Qpd1XSEAg29nE6X7iBItaobkeuTbVBdj7Rl0ROwE0RkOPg0vv Qq+7H5ISm7py+jw== X-Received: by 2002:adf:eb05:: with SMTP id s5mr9151447wrn.360.1569251002215; Mon, 23 Sep 2019 08:03:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqx+sAOoHHT8FWN3ZsMqIRWnEs0VRQXJ0UXV95dyY524n2ooBm0b/weNZJv5HInI8qZnplvHoQ== X-Received: by 2002:adf:eb05:: with SMTP id s5mr9151423wrn.360.1569251002043; Mon, 23 Sep 2019 08:03:22 -0700 (PDT) Received: from [192.168.1.115] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id b15sm11248923wmb.28.2019.09.23.08.03.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2019 08:03:21 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 22/35] OvmfPkg/XenBusDxe: fix UninstallMultipleProtocolInterfaces() call To: devel@edk2.groups.io, lersek@redhat.com Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-23-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Mon, 23 Sep 2019 17:03:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-23-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/17/19 9:49 PM, Laszlo Ersek wrote: > Unlike the InstallMultipleProtocolInterfaces() boot service, which takes > an (EFI_HANDLE*) as first parameter, the > UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as > first parameter. > > This is an actual bug. It must have remained hidden until now because it's > on an error path. Fix the UninstallMultipleProtocolInterfaces() call. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Signed-off-by: Laszlo Ersek > --- > > Notes: > build-tested only > > OvmfPkg/XenBusDxe/XenBus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/XenBusDxe/XenBus.c b/OvmfPkg/XenBusDxe/XenBus.c > index bb8ddbc4d44d..2451e58a5961 100644 > --- a/OvmfPkg/XenBusDxe/XenBus.c > +++ b/OvmfPkg/XenBusDxe/XenBus.c > @@ -210,7 +210,7 @@ XenBusAddDevice ( > > ErrorOpenProtocolByChild: > gBS->UninstallMultipleProtocolInterfaces ( > - &Private->Handle, > + Private->Handle, > &gEfiDevicePathProtocolGuid, Private->DevicePath, > &gXenBusProtocolGuid, &Private->XenBusIo, > NULL); > Reviewed-by: Philippe Mathieu-Daude