From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: shenglei <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH] MdePkg UefiPciLibPciRootBridgeIo: Remove redundant dependency
Date: Tue, 18 Sep 2018 16:44:49 +0800 [thread overview]
Message-ID: <cbf9e385-f71e-49a8-c11e-148b02819f4e@Intel.com> (raw)
In-Reply-To: <20180918032903.31668-2-shenglei.zhang@intel.com>
On 9/18/2018 11:29 AM, shenglei wrote:
> PiDxe.h is not used PciSegmentLib.h.
> So "#include <PiDxe.h>" is deleted.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1183
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
> MdePkg/Library/UefiPciLibPciRootBridgeIo/PciLib.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/MdePkg/Library/UefiPciLibPciRootBridgeIo/PciLib.c b/MdePkg/Library/UefiPciLibPciRootBridgeIo/PciLib.c
> index 575d9c1f91..f89e3e2551 100644
> --- a/MdePkg/Library/UefiPciLibPciRootBridgeIo/PciLib.c
> +++ b/MdePkg/Library/UefiPciLibPciRootBridgeIo/PciLib.c
> @@ -13,8 +13,6 @@
>
> **/
>
> -#include <PiDxe.h>
> -
> #include <Protocol/PciRootBridgeIo.h>
>
> #include <Library/PciLib.h>
>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
prev parent reply other threads:[~2018-09-18 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 3:29 [PATCH] MdePkg UefiPciSegmentLibPciRootBridgeIo: Remove redundant dependency shenglei
2018-09-18 3:29 ` [PATCH] MdePkg UefiPciLibPciRootBridgeIo: " shenglei
2018-09-18 8:44 ` Ni, Ruiyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbf9e385-f71e-49a8-c11e-148b02819f4e@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox